Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-cairo - Python 2 cairo bindings
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Summary: Review Request: python-cairo - Python 2 cairo bindings Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: johnp@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://johnp.fedorapeople.org/downloads/python-cairo/python-cairo.spec SRPM URL: http://johnp.fedorapeople.org/downloads/python-cairo/python-cairo-1.10.0-1.f... Description: The pycairo package changed its name internally to python-cairo to be consistent with python3-cairo. This unfortunately causes issues with uploading new sources. Since upstream has changed the build procedure and we need to get the new package name approved and listed as a existing package, it makes sense to put the package through another review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@gmail.com AssignedTo|nobody@fedoraproject.org |karlthered@gmail.com
--- Comment #1 from Haïkel Guémar karlthered@gmail.com 2012-02-08 16:36:51 EST --- Few remarks * For arch-dependent package, *-devel should have a fully versionned requirement Requires: %{name}%{?_isa} = %{version}-%{release} This is now a MUST for new packages review. * i suggest you do the same for other arch-dependent requires (python-devel, cairo-devel) * unless you plan to support EPEL5, drop the requirements on pkgconfig, the buildroot and defattr stuff * though it's optional, i suggest that you drop shell style macro $RPM_BUILD_ROOT and use %{buildroot} instead.
*let's check rpmlint output: rpmlint python-cairo-devel-1.10.0-1.fc17.i686.rpm
python-cairo-devel.i686: W: spelling-error %description -l en_US interoperate -> inter operate, inter-operate, interpenetrate python-cairo-devel.i686: W: no-documentation python-cairo-devel.i686: E: incorrect-fsf-address /usr/include/pycairo/pycairo.h 1 packages and 0 specfiles checked; 1 errors, 2 warnings.
rpmlint python-cairo-1.10.0-1.fc17.i686.rpm
python-cairo.i686: W: self-obsoletion pycairo < 1.10.1 obsoletes pycairo = 1.10.0 python-cairo.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/cairo/_cairo.so _cairo.so python-cairo.i686: E: incorrect-fsf-address /usr/share/doc/python-cairo-1.10.0/COPYING-LGPL-2.1 python-cairo.i686: W: install-file-in-docs /usr/share/doc/python-cairo-1.10.0/INSTALL 1 packages and 0 specfiles checked; 1 errors, 3 warnings.
rpmlint python-cairo-1.10.0-1.fc17.src.rpm
python-cairo.src:54: W: macro-in-comment %{_bindir} 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
==> FSF address issue, according Fedora Legal, maintainers are entitled to report this issue upstream, you are welcome to patch this but it's not mandatory.
==> "private-shared-object-provides" should be fixed, that can be done using the following snippet that filters python arch-dependent module before processing provides %{?filter_setup: %filter_provides_in %{python_sitearch}.*.so$ %filter_setup }
=> the rest can be safely ignored
As soon as the previous raised issues will be fixed, i'll formally review this package.
https://bugzilla.redhat.com/show_bug.cgi?id=731891
--- Comment #3 from Haïkel Guémar karlthered@gmail.com --- Last time, i checked on #fedora-devel, J5 changed work assignment so someone else from RedHat Desktop Team was supposed to take over, anyone can help on that ?
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@gmail.com, | |johnp@redhat.com Flags| |needinfo?(johnp@redhat.com)
--- Comment #4 from Christopher Meng cickumqt@gmail.com --- Can't believe this package is not in Fedora...
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE Flags|needinfo?(johnp@redhat.com) | Last Closed| |2013-09-07 03:28:48
--- Comment #5 from Christopher Meng cickumqt@gmail.com --- Hmm..Because Fedora uses a different name.
*** This bug has been marked as a duplicate of bug 770828 ***
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|DUPLICATE |--- Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pbrobinson@gmail.com
--- Comment #6 from Christopher Meng cickumqt@gmail.com --- *** Bug 770828 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |957409
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(johnp@redhat.com)
--- Comment #7 from Christopher Meng cickumqt@gmail.com --- Hi J5, can you finish this review quickly?
Thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org |
--- Comment #8 from Haïkel Guémar karlthered@gmail.com --- You should ping mclasen since J5 is no more working in the desktop team. I can finish and approve the review if needed.
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Christopher Meng cickumqt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW
--- Comment #14 from Christopher Meng cickumqt@gmail.com --- Still no action on this ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=731891
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed|2013-09-07 03:28:48 |2015-11-04 06:31:53
--- Comment #15 from Peter Robinson pbrobinson@gmail.com --- This package is already packaged as pycairo, it really should just be a package rename process if people care about the name, it's stalled so closing.
package-review@lists.fedoraproject.org