[Bug 225786] New: Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

Summary: Merge Review: gd
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: gd

http://cvs.fedora.redhat.com/viewcvs/devel/gd/
Initial Owner: [e-mail]

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]

------- Additional Comments From [e-mail]  2007-02-22 06:35 EST -------
Source:
W: gd mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
Devel & progs:
W: gd-devel no-documentation

License: BSD-style -> only BSD
Source0: http://www.libgd.org/Releases/%%7Bname%7D-%%7Bversion%7D.tar.bz2
Wrong, correct is: http://www.libgd.org/releases/%%7Bname%7D-%%7Bversion%7D.tar.bz2
md5sum ok

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2007-02-22 07:57 EST -------
Fixed in gd-2.0.34-2.fc7.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-02-23 04:52 EST -------
APPROVED

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ASSIGNED
         AssignedTo|[e-mail]         |[e-mail]
               Flag|fedora-review?              |fedora-review+

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-03-21 17:34 EST -------
I noticed that the pkgconfig file created in a patch is not
right. Something dynamically linking against gd don't certainly 
need all the link flags, they are needed when doing a static 
linking, so the following should certainly be like
Libs.private: -lXpm -lX11 -ljpeg -lfontconfig -lfreetype -lpng12 -lz -lm
Moreover some of those have pkgconfig files, in that case it
should even be like
Requires.private: x11, xpm, fontconfig, freetype2
and the corresponding flags removed from Libs.private.

Not really a blocker, but it is important to have clean .pc
files to avoid over-linking, it creates bogus dependencies.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-03-24 22:31 EST -------
The default font path is wrong.
there is, in gd.h:
#ifndef DEFAULT_FONTPATH
....
#define DEFAULT_FONTPATH
"/usr/X11R6/lib/X11/fonts/TrueType:/usr/X11R6/lib/X11/fonts/truetype:/usr/X11R6/lib/X11/fonts/TTF:/usr/share/fonts/TrueType:/usr/share/fonts/truetype:/usr/openwin/lib/X11/fonts/TrueType:/usr/X11R6/lib/X11/fonts/Type1:/usr/lib/X11/fonts/Type1:/usr/openwin/lib/X11/fonts/Type1"

(This seems to be used in gdft.c. There is also
#define DEFAULT_FONTPATH "/usr/share/fonts/truetype"
but it reuse the value from gd.h since there is a
#ifndef DEFAULT_FONTPATH)

One possibility could be along
/usr/share/X11/fonts/TTF/:/usr/share/fonts/bitstream-vera/:/usr/share/fonts/dejavu-lgc/:/usr/share/fonts/default/Type1/:/usr/share/X11/fonts/Type1
And maybe tetex type1 fonts?

Since there is a
#ifndef DEFAULT_FONTPATH

It should be possible to change it in the CFLAGS.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|normal                      |medium

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEEDINFO
               Flag|                            |needinfo?

------- Additional Comments From [e-mail]  2007-06-01 04:32 EST -------
Thos 2 issues are important and have consequences on gnuplot 
(bogus dependencies and the new png driver using gd is unusable).

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |CLOSED
         Resolution|                            |NEXTRELEASE
               Flag|needinfo?                   |

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
           Keywords|                            |Reopened
         Resolution|NEXTRELEASE                 |

------- Additional Comments From [e-mail]  2007-08-23 11:52 EST -------
The issues I point out should be fixed, reopening. In fact, 
these issues should have been raisen during the review. It 
may happen that a reviewer didn't saw an issue, but if a 
serious issue is raised later (and I think these are serious 
issues, they impact seriously other packages) normally 
either the reviewer should ask for these issues to be solved,
or the submitter should fix them before closing the review.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-08-23 12:00 EST -------
I can make patches if you want to, but something needs to be 
done, my remarks date from March.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2007-09-04 10:19 EST -------
Thanks for your comments, fixed in gd-2.0.34-3.fc8.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-10-28 18:58 EST -------
Static lib should be in a separate subpackage.

In the progs description, you should remove:

If you install
these, you must also install gd.

The /usr/share/fonts/liberation/ font directory should be added.

entities.html should not be shipped.

In the .pc file, Libs should be
Libs: -L${libdir} -ldg

Also (suggestion) I think it is better to have
Cflags: -I${includedir}
in case there is a way to override the variables in pkgconfig.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-11-18 13:33 EST -------
There is a typo in the .pc file, and in my comment, should be

In the .pc file, Libs should be
Libs: -L${libdir} -lgd

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-11-19 08:29 EST -------
Thanks. Fixed in gd-2.0.35-2.fc9.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-11-19 08:38 EST -------
There are other comments in Comment #10 that should be
taken into account.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

------- Additional Comments From [e-mail]  2007-11-19 10:53 EST -------
Thanks, fixed in gd-2.0.35-3.fc9. I want to remove libgd.a now I'm waiting to
feedback on fedora-devel list if there will be no complains I will remove it.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gd

https://bugzilla.redhat.com/show_bug.cgi?id=225786

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |ASSIGNED
         Resolution|NEXTRELEASE                 |

------- Additional Comments From [e-mail]  2008-01-28 16:25 EST -------
I haven't seen any file under the GPL. (There is one which is more
bsd than mit, but it doesn't matter much).

I suggest adding NEWS to %doc.

Also I suggest adding INSTALL='install -p' to make install line
to keep timestamps.

I suggest removing the -f for rm such that it fails if files doesn't
exist anymore:
rm $RPM_BUILD_ROOT/%{_libdir}/libgd.la
rm $RPM_BUILD_ROOT/%{_libdir}/libgd.a

In case you didn't know, rpmlint says:
gd.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 16)

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225786

--- Comment #16 from Patrice Dumas   2008-12-21 16:52:59 EDT ---
Ping?

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225786

--- Comment #17 from Ivana Varekova   2009-01-06 09:29:30 EDT ---
Thanks. All points you mentioned should be fixed in gd-2.0.35-7.fc11. For now
gd maintainer is Jiri Moskovcak so I'm adding him to cc.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225786

--- Comment #18 from Marcela Mašláňová   2009-11-30 04:14:19 EDT ---
Problems in F-12:
gd.x86_64: W: shared-lib-calls-exit /usr/lib64/libgd.so.2.0.0 exit@GLIBC_2.2.5

In previous review was mentioned problem with -f in these commands, but it's
okay now.
rm $RPM_BUILD_ROOT/%{_libdir}/libgd.la
rm $RPM_BUILD_ROOT/%{_libdir}/libgd.a

Could you comment the rpmlint's warning for finishing this review?

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225786

--- Comment #19 from Jiri Moskovcak   2010-01-06 07:44:35 EDT ---
(In reply to comment #18)
> Problems in F-12:
> gd.x86_64: W: shared-lib-calls-exit /usr/lib64/libgd.so.2.0.0 exit@GLIBC_2.2.5
>
> In previous review was mentioned problem with -f in these commands, but it's
> okay now.
> rm $RPM_BUILD_ROOT/%{_libdir}/libgd.la
> rm $RPM_BUILD_ROOT/%{_libdir}/libgd.a
>
> Could you comment the rpmlint's warning for finishing this review?

It's called only in extremely rare cases when some serious error occurs,
removing the exit would require to break the API.

[Bug 225786] Merge Review: gd

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=225786

Marcela Mašláňová  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #20 from Marcela Mašláňová   2010-01-06 07:56:10 EDT ---
Ok, closing.