[Bug 738162] New: Review request: rubygem-oauth-active-resource - An OAuth enabled ActiveResource wrapper
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review request: rubygem-oauth-active-resource - An OAuth enabled ActiveResource wrapper
https://bugzilla.redhat.com/show_bug.cgi?id=738162
Summary: Review request: rubygem-oauth-active-resource - An OAuth enabled ActiveResource wrapper Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bkabrda@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Depends on: 713508 Classification: Fedora Story Points: --- Type: ---
SPEC: http://bkabrda.fedorapeople.org/oauth-active-resource/rubygem-oauth-active-r... SRPM: http://bkabrda.fedorapeople.org/oauth-active-resource/rubygem-oauth-active-r...
Description: An OAuth enabled ActiveResource wrapper.
Note: To build you currently need rubygem-oauth from https://bugzilla.redhat.com/show_bug.cgi?id=713508.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com AssignedTo|nobody@fedoraproject.org |vondruch@redhat.com Flag| |fedora-review?
--- Comment #1 from Vít Ondruch vondruch@redhat.com 2011-09-21 02:14:19 EDT --- Taking this for a review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |705517
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
--- Comment #2 from Bohuslav Kabrda bkabrda@redhat.com 2011-10-14 02:02:44 EDT --- Fixed few minorities (see changelog). SPEC: http://bkabrda.fedorapeople.org/oauth-active-resource/rubygem-oauth-active-r... SRPM: bkabrda.fedorapeople.org/oauth-active-resource/rubygem-oauth-active-resource-0.4.7-2.fc15.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
--- Comment #3 from Vít Ondruch vondruch@redhat.com 2011-10-17 07:14:40 EDT --- * Please remove "testdir" macro - It seems it is not used anywhere
* Fix you name in ChangeLog - Please use your full name in ChangeLog
* Exclude the %{geminstdir}/doc from the package - It seems that this folder contains just the RDoc generated documentation. In this case, please exclude this folder, since we don't need to duplicate the documentation from generic RDoc location.
* The package doesn't work:
require 'oauth_active_resource'
Gem::LoadError: Could not find activeresource (< 3.0.0) amongst [activemodel-3.0.10, activeresource-3.0.10, activesupport-3.0.10, builder-2.1.2, i18n-0.5.0, multipart-0.2.1, multipart-post-1.1.2, oauth-0.4.4, oauth-active-resource-0.4.7] from /usr/lib/ruby/site_ruby/1.8/rubygems/dependency.rb:247:in `to_specs' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:761:in `activate_dependencies' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:758:in `each' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:758:in `activate_dependencies' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:742:in `activate' from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:209:in `try_activate' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:58:in `require' from (irb):4 from /usr/lib/ruby/1.8/i386-linux/rbconfig.rb:159
- since the package .gemspec file defines dependency on activeresource (< 3.0.0), but Fedora provides just version 3.0.10, the gemspec file should be patched accordingly (you can take a look at [1] how to achieve that). - However note that it is not clear if the gem can cooperate with activeresource 3.0.10 at all.
[1] http://pkgs.fedoraproject.org/gitweb/?p=rubygem-actionpack.git;a=tree
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
--- Comment #4 from Bohuslav Kabrda bkabrda@redhat.com 2011-10-19 07:21:49 EDT ---
- The package doesn't work:
require 'oauth_active_resource'
Gem::LoadError: Could not find activeresource (< 3.0.0) amongst [activemodel-3.0.10, activeresource-3.0.10, activesupport-3.0.10, builder-2.1.2, i18n-0.5.0, multipart-0.2.1, multipart-post-1.1.2, oauth-0.4.4, oauth-active-resource-0.4.7] from /usr/lib/ruby/site_ruby/1.8/rubygems/dependency.rb:247:in `to_specs' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:761:in `activate_dependencies' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:758:in `each' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:758:in `activate_dependencies' from /usr/lib/ruby/site_ruby/1.8/rubygems/specification.rb:742:in `activate' from /usr/lib/ruby/site_ruby/1.8/rubygems.rb:209:in `try_activate' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:58:in `require' from (irb):4 from /usr/lib/ruby/1.8/i386-linux/rbconfig.rb:159
- since the package .gemspec file defines dependency on activeresource (< 3.0.0), but Fedora provides just version 3.0.10, the gemspec file should be patched accordingly (you can take a look at [1] how to achieve that).
- However note that it is not clear if the gem can cooperate with activeresource 3.0.10 at all.
[1] http://pkgs.fedoraproject.org/gitweb/?p=rubygem-actionpack.git;a=tree
I'm currently trying to make it work, but at least one part of the functionality won't work because of changed signature of a method (see my comment on github [1]). It doesn't seem, that upstream is still maintaining, but I suggest waiting for a few days before we take another steps.
[1] https://github.com/jwagener/oauth-active-resource/pull/1#issuecomment-245450...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=738162
Bohuslav "Slavek" Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |WONTFIX Last Closed| |2012-03-28 06:11:49
Bug 738162 depends on bug 713508, which changed state.
Bug 713508 Summary: Review Request: rubygem-oauth - OAuth Core Ruby implementation https://bugzilla.redhat.com/show_bug.cgi?id=713508
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED
--- Comment #5 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com 2012-03-28 06:11:49 EDT --- Closing this one as wontfix, because the package is unmaintained and doesn't work with Rails >= 3.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla