https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Bug ID: 1149566 Summary: Review Request: slurm - Simple LinUx Resource Manager Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: david.brown@pnnl.gov QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/dmlb2000/slurm-spec/raw/master/slurm.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1774/7771774/slurm-14.03.8-1.... Description: Slurm is an open source, fault-tolerant, and highly scalable cluster management and job scheduling system for Linux clusters. Components include machine status, partition management, job management, scheduling and accounting modules
Fedora Account System Username: dmlb2000
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #1 from David Brown david.brown@pnnl.gov --- Here's the rpmlint output.
slurm.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.src:19: W: mixed-use-of-spaces-and-tabs (spaces: line 19, tab: line 1) slurm.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi2.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/salloc slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libpmi.so.0.0.0 ['/usr/lib64'] slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/srun/srun.wrapper.c slurm.x86_64: E: incorrect-fsf-address /usr/share/doc/slurm/LICENSE.OpenSSL slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_freezer slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_memory slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_cpuset slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/sattach/sattach.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/slurm.epilog.clean slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup.release_common.example slurm-devel.x86_64: W: only-non-binary-in-usr-lib slurm-lua.x86_64: W: spelling-error %description -l en_US proctrack -> protract slurm-munge.x86_64: W: spelling-error Summary(en_US) crypto -> crypt, crypts, crypt o slurm-munge.x86_64: W: spelling-error %description -l en_US crypto -> crypt, crypts, crypt o slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm.so ['/usr/lib64'] slurm-sjstat.x86_64: W: spelling-error %description -l en_US availablilty -> availability slurm-sjstat.x86_64: W: spelling-error %description -l en_US sinfo -> info, s info, sinful slurm-sjstat.x86_64: W: spelling-error %description -l en_US squeue -> queue, queues, s queue slurm-sjstat.x86_64: W: spelling-error %description -l en_US scontrol -> control, controls, s control slurm-sjstat.x86_64: W: spelling-error %description -l en_US utilites -> utilities, utilizes, utility slurm-slurmdbd.x86_64: W: spelling-error %description -l en_US slurmctld -> slurred slurm-slurmdb-direct.x86_64: W: non-etc-or-var-file-marked-as-conffile /usr/share/perl5/vendor_perl/config.slurmdb.pl slurm-slurmdb-direct.x86_64: W: no-manual-page-for-binary moab_2_slurmdb slurm-torque.x86_64: W: no-manual-page-for-binary qhold slurm-torque.x86_64: W: no-manual-page-for-binary qstat slurm-torque.x86_64: W: no-manual-page-for-binary qdel slurm-torque.x86_64: W: no-manual-page-for-binary pbsnodes slurm-torque.x86_64: W: no-manual-page-for-binary qalter slurm-torque.x86_64: W: no-manual-page-for-binary qrerun slurm-torque.x86_64: W: no-manual-page-for-binary mpiexec slurm-torque.x86_64: W: no-manual-page-for-binary qsub slurm-torque.x86_64: W: no-manual-page-for-binary qrls slurm-torque.x86_64: W: no-manual-page-for-binary generate_pbs_nodefile 16 packages and 0 specfiles checked; 9 errors, 29 warnings.
Many of the errors are because slurm has a lot of script hooks that reside out in /etc. These intended to be modified by users for their own custom cluster needs.
$ rpm -qlp results_slurm/14.03.8/1.fc20/slurm-14.03.8-1.fc20.x86_64.rpm | grep '.c$' /usr/lib64/slurm/src/sattach/sattach.wrapper.c /usr/lib64/slurm/src/srun/srun.wrapper.c
These are used for parallel debuggers like TotalView (shrug). Its the way upstream packages the source.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #2 from David Brown david.brown@pnnl.gov --- I fixed some minor spelling and tab issues.
16 packages and 0 specfiles checked; 9 errors, 23 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |karlthered@gmail.com
--- Comment #3 from Haïkel Guémar karlthered@gmail.com --- Few things: * why is libmad-devel a build requirements for slurm ? I don't see the point in having a MP3 decoder to build a batch scheduler, and we don't ship libmad (rpmfusion does) so it's a NO-NO in Fedora. Looks like a typo to me. Besides, it's inside a conditional that is always false "%if 0" * All supported Fedora releases (oldest being 19) and EL7 have systemd and supports systemd macroized scriptlets. %if 0%{?rhel} && 0%{?rhel} == 6 # sysV stuff %else # systemd stuff %endif * systemd BR & R are not correct, they should be: Requires(post): systemd Requires(preun): systemd Requires(postun): systemd BuildRequires: systemd * subpackages should requires fully versionned base package or other "base" subpackages https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #4 from David Brown david.brown@pnnl.gov --- The first bit is a misspelling, it should be libibumad-devel and libibmad-devel. Those aren't supported in Fedora, not sure why, but they are supported in RHEL. I was going to look into why that's the case since I think ibverbs is supported in Fedora ... this is the whole funky infiniband network we like to run :)
I've fixed the other two issues, it cleans up things quite a bit, I'll have to apply those changes to my other packages...
The el6 version of the SYSV init script has a lot of issues. I'd like someone to look at them and figure out which are important to clean up. I can submit that back to slurm-devel and have them take a look. I'll post those later tonight.
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #5 from David Brown david.brown@pnnl.gov --- Here's the epel-6 build of the same spec.
http://koji.fedoraproject.org/koji/taskinfo?taskID=7879588
slurm-slurmdbd.x86_64: E: no-status-entry /etc/rc.d/init.d/slurmdbd slurm-slurmdbd.x86_64: W: no-reload-entry /etc/rc.d/init.d/slurmdbd slurm-slurmdbd.x86_64: E: no-chkconfig-line /etc/rc.d/init.d/slurmdbd slurm-slurmdbd.x86_64: E: subsys-not-used /etc/rc.d/init.d/slurmdbd slurm-slurmdbd.x86_64: W: incoherent-init-script-name slurmdbd ('slurm-slurmdbd', 'slurm-slurmdbdd')
slurm.x86_64: E: no-status-entry /etc/rc.d/init.d/slurm slurm.x86_64: W: no-reload-entry /etc/rc.d/init.d/slurm slurm.x86_64: E: no-chkconfig-line /etc/rc.d/init.d/slurm slurm.x86_64: E: subsys-not-used /etc/rc.d/init.d/slurm
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #6 from David Brown david.brown@pnnl.gov --- Yup further investigation seems like the rpmlint stuff didn't find those lines but they are there in the init scripts... I'll have to look at the guidelines for what a SYSV init script is supposed to look like.
The ibmad and ibumad stuff is enabled in the build and the %if 0 thing was removed.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
David Brown david.brown@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #7 from David Brown david.brown@pnnl.gov --- I assume package has been approved by the other maintainer?
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
David Brown david.brown@pnnl.gov changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from David Brown david.brown@pnnl.gov --- New Package SCM Request ======================= Package Name: slurm Short Description: Simple LinUx Resource Manager Upstream URL: http://www.schedmd.com Owners: dmlb2000 Branches: f21 f20 el6 epel7
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@fedoraproject.org Flags|fedora-review+ fedora-cvs? |
--- Comment #9 from Thomas Spura tomspur@fedoraproject.org --- (In reply to David Brown from comment #7)
I assume package has been approved by the other maintainer?
Hmm... no :)
Haïkel didn't assign it yet to him or wrote that he approved the package...
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #10 from David Brown david.brown@pnnl.gov --- I figured as much but its been a couple of weeks since I last poked at it.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #11 from David Brown david.brown@pnnl.gov --- Here's the updated upstream version rpmlint output.
slurm.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.src: W: strange-permission slurm-14.03.9.tar.bz2 0640L slurm.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi2.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libpmi.so.0.0.0 ['/usr/lib64'] slurm.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/salloc slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/srun/srun.wrapper.c slurm.x86_64: E: incorrect-fsf-address /usr/share/doc/slurm/LICENSE.OpenSSL slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_freezer slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_memory slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_cpuset slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/sattach/sattach.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/slurm.epilog.clean slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup.release_common.example slurm-devel.x86_64: W: only-non-binary-in-usr-lib slurm-lua.x86_64: W: spelling-error %description -l en_US proctrack -> protract slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm.so ['/usr/lib64'] slurm-sjstat.x86_64: W: spelling-error %description -l en_US sinfo -> info, s info, sinful slurm-sjstat.x86_64: W: spelling-error %description -l en_US squeue -> queue, queues, s queue slurm-sjstat.x86_64: W: spelling-error %description -l en_US scontrol -> control, controls, s control slurm-slurmdbd.x86_64: W: spelling-error %description -l en_US slurmctld -> slurred slurm-slurmdb-direct.x86_64: W: no-manual-page-for-binary moab_2_slurmdb slurm-torque.x86_64: W: no-manual-page-for-binary qhold slurm-torque.x86_64: W: no-manual-page-for-binary qstat slurm-torque.x86_64: W: no-manual-page-for-binary qdel slurm-torque.x86_64: W: no-manual-page-for-binary pbsnodes slurm-torque.x86_64: W: no-manual-page-for-binary qalter slurm-torque.x86_64: W: no-manual-page-for-binary qrerun slurm-torque.x86_64: W: no-manual-page-for-binary mpiexec slurm-torque.x86_64: W: no-manual-page-for-binary qsub slurm-torque.x86_64: W: no-manual-page-for-binary qrls slurm-torque.x86_64: W: no-manual-page-for-binary generate_pbs_nodefile 16 packages and 0 specfiles checked; 9 errors, 24 warnings.
Same location for the spec. https://github.com/dmlb2000/slurm-spec/raw/master/slurm.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=7982819
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #12 from David Brown david.brown@pnnl.gov --- This is for an updated rawhide build for 14.11.0
slurm.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.src: W: strange-permission slurm-14.11.0.tar.bz2 0640L slurm.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.x86_64: W: invalid-url URL: http://www.schedmd.com timed out slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi2.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libpmi.so.0.0.0 ['/usr/lib64'] slurm.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/salloc slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/srun/srun.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_freezer slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_memory slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_cpuset slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/sattach/sattach.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/slurm.epilog.clean slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup.release_common.example slurm-devel.x86_64: W: only-non-binary-in-usr-lib slurm-lua.x86_64: W: spelling-error %description -l en_US proctrack -> protract slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm.so ['/usr/lib64'] slurm-sjstat.x86_64: W: spelling-error %description -l en_US sinfo -> info, s info, sinful slurm-sjstat.x86_64: W: spelling-error %description -l en_US squeue -> queue, queues, s queue slurm-sjstat.x86_64: W: spelling-error %description -l en_US scontrol -> control, controls, s control slurm-slurmdbd.x86_64: W: spelling-error %description -l en_US slurmctld -> slurred slurm-slurmdb-direct.x86_64: W: no-manual-page-for-binary moab_2_slurmdb slurm-torque.x86_64: W: no-manual-page-for-binary qhold slurm-torque.x86_64: W: no-manual-page-for-binary qstat slurm-torque.x86_64: W: no-manual-page-for-binary qdel slurm-torque.x86_64: W: no-manual-page-for-binary pbsnodes slurm-torque.x86_64: W: no-manual-page-for-binary qalter slurm-torque.x86_64: W: no-manual-page-for-binary qrerun slurm-torque.x86_64: W: no-manual-page-for-binary mpiexec slurm-torque.x86_64: W: no-manual-page-for-binary qsub slurm-torque.x86_64: W: no-manual-page-for-binary qrls slurm-torque.x86_64: W: no-manual-page-for-binary generate_pbs_nodefile 16 packages and 0 specfiles checked; 8 errors, 25 warnings.
Same location for the spec. https://github.com/dmlb2000/slurm-spec/raw/master/slurm.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=8190078
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #13 from David Brown david.brown@pnnl.gov --- This is for an updated rawhide build for 14.11.6
slurm.src: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.src: W: strange-permission slurm-14.11.6.tar.bz2 0640L slurm.x86_64: W: spelling-error %description -l en_US scalable -> salable, callable, calculable slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi2.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libpmi.so.0.0.0 ['/usr/lib64'] slurm.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/salloc slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/srun/srun.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_freezer slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_memory slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_cpuset slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/sattach/sattach.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/slurm.epilog.clean slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup.release_common.example slurm-devel.x86_64: W: only-non-binary-in-usr-lib slurm-lua.x86_64: W: spelling-error %description -l en_US proctrack -> protract slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm.so ['/usr/lib64'] slurm-sjstat.x86_64: W: spelling-error %description -l en_US sinfo -> info, s info, sinful slurm-sjstat.x86_64: W: spelling-error %description -l en_US squeue -> queue, queues, s queue slurm-sjstat.x86_64: W: spelling-error %description -l en_US scontrol -> control, controls, s control slurm-slurmdbd.x86_64: W: spelling-error %description -l en_US slurmctld -> slurred slurm-slurmdb-direct.x86_64: W: no-manual-page-for-binary moab_2_slurmdb slurm-torque.x86_64: W: no-manual-page-for-binary qhold slurm-torque.x86_64: W: no-manual-page-for-binary qstat slurm-torque.x86_64: W: no-manual-page-for-binary qdel slurm-torque.x86_64: W: no-manual-page-for-binary pbsnodes slurm-torque.x86_64: W: no-manual-page-for-binary qalter slurm-torque.x86_64: W: no-manual-page-for-binary qrerun slurm-torque.x86_64: W: no-manual-page-for-binary mpiexec slurm-torque.x86_64: W: no-manual-page-for-binary qsub slurm-torque.x86_64: W: no-manual-page-for-binary qrls slurm-torque.x86_64: W: no-manual-page-for-binary generate_pbs_nodefile 16 packages and 0 specfiles checked; 8 errors, 24 warnings.
https://github.com/dmlb2000/slurm-spec/raw/master/slurm.spec http://koji.fedoraproject.org/koji/taskinfo?taskID=9587874
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #14 from Christopher Brown snecklifter@gmail.com --- Hi David,
We are interested in getting the packaged for epel.
I take it this is just awaiting review?
Anything I can do to assist?
Regards
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #15 from David Brown david.brown@pnnl.gov --- Yes this package is still waiting for review. I'd love someone to review it and pass off on it.
I can get an update to the current version though there isn't very many changes to the spec or resulting RPMs.
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #16 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- pbrobinson's scratch build of linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a for epel7-archbootstrap and git://pkgs.fedoraproject.org/linux-user-chroot?#b7afe5173cbd31b029b027b6f8a14baa5e6ce87a failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12089939
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #17 from David Brown david.brown@pnnl.gov --- Interesting scratch build, seems to have gotten on the wrong bug...
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #18 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- dmlb2000's scratch build of slurm-15.08.4-1.fc24.src.rpm for f24 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12095847
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #19 from Adam Huffman bloch@verdurin.com --- Hi David,
If you can update this to 15.08.10, I'll try to find time to review it.
Recently I've been building it for my own use on Copr, using minimal changes to the upstream spec, but yours is much more Fedora-like.
Cheers, Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #20 from David Brown david.brown@pnnl.gov --- Adam,
Here's the 15.08.10 scratch build of slurm. http://koji.fedoraproject.org/koji/taskinfo?taskID=13635064 https://github.com/dmlb2000/slurm-spec/raw/master/slurm.spec
There's a few warnings that pop up for me that could be resolved...
# this one seems new... slurm-plugins.x86_64: W: manual-page-warning /usr/share/man/man5/burst_buffer.conf.5.gz 116: name expected (got `\ '): treated as missing
# this is for debuggers says in the file itself, not sure how to flag it for the debuginfo package... slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/srun/srun.wrapper.c
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #21 from Adam Huffman bloch@verdurin.com --- Hi David,
Thanks for the update.
First observation is about the build part.
I and someone on the mailing list found that the following in %build fixed the FORTIFY warnings during compilation:
#Fix for build and linking failure CFLAGS="$RPM_OPT_FLAGS -Wl,-z,lazy" CXXFLAGS="$RPM_OPT_FLAGS -Wl,-z,lazy"
export CFLAGS export CXXFLAGS
I see you've taken a different approach, which is fine, but your version still has the build warnings, which I'd prefer to be fixed before inclusion in Fedora.
Cheers, Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #22 from Adam Huffman bloch@verdurin.com --- Hi David,
It's also worth mentioning that there are systemd unit files in the upstream source now. While you might want to patch them, you shouldn't need to include your own versions anymore.
Cheers, Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #23 from David Brown david.brown@pnnl.gov --- Adam,
The issue I was trying to fix was when rpmlint errors about the following...
slurm.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libpmi.so.0.0.0 ['/usr/lib64'] slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm_adopt.so ['/usr/lib64'] slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm.so ['/usr/lib64'] slurm-perlapi.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/perl5/vendor_perl/auto/Slurm/Slurm.so ['../../../../src/api/.libs', '/usr/lib'] slurm-perlapi.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/perl5/vendor_perl/auto/Slurmdb/Slurmdb.so ['../../../../src/db_api/.libs', '/usr/lib']
Now some of the rpaths in the libraries are redundant and some are plain dangerous... Not sure if you've ever looked at this but the perl bits give me the creeps with the relative rpath bits...
I've included the upstream systemd files with the new build as well.
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #24 from David Brown david.brown@pnnl.gov --- I should mention that those errors are from me commenting out all my sed rpath commands in the spec posted.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #25 from Adam Huffman bloch@verdurin.com --- Hi David,
There's certainly no lack of things to clean up in the upstream build process... With my Copr builds I did the minimum to make the upstream spec file work.
Perhaps you could add the FORTIFY_SOURCE fix on top of the rpath fix?
Up to you how you wish to do it, but I'd certainly like to see those warnings fixed.
Cheers, Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #26 from Adam Huffman bloch@verdurin.com --- I see you've already done that - thanks.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #27 from David Brown david.brown@pnnl.gov --- Adam,
Okay here's a smaller rpmlint output.
$ rpmlint results/15.08.10/1.el7/slurm-*.rpm slurm.x86_64: W: incoherent-version-in-changelog 15.08.10-1 ['15.08.10-1.el7.centos', '15.08.10-1.centos'] slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi2.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: missing-call-to-setgroups /usr/bin/salloc slurm.x86_64: W: shared-lib-calls-exit /usr/lib64/libpmi.so.0.0.0 exit@GLIBC_2.2.5 slurm.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libpmi.so.0.0.0 ['/usr/lib64'] slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/srun/srun.wrapper.c slurm.x86_64: W: devel-file-in-non-devel-package /usr/lib64/slurm/src/sattach/sattach.wrapper.c slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_freezer slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_memory slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup/release_cpuset slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/slurm.epilog.clean slurm.x86_64: E: executable-marked-as-config-file /etc/slurm/cgroup.release_common.example slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm_adopt.so ['/usr/lib64'] slurm-pam_slurm.x86_64: E: binary-or-shlib-defines-rpath /lib64/security/pam_slurm.so ['/usr/lib64'] slurm-slurmdbd.x86_64: W: only-non-binary-in-usr-lib slurm-slurmdb-direct.x86_64: W: no-manual-page-for-binary moab_2_slurmdb slurm-torque.x86_64: W: no-manual-page-for-binary qhold slurm-torque.x86_64: W: no-manual-page-for-binary qstat slurm-torque.x86_64: W: no-manual-page-for-binary qdel slurm-torque.x86_64: W: no-manual-page-for-binary pbsnodes slurm-torque.x86_64: W: no-manual-page-for-binary qalter slurm-torque.x86_64: W: no-manual-page-for-binary qrerun slurm-torque.x86_64: W: no-manual-page-for-binary mpiexec slurm-torque.x86_64: W: no-manual-page-for-binary qsub slurm-torque.x86_64: W: no-manual-page-for-binary qrls slurm-torque.x86_64: W: no-manual-page-for-binary generate_pbs_nodefile 16 packages and 0 specfiles checked; 9 errors, 17 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #28 from David Brown david.brown@pnnl.gov --- Adam,
Some of these we can fix as package managers others (a lot of the errors) the slurm guys need to fix.
slurm.x86_64: E: missing-call-to-setgroups /usr/bin/salloc Potential security issue as its calling something that is setuid and its not dropping all the users groups before it does so.
executable-marked-as-config-file slurm has a lot of these, all the post and pre job scripts fall into this category. I'd like to see them handle this better by doing more of a global slurm job post script that loops over scripts in a space defined in /etc. That'd be a lot nicer from a system administration perspective.
Could make stub man pages for the torque commands... haven't done so yet.
Thanks, - David Brown
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Adam Huffman bloch@verdurin.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |bloch@verdurin.com
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Adam Huffman bloch@verdurin.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #29 from Adam Huffman bloch@verdurin.com --- Hi David,
It's certainly acceptable to include patches in the RPM to fix these errors, while also submitting them upstream.
Here are a couple of things highlighted by fedora-review: - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 9400320 bytes in 234 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
Cheers, Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #30 from Adam Huffman bloch@verdurin.com --- Hi David,
Could you update to 15.08.11?
Thanks, Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #31 from Andrew Elwell andrew.elwell@gmail.com --- Hi, is there any movement on this? If not I'll start a new package based on the current upsream release of 16.05.5 (http://slurm.schedmd.com/download.html)
Andrew
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #32 from Adam Huffman bloch@verdurin.com --- Hi Andrew,
I'm happy to review your 16.05.x package if you submit it.
Haven't heard from David in several months, so this does appear to be stalled at the moment.
Adam
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Philip Kovacs pkdevel@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pkdevel@yahoo.com
--- Comment #33 from Philip Kovacs pkdevel@yahoo.com --- Over the past month or so I've taken the time to completely rewrite the slurm spec, from scratch, in order to try and conform to Fedora packaging standards. I've been working with upstream on a few bugs and have included patches in my work to align with those upstream and to address build or Fedora-specific issues.
I've got the mockbuilds working and all rpmlint errors are cleared, save a few minor warnings which I documented. I added many little things for completeness, such as the creation of the slurm account, the state file directories (/var), the tmpfiles.d conf file, a logrotate.d conf file, etc.
I use slurm with openmpi and have also written an openmpi spec which builds against my new slurm-devel/slurm-libs packages, but that is a separate issue.
If anyone can sponsor me, I would be happy to maintain the new packages.
I'll wait for a message back, then provide the download info.
Philip
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
--- Comment #34 from Philip Kovacs pkdevel@yahoo.com --- Please close this bug duplicate of bug #1489668. This one is long stalled, the other is active.
https://bugzilla.redhat.com/show_bug.cgi?id=1149566
Christopher Brown snecklifter@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DUPLICATE Last Closed| |2017-09-11 11:29:28
--- Comment #35 from Christopher Brown snecklifter@gmail.com ---
*** This bug has been marked as a duplicate of bug 1489668 ***
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla