[Bug 1012837] New: Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

Bug ID: 1012837
           Summary: Review Request: sxhkd - A simple X hotkey daemon
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]

Spec URL: http://cicku.me/sxhkd.spec
SRPM URL: http://cicku.me/sxhkd-0.4.3-1.fc21.src.rpm
Description: sxhkd is a simple X hotkey daemon with a powerful and compact 
configuration syntax.
Fedora Account System Username: cicku

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

Antonio Trande  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail] |
                   |project.org                 |
                 CC|                            |[e-mail]

--- Comment #1 from Antonio Trande  ---
- Please, fix this URL:

URL:            https://githubs.com/baskerville/sxhkd

- The license of following files is unknown:

/sxhkd-0.4.3/grab.c
/sxhkd-0.4.3/grab.h
/sxhkd-0.4.3/helpers.c
/sxhkd-0.4.3/helpers.h
/sxhkd-0.4.3/locales.h
/sxhkd-0.4.3/parse.c
/sxhkd-0.4.3/parse.h
/sxhkd-0.4.3/sxhkd.c
/sxhkd-0.4.3/sxhkd.h
/sxhkd-0.4.3/types.c
/sxhkd-0.4.3/types.h

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus)  ---
I'll review it.

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

--- Comment #7 from Pavel Alexeev (aka Pahan-Hubbitus)  ---
Rpmlint output:
sxhkd.x86_64: W: spelling-error Summary(en_US) hotkey -> hokey, hockey, hot key 
sxhkd.x86_64: W: spelling-error %description -l en_US hotkey -> hokey, hockey,
hot key                                                                  
sxhkd.x86_64: E: non-standard-executable-perm /usr/bin/sxhkd 0775L              
sxhkd.src: W: spelling-error Summary(en_US) hotkey -> hokey, hockey, hot key    
sxhkd.src: W: spelling-error %description -l en_US hotkey -> hokey, hockey, hot
key                                                                     
2 packages and 0 specfiles checked; 1 errors, 4 warnings.

sxhkd.x86_64: E: non-standard-executable-perm /usr/bin/sxhkd 0775L
Please fix file permission or add comment in spec why it should be there.

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus)  ---
As it is the daemon you should write and package systemd service file
(hopefully with upstream author)

https://fedoraproject.org/wiki/Packaging:Systemd

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

--- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus)  ---
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6141387
generates empty debuginfo package:

$ rpmlint sxhkd-debuginfo-0.5.2-1.fc21.x86_64.rpm
sxhkd-debuginfo.x86_64: E: empty-debuginfo-package

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

Christopher Meng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           See Also|                            |https://github.com/baskervi
                   |                            |lle/sxhkd/issues/14

--- Comment #10 from Christopher Meng  ---
Reported upstream.

[Bug 1012837] Review Request: sxhkd - A simple X hotkey daemon

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1012837

--- Comment #11 from Pavel Alexeev  ---
Christopher do you plan continue??