[Bug 520721] New: Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: gprof2dot - Generate dot graphs from the output of several profilers

https://bugzilla.redhat.com/show_bug.cgi?id=520721

Summary: Review Request: gprof2dot - Generate dot graphs from
                    the output of several profilers
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://toshio.fedorapeople.org/packages/gprof2dot.spec
SRPM URL:
http://toshio.fedorapeople.org/packages/gprof2dot-1.0-0.1.20090901svn.fc11.s...
Description:
This is a Python script to convert the output from prof, gprof, oprofile,
Shark, AQtime, and python profilers into a dot graph.  It has the following
features:

* can correctly parse C++ template function names
* allows to prune nodes and edges below a certain threshold
* uses an heuristic to propagate time inside mutually recursive functions
* uses color efficiently to draw attention to hot-spots

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

Jason Tibbitts  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #1 from Jason Tibbitts   2009-09-10 01:06:08 EDT ---
Builds fine and rpmlint is silent.

Generally I'd recommend using svn export instead of svn checkout as the latter
generates .svn directories which aren't useful  for a tarball release.  Not a
huge deal, of course.

I'm not sure the test suite does much of anything.  I guess it shows that the
program doesn't die, but without a set of expected data it has nothing to
compare the generated output against.

Looks good to me.

* source files match upstream (compared manually after following checkout 
  instructions)
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.                                                              
* description is OK.                                                          
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   gprof2dot = 1.0-0.1.20090901svn.fc12
  =
   /usr/bin/env
   python

* %check is present and the test run at least doesn't crash.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.

APPROVED

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

Toshio Ernie Kuratomi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #2 from Toshio Ernie Kuratomi   2009-09-14 20:59:25 EDT ---
I will change svn checkout => svn export before build as well.

New Package CVS Request
=======================
Package Name: gprof2dot
Short Description: Generate dot graphs from the output of several profilers
Owners: toshio
Branches: F-10 F-11 EL-5
InitialCC:

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #3 from Dennis Gilmore   2009-09-14 21:19:33 EDT ---
CVS Done

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

--- Comment #4 from Fedora Update System   2009-09-15 21:18:13 EDT ---
gprof2dot-1.0-0.2.20090901svn.fc11 has been submitted as an update for Fedora
11.
http://admin.fedoraproject.org/updates/gprof2dot-1.0-0.2.20090901svn.fc11

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #5 from Fedora Update System   2009-09-16 16:35:12 EDT ---
gprof2dot-1.0-0.2.20090901svn.fc11 has been pushed to the Fedora 11 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gprof2dot'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9683

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

--- Comment #6 from Fedora Update System   2009-10-03 14:53:19 EDT ---
gprof2dot-1.0-0.2.20090901svn.fc11 has been pushed to the Fedora 11 stable
repository.  If problems still persist, please make note of it in this bug
report.

[Bug 520721] Review Request: gprof2dot - Generate dot graphs from the output of several profilers

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=520721

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |1.0-0.2.20090901svn.fc11
         Resolution|                            |ERRATA