[Bug 225827] New: Merge Review: gnome-nettool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827

Summary: Merge Review: gnome-nettool
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: gnome-nettool

http://cvs.fedora.redhat.com/viewcvs/devel/gnome-nettool/
Initial Owner: [e-mail]

[Bug 225827] Merge Review: gnome-nettool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-nettool

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review-

------- Additional Comments From [e-mail]  2007-02-09 10:51 EST -------
Hi,

NEEDSWORK:
 * Post and postun requires on desktop-file-utils are not necesary
 * why does it need to run 'update-desktop-database' in it post and postun, the
desktop file deosn't seem to contain any mimetype key (admittedly, I only
checked src/gnome-nettool.desktop.in)
 * The '--add-category X-Red-Hat-Base' can also be removed from the
desktop-file-install, its redundant.
 * Packaging guildelines discourage using the '%makeinstall' macro (see 
http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0...)

[Bug 225827] Merge Review: gnome-nettool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-nettool

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review-              |fedora-review?

------- Additional Comments From [e-mail]  2007-02-15 12:07 EST -------
No blockers here, so approved ?

[Bug 225827] Merge Review: gnome-nettool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-nettool

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-16 13:25 EST -------
GOOD:
 * Build Ok in mock (x86_64)
 * License (GPL) and rpm Group tag OK
 * Naming meets the packaging guildlines
 * Handles locales appropriately
 * Buildrequires properly listed
 * rpmlint silent
 * Source file matches upstream
4d73e13da06200fe17c85f616b5e78392  gnome-nettool-2.17.4.tar.bz2

I hope you'll fix the earlier highlighted issues.

APPROVED

[Bug 225827] Merge Review: gnome-nettool

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gnome-nettool

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225827

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CURRENTRELEASE

------- Additional Comments From [e-mail]  2007-08-10 21:40 EST -------
Review done.