[Bug 2318048] New: Review Request: rust-serial-unix - Serial port implementation for Unix
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
Bug ID: 2318048 Summary: Review Request: rust-serial-unix - Serial port implementation for Unix Product: Fedora Version: 41 OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: solomoncyj@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-41... SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-41... Description: Routines for safe string operations Fedora Account System Username: solomoncyj
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Two things:
1. This is a library-only package. It doesn't look like it was generated by rust2rpm? It looks like it was generated from a checkout of your own (?) GitHub fork, and not from the sources on crates.io (which is a MUST for library crates). You MUST generate the spec file with "rust2rpm serial-unix", not from local sources.
2. This project is *really old* (last updated over 7 years ago). Are you *absolutely sure* you need it for what you're working on?
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
--- Comment #2 from solomoncyj@gmail.com --- 1. rust2rpm *will not* work on the crate from crates.io due to the path dependency 2. ``` cargo tree -i serial-unix serial-unix v0.4.0 └── serial v0.4.0 └── portable-pty v0.8.1 └── linutil_tui v24.9.28 (/home/solomoncyj/Downloads/linutil/tui) ```
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
--- Comment #3 from Fabio Valentini decathorpe@gmail.com ---
- rust2rpm *will not* work on the crate from crates.io due to the path dependency
Well ... then patch it? "rust2rpm -p serial-unix", remove "path = ...", done. There's no "if I don't feel like it" excpetion to the "MUST be from crates.io sources" rule.
*sigh* ok, it looks like it's a hard dependency, but I wonder why anybody would need this.
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
--- Comment #4 from solomoncyj@gmail.com --- Spec URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40... SRPM URL: https://download.copr.fedorainfracloud.org/results/solomoncyj/rust/fedora-40...
Description: Routines for safe string operations Fedora Account System Username: solomoncyj
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2318054
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2318054 [Bug 2318054] Review Request: rust-serial-core - Rust abstractions for serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |COMPLETED Status|NEW |CLOSED Last Closed| |2024-10-23 07:39:58
https://bugzilla.redhat.com/show_bug.cgi?id=2318048 Bug 2318048 depends on bug 2318054, which changed state.
Bug 2318054 Summary: Review Request: rust-serial-core - Rust abstractions for serial ports https://bugzilla.redhat.com/show_bug.cgi?id=2318054
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|COMPLETED |--- Status|CLOSED |NEW Keywords| |Reopened
https://bugzilla.redhat.com/show_bug.cgi?id=2318048 Bug 2318048 depends on bug 2318054, which changed state.
Bug 2318054 Summary: Review Request: rust-serial-core - Rust abstractions for serial ports https://bugzilla.redhat.com/show_bug.cgi?id=2318054
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |NEW Resolution|NOTABUG |---
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2318059
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2318059 [Bug 2318059] Review Request: rust-ioctl-rs - Rust bindings for system ioctls
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2321312
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2321312 [Bug 2321312] Review Request: rust-serial - Rust library for accessing serial ports
https://bugzilla.redhat.com/show_bug.cgi?id=2318048 Bug 2318048 depends on bug 2318054, which changed state.
Bug 2318054 Summary: Review Request: rust-serial-core - Rust abstractions for serial ports https://bugzilla.redhat.com/show_bug.cgi?id=2318054
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2318048
solomoncyj@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|NEW |CLOSED Last Closed|2024-10-23 07:39:58 |2024-12-06 02:52:26
https://bugzilla.redhat.com/show_bug.cgi?id=2318048 Bug 2318048 depends on bug 2318059, which changed state.
Bug 2318059 Summary: Review Request: rust-ioctl-rs - Rust bindings for system ioctls https://bugzilla.redhat.com/show_bug.cgi?id=2318059
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com