Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: stlink - tools for stm32 discovery boards
https://bugzilla.redhat.com/show_bug.cgi?id=822294
Summary: Review Request: stlink - tools for stm32 discovery boards Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rspanton@zepler.net QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: --- Regression: --- Mount Type: --- Documentation: ---
Spec URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec SRPM URL: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-20120517gitd2c78.fc16.s... Description: stlink is a set of tools for interacting with the STM32 discovery boards. It includes a program that acts as a gdbserver, and a tool for reading/writing/erasing the flash of the target on the boards.
A review would be much appreciated :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=822294
--- Comment #1 from Robert Spanton rspanton@zepler.net 2012-05-16 20:47:56 EDT --- Whoops, forgot the rpmlint output! Here it is:
stlink.spec: W: invalid-url Source0: stlink-d2c78.tar.bz2 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
It's an invalid URL because it's a git snapshot. No way around that one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=822294
--- Comment #2 from Robert Spanton rspanton@zepler.net 2012-05-16 21:00:38 EDT --- Now updated to include the AUTHORS and COPYING files:
New SRPM: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink-0-1.20120517gitd2c78.fc16... Specfile: http://users.ecs.soton.ac.uk/rds/rpm/stlink/stlink.spec
Cheers.
https://bugzilla.redhat.com/show_bug.cgi?id=822294
Jason Tibbitts tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rspanton@zepler.net Flags| |needinfo?(rspanton@zepler.n | |et)
--- Comment #3 from Jason Tibbitts tibbs@math.uh.edu --- I am triaging old review tickets. I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.
Unfortunately I have no way at all to even test this, and I suspect the other prospective reviewers are in the same boat. It's quite a simple package, though; on a quick inspection I can only see two issues:
We have guidelines relating to packaging tarballs from github, which you should follow instead of just saying that you generated a snapshot from git. http://fedoraproject.org/wiki/Packaging:SourceURL#Github
There is no need to clean the buildroot at the beginning of %install.
https://bugzilla.redhat.com/show_bug.cgi?id=822294
James Hogarth james.hogarth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |james.hogarth@gmail.com Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Flags|needinfo?(rob@robspanton.co | |m) | Last Closed| |2015-12-03 23:37:38
--- Comment #4 from James Hogarth james.hogarth@gmail.com --- As per the policy for stalled reviews closing this ticket as the requester has not responded to a needs info in over a year
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla