https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Bug ID: 1619095 Summary: Review Request: R-ps - List, Query, Manipulate System Processes Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: quantum.analyst@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://qulogic.fedorapeople.org//R-ps.spec SRPM URL: https://qulogic.fedorapeople.org//R-ps-1.1.0-1.fc28.src.rpm
Description: List, query and manipulate all system processes, on 'Windows', 'Linux' and 'macOS'.
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
--- Comment #1 from Elliott Sales de Andrade quantum.analyst@gmail.com --- This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=29193161
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Iñaki Ucar i.ucar86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |i.ucar86@gmail.com, | |quantum.analyst@gmail.com Flags| |needinfo?(quantum.analyst@g | |mail.com)
--- Comment #2 from Iñaki Ucar i.ucar86@gmail.com --- There's a dependency loop between processx and ps. Shouldn't ps handle that?
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- Looks good to me, package approved.
(In reply to Iñaki Ucar from comment #2)
There's a dependency loop between processx and ps. Shouldn't ps handle that?
The dep to ps was added in 3.2.0, so I guess Elliot will bump processx after importing this package.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core.
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 99 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/R-ps/review-R-ps/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local
R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section.
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in R-ps- debuginfo , R-ps-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 1.1.0, packaged version is 1.1.0
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: R-ps-1.1.0-1.fc29.x86_64.rpm R-ps-debuginfo-1.1.0-1.fc29.x86_64.rpm R-ps-debugsource-1.1.0-1.fc29.x86_64.rpm R-ps-1.1.0-1.fc29.src.rpm R-ps.x86_64: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS R-ps.src: W: spelling-error %description -l en_US macOS -> ma Cos, mac OS, mac-OS 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
--- Comment #4 from Iñaki Ucar i.ucar86@gmail.com --- (In reply to Robert-André Mauchin from comment #3)
(In reply to Iñaki Ucar from comment #2)
There's a dependency loop between processx and ps. Shouldn't ps handle that?
The dep to ps was added in 3.2.0, so I guess Elliot will bump processx after importing this package.
My point is that processx imports ps, while ps suggests processx, so ps should be built first. Therefore, the conditional BuildRequires should be in ps.
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(quantum.analyst@g | |mail.com) |
--- Comment #5 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Yes, that is true; I was a bit lazy with it since existing packages were sufficient to do the build. I will add the conditional on import.
I'm not entirely sure the whole R stack can be bootstrapped correctly, but I'm not sure how to go about testing that.
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-ps
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- R-ps-1.1.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-279fa8e9bb
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
--- Comment #8 from Iñaki Ucar i.ucar86@gmail.com --- (In reply to Elliott Sales de Andrade from comment #5)
I'm not entirely sure the whole R stack can be bootstrapped correctly, but I'm not sure how to go about testing that.
AFAIK, CRAN checks for dependency loops. But anyway, I tend to avoid Suggests in BuildRequires and check with _R_CHECK_FORCE_SUGGESTS_=0. CRAN already grants that all packages are checked with Suggests. We can grant that they can be also checked *without* Suggests, which they should do.
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
--- Comment #9 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Well, I mean the stack as it is packaged in Fedora currently.
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- R-ps-1.1.0-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-279fa8e9bb
https://bugzilla.redhat.com/show_bug.cgi?id=1619095
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2018-08-30 15:04:01
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- R-ps-1.1.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com