[Bug 2068106] New: Review Request: python-google-cloud-source-context - Python Client for Google Cloud Source Context
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
Bug ID: 2068106 Summary: Review Request: python-google-cloud-source-context - Python Client for Google Cloud Source Context Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mhayden@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-clo... SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-clo... Description: This package contains generated Python types for google.cloud.source_context_v1. Fedora Account System Username: mhayden
This is a tiny dependency for python-google-cloud-debugger-client (review coming shortly).
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |code@musicinmybrain.net Flags| |fedora-review? CC| |code@musicinmybrain.net
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
Ben Beasley code@musicinmybrain.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Ben Beasley code@musicinmybrain.net --- Package APPROVED. There are a few additional documentation files you might want to add.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: ======= - Dist tag is present.
OK: rpmautospec
- Suggest adding:
%doc CONTRIBUTING.rst %doc CODE_OF_CONDUCT.md %doc SECURITY.md
to the existing text documentation files
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0", "*No copyright* [generated file]". 72 files have unknown license. Detailed output of licensecheck in /home/reviewer/2068106-python-google-cloud-source- context/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.10/site- packages/google(python3-grpc-google-iam-v1, python3-google-cloud-os- config, python3-google-cloud-containeranalysis, python3-google-cloud- build, python3-google-cloud-apigee-connect, python3-google-cloud- bigquery-datatransfer, python3-google-cloud-dms, python3-google-cloud- datacatalog, python3-protobuf, python3-google-cloud-storage, python3-google-cloud-private-ca, python3-google-cloud-dlp, python3-google-cloud-iam, python3-google-cloud-bigquery-reservation, python3-googleapis-common-protos, python3-google-cloud-bigquery, python3-google-cloud-functions, python3-google-cloud-automl, python3-google-cloud-dns, python3-google-cloud-org-policy, python3-google-cloud-bigquery-storage, python3-google-cloud-firestore, python3-google-cloud-dataproc, python3-google-cloud-billing-budgets, python3-google-api-core, python3-google-cloud-api-gateway, python3-google-cloud-kms, python3-google-resumable-media, python3-google-cloud-redis, python3-google-cloud-core, python3-google- cloud-access-context-manager, python3-google-cloud-spanner, python3-google-cloud-bigquery-connection, python3-google-cloud- appengine-admin, python3-google-cloud-asset, python3-google-cloud- bigtable, python3-google-cloud-container, python3-google-cloud- billing, python3-google-cloud-access-approval, python3-google-cloud- dataproc-metastore, python3-google-cloud-data-fusion), /usr/lib/python3.10/site-packages/google/cloud(python3-google-cloud- os-config, python3-google-cloud-containeranalysis, python3-google- cloud-build, python3-google-cloud-apigee-connect, python3-google- cloud-bigquery-datatransfer, python3-google-cloud-dms, python3-google- cloud-datacatalog, python3-google-cloud-storage, python3-google-cloud- private-ca, python3-google-cloud-dlp, python3-google-cloud-iam, python3-google-cloud-bigquery-reservation, python3-googleapis-common- protos, python3-google-cloud-bigquery, python3-google-cloud-functions, python3-google-cloud-automl, python3-google-cloud-dns, python3-google- cloud-org-policy, python3-google-cloud-bigquery-storage, python3-google-cloud-firestore, python3-google-cloud-dataproc, python3-google-cloud-billing-budgets, python3-google-cloud-api- gateway, python3-google-cloud-kms, python3-google-cloud-redis, python3-google-cloud-core, python3-google-cloud-spanner, python3-google-cloud-bigquery-connection, python3-google-cloud-asset, python3-google-cloud-appengine-admin, python3-google-cloud-bigtable, python3-google-cloud-container, python3-google-cloud-billing, python3-google-cloud-access-approval, python3-google-cloud-dataproc- metastore, python3-google-cloud-data-fusion)
Appropriate co-ownership of Python namespace package directories.
[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described.
(tests pass)
[x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Cannot parse rpmlint output:
Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output:
Source checksums ---------------- https://github.com/googleapis/python-source-context/archive/v1.2.2/python-so... : CHECKSUM(SHA256) this package : c6c83822566bf7da5e3c3c4dfb2138e3fc9eb2ccf87f5af2cf027e7e58f55bf4 CHECKSUM(SHA256) upstream package : c6c83822566bf7da5e3c3c4dfb2138e3fc9eb2ccf87f5af2cf027e7e58f55bf4
Requires -------- python3-google-cloud-source-context (rpmlib, GLIBC filtered): ((python3.10dist(google-api-core) < 2.1~~ or python3.10dist(google-api-core) >= 2.2) with (python3.10dist(google-api-core) < 2.2~~ or python3.10dist(google-api-core) >= 2.3) with (python3.10dist(google-api-core) < 2.3 or python3.10dist(google-api-core) > 2.3) with (python3.10dist(google-api-core) < 2~~ or python3.10dist(google-api-core) >= 2.1) with python3.10dist(google-api-core) < 3~~dev0 with python3.10dist(google-api-core) >= 1.31.5) ((python3.10dist(google-api-core[grpc]) < 2.1~~ or python3.10dist(google-api-core[grpc]) >= 2.2) with (python3.10dist(google-api-core[grpc]) < 2.2~~ or python3.10dist(google-api-core[grpc]) >= 2.3) with (python3.10dist(google-api-core[grpc]) < 2.3 or python3.10dist(google-api-core[grpc]) > 2.3) with (python3.10dist(google-api-core[grpc]) < 2~~ or python3.10dist(google-api-core[grpc]) >= 2.1) with python3.10dist(google-api-core[grpc]) < 3~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.31.5) python(abi) python3.10dist(proto-plus)
Provides -------- python3-google-cloud-source-context: python-google-cloud-source-context python3-google-cloud-source-context python3.10-google-cloud-source-context python3.10dist(google-cloud-source-context) python3dist(google-cloud-source-context)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2068106 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Perl, Haskell, R, C/C++, SugarActivity, PHP, Ocaml, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2
python3-google-cloud-source-context.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/google/cloud/source_context_v1/py.typed /usr/lib/python3.10/site-packages/google/cloud/source_context/py.typed 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.8 s
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
--- Comment #2 from Major Hayden 🤠 mhayden@redhat.com --- Thanks, Ben! 🎉
Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/43565
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-cloud-source-context
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fb3ecdd47b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-fb3ecdd47b
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9d37729fcc has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-9d37729fcc *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-9d37729fcc
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fb3ecdd47b has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-fb3ecdd47b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-fb3ecdd47b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|ON_QA |CLOSED Last Closed| |2022-04-20 19:11:16
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-fb3ecdd47b has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2068106
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-9d37729fcc has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com