[Bug 529605] New: Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ohai - Profiles your system and emits JSON

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Summary: Review Request: ohai - Profiles your system and emits
                    JSON
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.2-1.fc12.src.rpm
Description: Ohai detects data about your operating system and prints out a
JSON data blob. It can be used standalone, but it's primary purpose is to
provide node data to Chef.

mkent@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint ohai.spec
/var/tmp/rpmbuild/SRPMS/ohai-0.3.2-1.magoazul.src.rpm
1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Though 0.3.4rc0 is out now this is the most recent stable version.

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Matthew Kent  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |525989, 525988

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Bug 529605 depends on bug 525988, which changed state.

Bug 525988 Summary: Review Request: rubygem-systemu - Multi-platform command execution and capture
https://bugzilla.redhat.com/show_bug.cgi?id=525988

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Bug 529605 depends on bug 525989, which changed state.

Bug 525989 Summary: Review Request: rubygem-extlib - Support library for DataMapper and Merb
https://bugzilla.redhat.com/show_bug.cgi?id=525989

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #1 from Matthew Kent   2009-10-22 02:37:33 EDT ---
Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.2-2.fc12.src.rpm

* Wed Oct 21 2009 Matthew Kent  - 0.3.2-2
- Include man page.

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Mamoru Tasaka   2009-10-23 14:43:11 EDT ---
Well, lib/ohai/mixin/command.rb is GPLv3+.
Would you ask the upstream if this is intentional?

The trouble is that this makes the whole ohai to be
under GPLv3+ (ASL 2.0 and GPLv3+ are compatible).
Then:

* rubygem-json - GPLv2 or Ruby
* rubygem-extlib - MIT
* rubygem-systemu - GPLv2 or Ruby
* ohai - GPLv3+

Since
- GPLv2 and GPLv3+ are incompatible
- Ruby and GPLv3+ are also incompatible
according to https://fedoraproject.org/wiki/Licensing ,
currently ohai is under license conflict.
if lib/ohai/mixin/command.rb is also changed to under ASL 2.0,
license conflict can be resolved.

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235(FE-Legal)

--- Comment #3 from Mamoru Tasaka   2009-10-23 14:43:58 EDT ---
For now setting FE-Legal

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #4 from Matthew Kent   2009-10-24 18:55:36 EDT ---
Hi, thank you for the review!

(In reply to comment #2)
> Well, lib/ohai/mixin/command.rb is GPLv3+.
> Would you ask the upstream if this is intentional?

I've asked them and they are discussing it.

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #5 from Matthew Kent   2009-10-29 02:43:42 EDT ---
Still waiting on the license issue.

Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.6-1.fc12.src.rpm

* Wed Oct 28 2009 Matthew Kent  - 0.3.6-1
- New upstream release.
- Add dependencies on rubygem-mixlib-{cli,config,log}
- man page included upstream

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #6 from Matthew Kent   2009-10-29 03:14:56 EDT ---
(In reply to comment #5)
> Still waiting on the license issue.
>
> Spec URL: http://magoazul.com/wip/SPECS/ohai.spec
> SRPM URL: http://magoazul.com/wip/SRPMS/ohai-0.3.6-1.fc12.src.rpm
> Wed Oct 28 2009 Matthew Kent  - 0.3.6-1
> New upstream release.
> Add dependencies on rubygem-mixlib-{cli,config,log}
> man page included upstream

Apologies, this update is broken. I'm going to have to rework things a little.

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #7 from Matthew Kent   2009-10-29 13:51:04 EDT ---
Asking for advice on this package at

https://www.redhat.com/archives/fedora-packaging/2009-October/msg00091.html

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #8 from Mamoru Tasaka   2009-10-30 12:41:47 EDT ---
About your mail:
I would package this from gem (as it seems the simplest, I prefer
simpleness), and if non-gem support scripts on other packages can
be avoided, it is better. However I leave it to you how to package 
this software.

[Bug 529605] Review Request: ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #9 from Matthew Kent   2009-11-03 03:48:22 EDT ---
Still waiting on legal in http://tickets.opscode.com/browse/OHAI-137

(In reply to comment #8)
> About your mail:
> I would package this from gem (as it seems the simplest, I prefer
> simpleness), and if non-gem support scripts on other packages can
> be avoided, it is better. However I leave it to you how to package 
> this software.

Thank you for your input.

I agree it would be simpler to use the gem but after some discussion with
upstream and having packaged it's main parent package, Chef, I think I'll
pursue this submission with dependencies on rubygem-* packages (option b) for
the time being.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Matthew Kent  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|182235(FE-Legal)            |
            Summary|Review Request: ohai -      |Review Request:
                   |Profiles your system and    |rubygem-ohai - Profiles
                   |emits JSON                  |your system and emits JSON

--- Comment #10 from Matthew Kent  2010-03-22 13:10:10 EDT ---
So the legal issue is resolved by upstream and I've decided to take the path of
least resistance and let rubygems do the work of installing as upstream hasn't
added any kind of setup.rb system yet.

Spec URL: http://magoazul.com/wip/SPECS/rubygem-ohai.spec
SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-ohai-0.5.0-1.fc14.src.rpm

rpmlint /var/tmp/results/rubygem-ohai-* | grep -v '/1.8/doc/'
rubygem-ohai.src: W: no-buildroot-tag
rubygem-ohai-doc.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
(skipping the unexpanded-macro warnings in docs)

Build logs here http://koji.fedoraproject.org/koji/taskinfo?taskID=2068382

The only issue I can't decipher is a strange occasional failure in one
extremely simple test within the test suite when run within the build root -
something to do with Time. Can't reproduce it outside mock.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #11 from Mamoru Tasaka  2010-03-23 14:18:39 EDT ---
Well,
With ohai 0.3.2, $ ohai returned some information of my system.
0.3.6: not tested
With 0.5.0:

$ ohai
/usr/lib/ruby/1.8/logger.rb:314:in `<': comparison of Fixnum with :info failed
(ArgumentError)
 from /usr/lib/ruby/1.8/logger.rb:314:in `add'
 from /usr/lib/ruby/1.8/logger.rb:348:in `debug'
 from /usr/lib/ruby/gems/1.8/gems/mixlib-log-1.0.3/lib/mixlib/log.rb:70:in
`send'
 from /usr/lib/ruby/gems/1.8/gems/mixlib-log-1.0.3/lib/mixlib/log.rb:70:in
`method_missing'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:200:in
`require_plugin'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:190:in `each'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:190:in
`require_plugin'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/system.rb:116:in
`all_plugins'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/application.rb:89:in
`run_application'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/lib/ohai/application.rb:67:in
`run'
 from /usr/lib/ruby/gems/1.8/gems/ohai-0.5.0/bin/ohai:40
 from /usr/bin/ohai:19:in `load'
 from /usr/bin/ohai:19

Would you examine this?

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #12 from Matthew Kent  2010-03-23 18:23:42 EDT ---
(In reply to comment #11)
> With 0.5.0:
>
> $ ohai
> /usr/lib/ruby/1.8/logger.rb:314:in `<': comparison of Fixnum with :info failed
> (ArgumentError)

My apologies I believe this is due to an older version mixlib-log, I've pushed
new F-13 and rawhide versions that should fix that.

Alternately it's available here:
http://magoazul.com/wip/x86_64/rubygem-mixlib-log-1.1.0-1.fc14.noarch.rpm or
http://magoazul.com/wip/SRPMS/rubygem-mixlib-log-1.1.0-1.fc14.src.rpm if you
prefer.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #13 from Mamoru Tasaka  2010-03-24 13:38:53 EDT ---
Thanks, now /usr/bin/ohai works.

Well,
- %ruby_sitelib macro doesn't seem to be needed

Other things are okay.
----------------------------------------------------------
  This package (rubygem-ohai) is APPROVED by mtasaka
----------------------------------------------------------

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #14 from Matthew Kent  2010-03-24 14:34:02 EDT ---
Thank you for the review!

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Matthew Kent  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #15 from Matthew Kent  2010-03-24 14:35:19 EDT ---
New Package CVS Request
=======================
Package Name: rubygem-ohai
Short Description: Profiles your system and emits JSON
Owners: mkent
Branches: F-11 F-12 F-13
InitialCC:

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Dennis Gilmore  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #16 from Dennis Gilmore  2010-03-25 16:56:08 EDT ---
CVS Done

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #17 from Fedora Update System  2010-03-27 19:16:47 EDT ---
rubygem-ohai-0.5.0-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/rubygem-ohai-0.5.0-1.fc12

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #18 from Fedora Update System  2010-03-27 19:17:43 EDT ---
rubygem-ohai-0.5.0-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/rubygem-ohai-0.5.0-1.fc13

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #19 from Fedora Update System  2010-03-27 19:20:41 EDT ---
rubygem-ohai-0.5.0-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/rubygem-ohai-0.5.0-1.fc11

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Mamoru Tasaka  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #20 from Mamoru Tasaka  2010-03-28 11:54:43 EDT ---
Closing.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #21 from Fedora Update System  2010-03-29 22:22:28 EDT ---
rubygem-ohai-0.5.0-1.fc11 has been pushed to the Fedora 11 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|                            |rubygem-ohai-0.5.0-1.fc11
         Resolution|NEXTRELEASE                 |ERRATA

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|rubygem-ohai-0.5.0-1.fc11   |rubygem-ohai-0.5.0-1.fc12

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #22 from Fedora Update System  2010-03-29 22:23:11 EDT ---
rubygem-ohai-0.5.0-1.fc12 has been pushed to the Fedora 12 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

--- Comment #23 from Fedora Update System  2010-04-09 00:07:10 EDT ---
rubygem-ohai-0.5.0-1.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 529605] Review Request: rubygem-ohai - Profiles your system and emits JSON

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=529605

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|rubygem-ohai-0.5.0-1.fc12   |rubygem-ohai-0.5.0-1.fc13