[Bug 2250145] New: Review Request: node_exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Bug ID: 2250145
           Summary: Review Request: node_exporter - Exporter for machine
                    metrics
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://mikel.olasagasti.info/tmp/fedora/node_exporter.spec
SRPM URL:
https://mikel.olasagasti.info/tmp/fedora/node_exporter-1.6.1-1.fc39.src.rpm
Description: in Go with pluggable metric collectors.
Fedora Account System Username: mikelo2

This is to rename golang-github-prometheus-node-exporter to node_exporter as
it's widely known.

[Bug 2250145] Review Request: node_exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #1 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6651196
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Mikel Olasagasti Uranga  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request:
                   |node_exporter - Exporter    |node-exporter - Exporter
                   |for machine metrics         |for machine metrics
           Doc Type|---                         |If docs needed, set a value

--- Comment #2 from Mikel Olasagasti Uranga  ---
Spec URL: https://mikel.olasagasti.info/tmp/fedora/node-exporter.spec
SRPM URL:
https://mikel.olasagasti.info/tmp/fedora/node-exporter-1.6.1-1.fc39.src.rpm

Changing the name from node_exporter to node-exporter and add a Provides to
node_exporter as suggested by gotmax23 in Matrix.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #3 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6666950
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Alejandro Sáez Morollón  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Mark E. Fuller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Mark E. Fuller  ---
this is currently FTBFS:
https://download.copr.fedorainfracloud.org/results/fuller/scratch/fedora-raw...

I can try to dig in later, but I suspect a dependent package isn't up to date:
```
# github.com/prometheus/node_exporter/collector
_build/src/github.com/prometheus/node_exporter/collector/cpu_linux.go:324:19:
cannot use stats.CPU (variable of type []procfs.CPUStat) as
map[int64]procfs.CPUStat value in argument to c.updateCPUStats
_build/src/github.com/prometheus/node_exporter/collector/netclass_rtnl_linux.go:223:20:
undefined: sysfs.ParseNetClassAttribute
_build/src/github.com/prometheus/node_exporter/collector/softnet_linux.go:106:44:
cpuStats.Index undefined (type procfs.SoftnetStat has no field or method Index)
_build/src/github.com/prometheus/node_exporter/collector/softnet_linux.go:129:21:
cpuStats.CPUCollision undefined (type procfs.SoftnetStat has no field or method
CPUCollision)
_build/src/github.com/prometheus/node_exporter/collector/softnet_linux.go:135:21:
cpuStats.ReceivedRps undefined (type procfs.SoftnetStat has no field or method
ReceivedRps)
_build/src/github.com/prometheus/node_exporter/collector/softnet_linux.go:141:21:
cpuStats.FlowLimitCount undefined (type procfs.SoftnetStat has no field or
method FlowLimitCount)
_build/src/github.com/prometheus/node_exporter/collector/softnet_linux.go:147:21:
cpuStats.SoftnetBacklogLen undefined (type procfs.SoftnetStat has no field or
method SoftnetBacklogLen)
```

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #5 from Mikel Olasagasti Uranga  ---
Spec URL: https://mikel.olasagasti.info/tmp/fedora/node-exporter.spec
SRPM URL:
https://mikel.olasagasti.info/tmp/fedora/node-exporter-1.6.1-1.fc39.src.rpm

Now that the updates required for node-exporter-1.6.1 landed rawhide, it should
build just fine.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #6 from Mark E. Fuller  ---
I'm still getting errors building in COPR, although now much more perplexing
(like my go-task FTBFS):

https://download.copr.fedorainfracloud.org/results/fuller/scratch/fedora-raw...

tail:
```
cd /builddir/build/BUILD/node_exporter-1.6.1
/usr/lib/golang/pkg/tool/linux_amd64/compile -o $WORK/b277/_pkg_.a -trimpath
"$WORK/b277=>" -p runtime/cgo -std -installsuffix shared -buildid
98cfZstdMgntRGORbBbA/98cfZstdMgntRGORbBbA -goversion go1.21.4 -symabis
$WORK/b277/symabis -c=2 -shared -nolocalimports -importcfg $WORK/b277/importcfg
-pack -asmhdr $WORK/b277/go_asm.h /usr/lib/golang/src/runtime/cgo/callbacks.go
/usr/lib/golang/src/runtime/cgo/callbacks_traceback.go
/usr/lib/golang/src/runtime/cgo/handle.go
/usr/lib/golang/src/runtime/cgo/iscgo.go
/usr/lib/golang/src/runtime/cgo/linux.go
/usr/lib/golang/src/runtime/cgo/mmap.go
/usr/lib/golang/src/runtime/cgo/setenv.go
/usr/lib/golang/src/runtime/cgo/sigaction.go $WORK/b277/_cgo_gotypes.go
$WORK/b277/cgo.cgo1.go $WORK/b277/_cgo_import.go
cp /usr/lib/golang/src/runtime/cgo/abi_amd64.h $WORK/b277/abi_GOARCH.h
cd /usr/lib/golang/src/runtime/cgo
/usr/lib/golang/pkg/tool/linux_amd64/asm -p runtime/cgo -trimpath
"$WORK/b277=>" -I $WORK/b277/ -I /usr/lib/golang/pkg/include -D GOOS_linux -D
GOARCH_amd64 -shared -D GOAMD64_v1 -o $WORK/b277/asm_amd64.o ./asm_amd64.s
/usr/lib/golang/pkg/tool/linux_amd64/pack r $WORK/b277/_pkg_.a
$WORK/b277/asm_amd64.o $WORK/b277/_x001.o $WORK/b277/_x002.o $WORK/b277/_x003.o
$WORK/b277/_x004.o $WORK/b277/_x005.o $WORK/b277/_x006.o $WORK/b277/_x007.o
$WORK/b277/_x008.o $WORK/b277/_x009.o $WORK/b277/_x010.o $WORK/b277/_x011.o
$WORK/b277/_x012.o $WORK/b277/_x013.o $WORK/b277/_x014.o # internal
/usr/lib/golang/pkg/tool/linux_amd64/buildid -w $WORK/b277/_pkg_.a # internal
cp $WORK/b277/_pkg_.a
/builddir/.cache/go-build/d6/d6423b521d646d5d29969afb23f96a447bb890be28dd43774347ef25aba5650c-d
# internal

RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.yHn2xc (%build)
    Bad exit status from /var/tmp/rpm-tmp.yHn2xc (%build)
Finish: rpmbuild node-exporter-1.6.1-1.fc40.src.rpm
Finish: build phase for node-exporter-1.6.1-1.fc40.src.rpm
INFO: chroot_scan: 3 files copied to /var/lib/copr-rpmbuild/results/chroot_scan
INFO:
/var/lib/mock/fedora-rawhide-x86_64-1701650664.979889/root/var/log/dnf.rpm.log
/var/lib/mock/fedora-rawhide-x86_64-1701650664.979889/root/var/log/dnf.librepo.log
/var/lib/mock/fedora-rawhide-x86_64-1701650664.979889/root/var/log/dnf.log
ERROR:
Exception(/var/lib/copr-rpmbuild/results/node-exporter-1.6.1-1.fc40.src.rpm)
Config(fedora-rawhide-x86_64) 0 minutes 42 seconds
INFO: Results and/or logs in: /var/lib/copr-rpmbuild/results
INFO: Cleaning up build root ('cleanup_on_failure=True')
Start: clean chroot
INFO: unmounting tmpfs.
Finish: clean chroot
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M 0b77ac849d1445cb80baa78e68faf3b8 -D
/var/lib/mock/fedora-rawhide-x86_64-1701650664.979889/root -a -u mockbuild
--capability=cap_ipc_lock --rlimit=RLIMIT_NOFILE=10240
--capability=cap_ipc_lock --bind=/tmp/mock-resolv.21o__xxg:/etc/resolv.conf
--bind=/dev/btrfs-control --bind=/dev/mapper/control --bind=/dev/fuse
--bind=/dev/loop-control --bind=/dev/loop0 --bind=/dev/loop1 --bind=/dev/loop2
--bind=/dev/loop3 --bind=/dev/loop4 --bind=/dev/loop5 --bind=/dev/loop6
--bind=/dev/loop7 --bind=/dev/loop8 --bind=/dev/loop9 --bind=/dev/loop10
--bind=/dev/loop11 --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash
--setenv=HOME=/builddir --setenv=HOSTNAME=mock
--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf
"\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v$ '
--setenv=LANG=C.UTF-8 --resolv-conf=off bash --login -c '/usr/bin/rpmbuild -ba
--noprep  --target x86_64 --nodeps
/builddir/build/originals/node-exporter.spec'

Copr build error: Build failed
```

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #7 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6721541
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #8 from Fedora Review Service  ---
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6721573
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #9 from Mikel Olasagasti Uranga  ---
The problem is that Copr is not using latest packages from rawhide. It should
be OK after some hours (days?).

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Mark E. Fuller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]              |[e-mail]
              Flags|                            |fedora-review+

--- Comment #10 from Mark E. Fuller  ---
This a go2rpm-generated spec file package:

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi
ticket.

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

--- Comment #11 from Fedora Admin user for bugzilla script actions  ---
The Pagure repository was created at
https://src.fedoraproject.org/rpms/node-exporter

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |MODIFIED

--- Comment #12 from Fedora Update System  ---
FEDORA-2024-ede6176e20 has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ede6176e20

[Bug 2250145] Review Request: node-exporter - Exporter for machine metrics

https://bugzilla.redhat.com/show_bug.cgi?id=2250145

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2024-01-13 16:03:26

--- Comment #13 from Fedora Update System  ---
FEDORA-2024-ede6176e20 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.