[Bug 666222] New: Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Summary: Review Request: python-speaklater - implements a lazy
                    string for python useful for use with gettext
           Product: Fedora
           Version: 14
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Juan Barba  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://rpmdev.proyectofedor
                   |                            |a.org/projects/python-speak
                   |                            |later

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #1 from Juan Barba  2010-12-29 21:55:23 EST ---
Spec URL:
http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater.sp...
SRPM URL:
http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater-1....

Description:

A module that provides lazy strings for translations.  Basically you get an
object that appears to be a string but changes the value every time the value
is evaluated based on a callable you provide.

I want to note that this is my first package and I need sponsor please.

RPMLINT SUMMARY:

- SRPM
   * 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- SPEC
   * 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Juan Barba  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841(FE-NEEDSPONSOR)

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |m

--- Comment #2 from Abdel Gadiel Martínez Lassonde  2010-12-29 22:11:16 EST ---
I have tested it and it's OK.  The SPEC Filename, Package Name, Version and
Release are appropiate.  The Requires are fine.  I installed it without any
problems.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
                   |                            |m

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #3 from Juan Barba  2010-12-30 13:22:20 EST ---
New Package SCM Request
=======================
Package Name: python-speaklater
Short Description: implements a lazy string for python useful for use with
gettext
Owners: haks
Branches: f13 f14 f15 el5 el6
InitialCC: potty gomix

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #4 from Jason Tibbitts  2010-12-30 14:58:37 EST ---
Something is a bit odd with this ticket.

First, you should raise the fedora-cvs flag when submitting SCM requests so
that they will be seen.

Second, I cannot find any FAS account named "haks".  I found "xhaksx", but that
account is not part of the packager group and cannot own packages.

Third, I cannot find any FAS account containing the string "Lassonde".  Abdel,
what is your FAS ID?  I thought I knew most of the sponsors, but that name is
not familiar to me.  Are you really a sponsor?  You cannot review Juan's
package if you are not.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Abdel Gadiel Martínez Lassonde  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail] |[e-mail]
                   |m                           |

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Toshio Ernie Kuratomi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #5 from Toshio Ernie Kuratomi  2010-12-30 18:35:10 EST ---
NEEDSWORK

Good:
* rpmlint:
python-speaklater.noarch: W: spelling-error Summary(en_US) gettext -> get text,
get-text, getter
python-speaklater.src: W: spelling-error Summary(en_US) gettext -> get text,
get-text, getter
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Those are ignorable

* named according to the guidelines
* spec file matches package name
* license is BSD in spec and package itself which is an approved free software
license
* spec file is readable
* Source matches upstream and upstream URL is canonical
* No locales so no need for %find_lang
* Not a C library
* No bundled system libraries
* Not relocatable
* Package owns all files and directories it creates and nothing else
* Permissions set properly
* Macros used consistently
* Code, not content
* No large documentation files
* Not a GUI application
* All filenames valid UTF-8

MUST FIX:
* Package does not build in koji
  : Package builds in koji
  - The reason is related to the %install section that I'll explain below.

Should do:
* I see that upstream has a LICENSE and a README file in their git repository. 
You should send them an email to have them include those in their releases. 
They probably need a MANIFEST.in file that lists those (something like:

MANIFEST.in:
  include README LICENSE

Notes:

There's a couple non-Fedora-standard things in here.  One of those is
contributing to the build failure.  This page
https://fedoraproject.org/wiki/Packaging:Python  has the python-specific
guidelines for Fedora.  If you take a look you'll see that your %install
section and %files section are a bit different.  In this section, it recommends
not to use --record=INSTALLED_FILES
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling.  In this
section, there's a simple example of what the install section should look like:
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Se...
 (sorry it's hidden away and the more complex python2/python3 spec is on the
main page.)

Basically instead of this:
%{__python} setup.py install --single-version-externally-managed -O1
--root=%{buildroot} --record=INSTALLED_FILES
[..]
%files -f INSTALLED_FILES

You should have this:
%{__python} setup.py install --root=%{buildroot}
[..]]
%files
%{python_sitelib}/*

The reason that this is contributing to a build failure is that the setup.py
file is conditionally using setuptools to build.  When it uses setuptools,
--single-version-externally-managed is a valid command line option.  When it
only uses distutils, that option is not available.  You could BuildRequire:
setuptools to fix that but it's simpler to just make the setup.py install line
reflect what the guidelines suggest which works with both distutils and
setuptools.

If you fix those things, I can try building in koji again and approve this
package.  As discussed on IRC, you're also looking at reviewing a package and
then I'll sponsor you.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #6 from Juan Barba  2011-01-26 00:55:29 EST ---
I applied the corrections

Spec URL:
http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater.sp...
SRPM URL:
http://xhaksx.fedorapeople.org/rpmdev/python-speaklater/python-speaklater-1....

RPMLINT SUMMARY:

- SRPM
   * 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
- SPEC
   * 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Toshio Ernie Kuratomi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #7 from Toshio Ernie Kuratomi  2011-01-26 15:09:07 EST ---
All problems taken care of.  The package is APPROVED.  Now to get you
sponsored....

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Juan Barba  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #8 from Kevin Fenzi  2011-02-06 17:49:51 EST ---
WARNING: "haks" is not a valid FAS account.

Can you work with your sponsor to get your account setup, then reset the
fedora-cvs flag?
thanks.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #9 from Juan Barba  2011-02-07 23:27:29 EST ---
New Package SCM Request
=======================
Package Name: python-speaklater
Short Description: implements a lazy string for python useful for use with
gettext
Owners: xhaksx
Branches: f13 f14 f15 el5 el6
InitialCC: potty gomix toshio

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

Juan Barba  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #10 from Bill Nottingham  2011-02-08 15:05:32 EST ---
f15 is not a valid branch - please resubmit with correct branches.

[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=666222

--- Comment #11 from Jason Tibbitts  2011-02-10 14:23:51 EST ---
Well, it's a valid branch as of now, so....

Git done (by process-git-requests).