https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Bug ID: 1310124 Summary: Review Request: nodejs-chalk0 - Terminal string styling done right Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jsmith.fedora@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-chalk0/nodejs-chalk0.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-chalk0/nodejs-chalk0-0.4.0-... Description: Terminal string styling done right Fedora Account System Username: jsmith
Note that this is a split of the 0.4 series of nodejs-chalk, so that we can update the existing nodejs-chalk to the 1.x series
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |956806 (nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vanmeeuwen+fedora@kolabsys. | |com QA Contact|extras-qa@fedoraproject.org |vanmeeuwen+fedora@kolabsys. | |com
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |vanmeeuwen+fedora@kolabsys. | |com QA Contact|vanmeeuwen+fedora@kolabsys. |extras-qa@fedoraproject.org |com |
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
--- Comment #1 from Jeroen van Meeuwen vanmeeuwen+fedora@kolabsys.com --- %check fails:
============= Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Gc2GAH + umask 022 + cd /builddir/build/BUILD + cd package + /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check + /usr/bin/node -e 'require("./")' + /usr/bin/mocha chalk 1) should style string 2) should support applying multiple styles at once 3) should support nesting styles 4) should reset all styles with `.reset()` 5) should alias gray to grey 6) should support variable number of arguments 7) should support falsy values ✓ don't output escape codes if the input is empty chalk.enabled ✓ should not output colors when manually disabled chalk.styles ✓ should expose the styles as ANSI escape codes chalk.stripColor() ✓ should strip color from string 4 passing (15ms) 7 failing 1) chalk should style string: AssertionError: 'foo' == '\u001b[4mfoo\u001b[24m' + expected - actual +foo -foo
at Context.<anonymous> (test.js:8:10) 2) chalk should support applying multiple styles at once: AssertionError: 'foo' == '\u001b[4m\u001b[42m\u001b[31mfoo\u001b[39m\u001b[49m\u001b[24m' + expected - actual +foo -foo
at Context.<anonymous> (test.js:14:10) 3) chalk should support nesting styles: AssertionError: 'foobar!' == '\u001b[31mfoo\u001b[44m\u001b[4mbar\u001b[24m\u001b[49m!\u001b[39m' + expected - actual +foobar! -foobar!
at Context.<anonymous> (test.js:19:10) 4) chalk should reset all styles with `.reset()`: AssertionError: 'foofoo' == '\u001b[0m\u001b[4m\u001b[42m\u001b[31mfoo\u001b[39m\u001b[49m\u001b[24mfoo\u001b[0m' + expected - actual +foofoo -foofoo
at Context.<anonymous> (test.js:26:10) 5) chalk should alias gray to grey: AssertionError: 'foo' == '\u001b[90mfoo\u001b[39m' + expected - actual +foo -foo
at Context.<anonymous> (test.js:30:10) 6) chalk should support variable number of arguments: AssertionError: 'foo bar' == '\u001b[31mfoo bar\u001b[39m' + expected - actual +foo bar -foo bar
at Context.<anonymous> (test.js:34:10) 7) chalk should support falsy values: AssertionError: '0' == '\u001b[31m0\u001b[39m' + expected - actual +0 -0
at Context.<anonymous> (test.js:38:10) error: Bad exit status from /var/tmp/rpm-tmp.Gc2GAH (%check) ===========
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed| |2016-08-03 09:33:36
--- Comment #2 from Jared Smith jsmith.fedora@gmail.com --- This package is no longer needed, so I'm closing the package review.
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1363763
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1363763 [Bug 1363763] Review Request: nodejs-js-beautify - A jsbeautifier.org for node
https://bugzilla.redhat.com/show_bug.cgi?id=1310124
Jared Smith jsmith.fedora@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|1363763 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1363763 [Bug 1363763] Review Request: nodejs-js-beautify - A jsbeautifier.org for node
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla