https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Bug ID: 1194058 Summary: Review Request: atomic - Tool for managing ProjectAtomic systems and containers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: lsm5@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.1.git6b82cb7.fc23.src....
Upstream URL: https://github.com/projectatomic/atomic
Description: %{summary}
The goal of Atomic is to provide a high level, coherent entrypoint to the system, and fill in gaps.
For Docker, atomic can make it easier to interact with special kinds of containers, such as super-privileged debugging tools and the like.
The atomic host subcommand wraps rpm-ostree, currently just providing a friendlier name, but in the future Atomic may provide more unified management.
Fedora Account System Username: lsm5
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8985986
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #1 from Lokesh Mandvekar lsm5@redhat.com --- Need to install docs ... updating spec
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #2 from Lokesh Mandvekar lsm5@redhat.com --- %changelog * Wed Feb 18 2015 Lokesh Mandvekar lsm5@fedoraproject.org - 0-0.2.git6b82cb7 - install docs
Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.2.git6b82cb7.fc23.src....
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #3 from Lokesh Mandvekar lsm5@redhat.com --- I'm hoping the package name 'atomic' isn't really confusing to people given:
$ yum search atomic ... AtomicParsley-debuginfo.x86_64 : Debug information for package AtomicParsley boost-atomic.i686 : Run-Time component of boost atomic library boost-atomic.x86_64 : Run-Time component of boost atomic library fedora-productimg-atomic.noarch : Installer branding and configuration for Fedora Atomic katomic-debuginfo.x86_64 : Debug information for package katomic libatomic.i686 : The GNU Atomic library libatomic.x86_64 : The GNU Atomic library libatomic-static.i686 : The GNU Atomic static library libatomic-static.x86_64 : The GNU Atomic static library libatomic_ops.i686 : Atomic memory update operations libatomic_ops.x86_64 : Atomic memory update operations libatomic_ops-debuginfo.x86_64 : Debug information for package libatomic_ops libatomic_ops-devel.i686 : Development files for libatomic_ops libatomic_ops-devel.x86_64 : Development files for libatomic_ops libatomic_ops-static.i686 : Static library files for libatomic_ops libatomic_ops-static.x86_64 : Static library files for libatomic_ops rubygem-atomic.x86_64 : An atomic reference implementation for JRuby, Rubinius, and MRI rubygem-atomic-debuginfo.x86_64 : Debug information for package rubygem-atomic rubygem-atomic-doc.noarch : Documentation for rubygem-atomic tuned-profiles-atomic.noarch : Additional tuned profiles targeted to Atomic AtomicParsley.x86_64 : Command-line program to read and set MPEG-4 tags compatible with iPod/iTunes ape.x86_64 : A tool for generating atomic pseudopotentials within a DFT framework gpaw-setups.noarch : Atomic GPAW setups katomic.x86_64 : An educational game built around molecular geometry python-ase.noarch : Atomic Simulation Environment texlive-tikzorbital.noarch : Atomic and molecular orbitals using TiKZ
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #4 from Colin Walters walters@redhat.com --- - Does the description need to duplicate the summary? - Can we upstream most of these build fixes? I just submitted e.g. https://github.com/projectatomic/atomic/pull/19
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #5 from Lokesh Mandvekar lsm5@redhat.com --- (In reply to Colin Walters from comment #4)
- Does the description need to duplicate the summary?
It need not I guess. I deleted %{summary} from description.
Spec URL: https://github.com/lsm5/atomic-rpm/blob/master/atomic.spec SRPM URL: https://github.com/lsm5/atomic-rpm/raw/master/SRPMS/atomic-0-0.3.gite4081c9....
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #6 from Lokesh Mandvekar lsm5@redhat.com --- Trouble with github urls sorry. Reverting to fedorapeople urls:
Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.3.gite4081c9.fc23.src....
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Colin Walters walters@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |walters@redhat.com Flags|fedora-review? |fedora-review+
--- Comment #7 from Colin Walters walters@redhat.com --- Ok, the latest fedora-review is giving me errors on RHEL7, so not pasting that.
However, we changed license upstream to LGPLv2+, can you update the spec file too? See https://github.com/projectatomic/atomic/issues/21
With that change, LGTM.
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #8 from Lokesh Mandvekar lsm5@redhat.com --- fedora-review seems to work fine on fedora rawhide though. but nvm, thanks for the review, here's the updates:
%changelog * Fri Feb 20 2015 Lokesh Mandvekar lsm5@fedoraproject.org - 0-0.4.gitf7f6fa8 - Resolves: rhbz#1194058 - approved version, ready for upload - change license to LGPLv2+
Spec URL: https://lsm5.fedorapeople.org/atomic/atomic.spec SRPM URL: https://lsm5.fedorapeople.org/atomic/SRPMS/atomic-0-0.4.gitf7f6fa8.fc23.src....
scm request follows
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #9 from Lokesh Mandvekar lsm5@redhat.com --- New Package SCM Request ======================= Package Name: atomic Short Description: Tool for managing ProjectAtomic systems and containers Upstream URL: https://github.com/projectatomic/atomic Owners: lsm5 walters Branches: f22 f21 f20 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limburgher@gmail.com
--- Comment #10 from Lokesh Mandvekar lsm5@redhat.com --- ping limb..
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- There's a problem with git branch creation at the moment, we're working on it. Once we have it worked out I'll run the whole queue ASAP.
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Patrick Uiterwijk puiterwijk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
--- Comment #12 from Patrick Uiterwijk puiterwijk@redhat.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1194058
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Fixed In Version| |atomic-0-0.7.gita7ff4cb Resolution|--- |CURRENTRELEASE Last Closed| |2015-03-31 23:02:08
package-review@lists.fedoraproject.org