https://bugzilla.redhat.com/show_bug.cgi?id=2183018
Bug ID: 2183018 Summary: Review Request: kommit - Git gui client for KDE Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: vascom2@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://raw.githubusercontent.com/Vascom/kommit/main/kommit.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3110/99313110/kommit-1.0.1-1....
Description: Git gui client for KDE.
It is renaming Review Request of gitklient package.
https://bugzilla.redhat.com/show_bug.cgi?id=2183018
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://apps.kde.org/kommit | |/
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5729146 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2183018
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |vitaly@easycoding.org Flags| |fedora-review? CC| |vitaly@easycoding.org Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=2183018
--- Comment #2 from Vitaly Zaitsev vitaly@easycoding.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Creative Commons CC0 1.0", "Unknown or generated", "Creative Commons Attribution-ShareAlike 4.0", "*No copyright* GNU General Public License, Version 3", "*No copyright* BSD 3-Clause License", "GNU General Public License, Version 3", "*No copyright* GNU Library General Public License, Version 2.0". 141 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/kommit/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/qt5/plugins/kf5/overlayicon [-]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/HTML, /usr/lib64/qt5/plugins/kf5/overlayicon, /usr/share/doc/HTML/en, /usr/lib64/qt5/plugins/kf5/kfileitemaction [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: kommit-1.0.1-1.fc39.x86_64.rpm kommit-debuginfo-1.0.1-1.fc39.x86_64.rpm kommit-debugsource-1.0.1-1.fc39.x86_64.rpm kommit-1.0.1-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpyj88x4vn')] checks: 31, packages: 4
kommit.x86_64: W: no-manual-page-for-binary kommit kommit.x86_64: W: no-manual-page-for-binary kommitdiff kommit.x86_64: W: no-manual-page-for-binary kommitmerge kommit.x86_64: W: files-duplicate /usr/share/licenses/kommit/LICENSE /usr/share/licenses/kommit/COPYING 4 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 0.8 s
Rpmlint (debuginfo) ------------------- Checking: kommit-debuginfo-1.0.1-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpy4bbltlg')] checks: 31, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.4 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3
kommit.x86_64: W: no-manual-page-for-binary kommit kommit.x86_64: W: no-manual-page-for-binary kommitdiff kommit.x86_64: W: no-manual-page-for-binary kommitmerge kommit.x86_64: W: files-duplicate /usr/share/licenses/kommit/LICENSE /usr/share/licenses/kommit/COPYING 3 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken 1.5 s
Unversioned so-files -------------------- kommit: /usr/lib64/qt5/plugins/kf5/kfileitemaction/kommititemaction.so kommit: /usr/lib64/qt5/plugins/kf5/overlayicon/kommitoverlayplugin.so
Source checksums ---------------- https://invent.kde.org/sdk/kommit/-/archive/v1.0.1/kommit-v1.0.1.tar.bz2 : CHECKSUM(SHA256) this package : f9b07bba362e3f2f71e68909ba6aeab4f01e418972adf459e572478d265488d8 CHECKSUM(SHA256) upstream package : f9b07bba362e3f2f71e68909ba6aeab4f01e418972adf459e572478d265488d8
Requires -------- kommit (rpmlib, GLIBC filtered): /usr/bin/sh hicolor-icon-theme kf5-filesystem libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5DBusAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOGui.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5Parts.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5SyntaxHighlighting.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Concurrent.so.5()(64bit) libQt5Concurrent.so.5(Qt_5)(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libkommit.so.0()(64bit) libkommitdiff.so.0()(64bit) libkommitgui.so.0()(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH)
kommit-debuginfo (rpmlib, GLIBC filtered):
kommit-debugsource (rpmlib, GLIBC filtered):
Provides -------- kommit: application() application(org.kde.kommit.desktop) application(org.kde.kommit.diff.desktop) application(org.kde.kommit.merge.desktop) gitklient kommit kommit(x86-64) libkommit.so.0()(64bit) libkommitdiff.so.0()(64bit) libkommitgui.so.0()(64bit) metainfo() metainfo(org.kde.kommit.appdata.xml)
kommit-debuginfo: debuginfo(build-id) kommit-debuginfo kommit-debuginfo(x86-64) libkommit.so.0.4.0-1.0.1-1.fc39.x86_64.debug()(64bit) libkommitdiff.so.0.4.0-1.0.1-1.fc39.x86_64.debug()(64bit) libkommitgui.so.0.4.0-1.0.1-1.fc39.x86_64.debug()(64bit)
kommit-debugsource: kommit-debugsource kommit-debugsource(x86-64)
Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name kommit --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Python, Perl, Ocaml, PHP, fonts, Haskell, Java, SugarActivity, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=2183018
Vitaly Zaitsev vitaly@easycoding.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Vitaly Zaitsev vitaly@easycoding.org ---
Directories without known owners: /usr/lib64/qt5/plugins/kf5/overlayicon, /usr/lib64/qt5/plugins/kf5/kfileitemaction
%dir /usr/lib64/qt5/plugins/kf5/overlayicon %dir /usr/lib64/qt5/plugins/kf5/kfileitemaction
This minor issue can be fixed during import. Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2183018
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/kommit
https://bugzilla.redhat.com/show_bug.cgi?id=2183018
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-03-31 06:04:33
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com