[Bug 2116065] New: Review Request: rust-primal-check - Fast standalone primality testing
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
Bug ID: 2116065 Summary: Review Request: rust-primal-check - Fast standalone primality testing Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: orion@nwra.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://orion.fedorapeople.org/rust-primal-check.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-check-0.3.1-1.fc37.src.rpm Description:
Fast standalone primality testing.
Fedora Account System Username: orion
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=90541823
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2116083
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2116083 [Bug 2116083] Review Request: rust-primal - `primal` puts raw power into prime numbers
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2116092
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2116092 [Bug 2116092] Review Request: rust-rustfft - High-performance FFT library written in pure Rust
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |decathorpe@gmail.com
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- c.f. https://bugzilla.redhat.com/show_bug.cgi?id=2116066#c1
Additionally, this:
%files %license LICENSE-*
will result in the license files getting installed into the buildroot twice (once in %{crate_instdir}, once in %{_licensedir}). Use this instead (which matches what rust2rpm will generate):
%files %license %{crate_instdir}/LICENSE-Apache %license %{crate_instdir}/LICENSE-MIT
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
--- Comment #2 from Orion Poplawski orion@nwra.com --- Should be fixed now
Spec URL: https://orion.fedorapeople.org/rust-primal-check.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-check-0.3.1-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
--- Comment #3 from Orion Poplawski orion@nwra.com --- Upstream now provides the license files.
Spec URL: https://orion.fedorapeople.org/rust-primal-check.spec SRPM URL: https://orion.fedorapeople.org/rust-primal-check-0.3.2-1.fc38.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Looks good to me!
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (tests disabled to break dependency loop) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Two non-blocking comments:
1. Please make sure to regenerate .spec files with rust2rpm for *every* new version.
For example, this line is no longer correct: # Upstream license specification: MIT/Apache-2.0 As the upstream crate metadata has updated the license string to use "OR" instead of the deprecated "/" SPDX syntax.
If you don't re-run rust2rpm for new versions, it can result in broken packages (for example, if features or optional dependencies change, the generated subpackages for those features / optional dependencies will be outdated, and will have broken dependencies, or will be missing).
2. Make sure you don't "fedpkg import" the SRPM file that you uploaded for this review. It was already munged by rpmautospec.
PS: I tend to build SRPM files for review requests with "rpmbuild -bs", which doesn't expand those macros, and creates SRPM files that are safe to be imported with "fedpkg import".
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
--- Comment #6 from Orion Poplawski orion@nwra.com --- Thanks for the pointers, I'll try to remember them.
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
--- Comment #7 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-primal-check
https://bugzilla.redhat.com/show_bug.cgi?id=2116065
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Fixed In Version| |rust-primal-check-0.3.2-1.f | |c38 Resolution|--- |RAWHIDE Last Closed| |2022-10-01 02:29:17
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com