Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202876
Summary: Review Request: perl-Data-Alias Product: Fedora Extras Version: devel Platform: All URL: http://search.cpan.org/dist/Data-Alias/ OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: fedora-package-review@redhat.com
SRPM URL: http://home.comcast.net/~ckweyl/perl-Data-Alias-1.0-1.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-Data-Alias.spec
Description: Aliasing is the phenomenon where two different expressions actually refer to the same thing. Modifying one will modify the other, and if you take a reference to both, the two values are the same.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Alias
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202876
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |163776 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Alias
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202876
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Alias
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202876
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-08-17 20:38 EST ------- You should be careful with that method of requires filtering, because there's no guarantee that __perl_provides will always be /usr/lib/rpm/perl.prov. The safest method is detailed in http://fedoraproject.org/wiki/Packaging/Perl.
That said, many modules do use it and it is relatively simple.
Other than that there's not much to say.
* source files match upstream: 390fc2fefbf3fa9bf30d482a46989953 Data-Alias-1.0.tar.gz * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: Alias.so()(64bit) perl(Data::Alias) = 1.0 perl-Data-Alias = 1.0-1.fc6 = perl(:MODULE_COMPAT_5.8.8) perl(Data::Alias) = 1.0 perl(DynaLoader) perl(Exporter) * %check is present and all tests pass: All tests successful, 1 test skipped. Files=26, Tests=561, 1 wallclock secs ( 0.78 cusr + 0.25 csys = 1.03 CPU) The skipped test checks for the //= operator and won't run otherwise; I think that's a Perl6 thing.
* no shared libraries are added to the regular linker search paths. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Alias
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202876
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From cweyl@alumni.drew.edu 2006-08-17 21:36 EST ------- +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-5) +Close bug
Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Alias Alias: perl-Data-Alias
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202876
cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |perl-Data-Alias
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Data-Alias Alias: perl-Data-Alias
https://bugzilla.redhat.com/show_bug.cgi?id=202876
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=202876
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag| |fedora-cvs?
--- Comment #3 from Iain Arnell iarnell@gmail.com 2010-08-25 01:40:14 EDT --- Package Change Request ====================== Package Name: perl-Data-Alias New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=202876
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2010-08-25 13:09:38 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=202876
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE | AssignedTo|tibbs@math.uh.edu |nobody@fedoraproject.org Summary|Review Request: |Review Request: |perl-Data-Alias |perl-Data-Alias - | |Comprehensive set of | |aliasing operations Flag|fedora-cvs+ | Keywords| |Reopened
--- Comment #5 from Marcela Mašláňová mmaslano@redhat.com 2011-04-14 06:17:43 EDT --- I'd like to re-review this package, because it was already orphaned. Now upstream live again and they provided new version compatible with 5.12.x Perl and higher.
I believe work on it in same ticket make sense, but I can not change reporter, which should be me.
SPEC: http://mmaslano.fedorapeople.org/review/perl-Data-Alias.spec SRPM: http://mmaslano.fedorapeople.org/review/perl-Data-Alias-1.12-1.fc14.src.rpm Description: Aliasing is the phenomenon where two different expressions actually refer to the same thing. Modifying one will modify the other, and if you take a reference to both, the two values are the same.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=202876
--- Comment #6 from Jason Tibbitts tibbs@math.uh.edu 2011-04-14 09:15:31 EDT --- Generally it makes far more sense to simply open your own review ticket. You can close this one as a duplicate.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=202876
Marcela Mašláňová mmaslano@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DUPLICATE Last Closed|2006-08-17 21:36:11 |2011-04-18 03:50:21
--- Comment #7 from Marcela Mašláňová mmaslano@redhat.com 2011-04-18 03:50:21 EDT ---
*** This bug has been marked as a duplicate of bug 697411 ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla