https://bugzilla.redhat.com/show_bug.cgi?id=2181025
Bug ID: 2181025 Summary: Review Request: rust-linux-loader - Linux kernel image loading crate Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora.dm0@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-linux-loader.spec SRPM URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-linux-loader-0.8.1-... Description: A Linux kernel image loading crate. Fedora Account System Username: dm0
This is a dependency of Firecracker. The spec is automatically generated, except to add a patch to drop criterion (for benchmarks, unused). Note that the crate's defined license is not what was intended upstream, and they are still working on it: https://github.com/rust-vmm/linux-loader/issues/136
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/li | |nux-loader
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5696252 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please make sure the package builds successfully at least for Fedora Rawhide.
- If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Status|NEW |ASSIGNED Depends On| |2118751 Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package doesn't build in rawhide: The vm-memory v0.10.0 update is missing from rawhide.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2118751 [Bug 2118751] rust-vm-memory-0.10.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #3 from fedora.dm0@gmail.com --- I've updated this package to drop CODEOWNERS and coverage_config* files and to flag additional files as documentation.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- 1. Please also add the "/doc/" directory to the list of excluded files instead of marking it as %doc.
We don't ship any documentation for Rust packages (we also don't run rustdoc, for example), since they never end up on either end users' or even packagers' machines, and are only installed in temporary build environments.
2. Please add a short comment about what the patch does, i.e. something like
# * drop files that are only useful for upstream development # * prevent documentation from being installed # * remove unused, benchmark-only criterion dev-dependency
https://bugzilla.redhat.com/show_bug.cgi?id=2181025 Bug 2181025 depends on bug 2118751, which changed state.
Bug 2118751 Summary: rust-vm-memory-0.10.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=2118751
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #5 from fedora.dm0@gmail.com --- The spec and SRPM are updated to exclude docs and add comments.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #6 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0 AND BSD-3-Clause) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
Looks good to me.
According to the ticket linked in the initial comment, it seems the license of this crate should be "(Apache-2.0 OR BSD-3-Clause) AND BSD-3-Clause" as well? Either way, the current license string is "Apache-2.0 AND BSD-3-Clause", which should be fine for now (just with "less details") - and license texts for both licenses are included as well.
Just include a comment with the link to the upstream issue in the spec file, so we don't forget about it. # https://github.com/rust-vmm/linux-loader/issues/136
===
Note that the crate does not seem to build correctly across all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=99237932
- x86_64: builds, tests pass - aarch64: builds, tests pass - i686: builds, some tests fail (harmless failures in tests generated by bindgen) - s390x: builds, some tests pass, some doctests fail to compile - s390x: builds, some tests pass, some doctests fail to compile
If I remember correctly, you said that firecracker is only supported on x86_64 and aarch64? If that is the case, I would add "ExclusiveArch: x86_64 aarch64" to this package, with a comment that firecracker only supports these architectures.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #8 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-linux-loader
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-493feaccd3 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-493feaccd3
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-03-28 15:21:05
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-493feaccd3 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-02106a6c13 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a4085b6295 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 testing repository.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-02106a6c13
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a4085b6295 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a4085b6295
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a4085b6295 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2181025
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-02106a6c13 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com