Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: tabish-eeyek-fonts - Font for Meetei Mayek script
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Summary: Review Request: tabish-eeyek-fonts - Font for Meetei Mayek script Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pnemade@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/tabish-eeyek-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/tabish-eeyek-fonts-1.0-1.fc... Description: A TrueType Font, which allows you to read and write in Meetei Mayek script.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #1 from Parag pnemade@redhat.com 2011-04-27 05:07:30 EDT --- koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3029168
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mariobl@freenet.de
--- Comment #2 from Mario Blättermann mariobl@freenet.de 2011-04-27 07:38:42 EDT --- $ rpmlint -v * tabish-eeyek-fonts.src: I: checking tabish-eeyek-fonts.src: I: checking-url http://tabish.freeshell.org/eeyek/ (timeout 10 seconds) tabish-eeyek-fonts.src: I: checking-url http://tabish.freeshell.org/eeyek/eeyek.zip (timeout 10 seconds) tabish-eeyek-fonts.noarch: I: checking tabish-eeyek-fonts.noarch: I: checking-url http://tabish.freeshell.org/eeyek/ (timeout 10 seconds) tabish-eeyek-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/tabish-eeyek-fonts-1.0/copying.txt tabish-eeyek-fonts.spec: I: checking-url http://tabish.freeshell.org/eeyek/eeyek.zip (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings.
Looks good in general. The issue with the line endings can be solved with a "sed" command:
http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #3 from Parag pnemade@redhat.com 2011-04-28 01:16:48 EDT --- Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/tabish-eeyek-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/tabish-eeyek-fonts-1.0-1.fc...
koji scratch build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3031898
package is not bumped here.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #4 from Mario Blättermann mariobl@freenet.de 2011-04-28 10:12:29 EDT --- Created attachment 495552 --> https://bugzilla.redhat.com/attachment.cgi?id=495552 Change the FSF postal address to the current one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #5 from Mario Blättermann mariobl@freenet.de 2011-04-28 10:13:12 EDT --- $ rpmlint -v * ... tabish-eeyek-fonts.noarch: E: incorrect-fsf-address /usr/share/doc/tabish-eeyek-fonts-1.0/copying.txt ... 2 packages and 1 specfiles checked; 1 errors, 0 warnings.
The license blurb still contains the old FSF address, the new one is:
Free Software Foundation 51 Franklin Street, Suite 500 Boston, MA 02110-1335 USA
Apply the attached patch please.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Martin Gieseking martin.gieseking@uos.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@uos.de
--- Comment #6 from Martin Gieseking martin.gieseking@uos.de 2011-04-28 10:22:18 EDT --- No, please don't change any files if it's not required to fix build problems. Instead, ask upstream to apply the patch. Until then, just add the original license file with the old address.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Mario Blättermann mariobl@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mariobl@freenet.de Flag| |fedora-review+
--- Comment #7 from Mario Blättermann mariobl@freenet.de 2011-04-28 15:44:40 EDT --- (In reply to comment #6)
No, please don't change any files if it's not required to fix build problems. Instead, ask upstream to apply the patch. Until then, just add the original license file with the old address.
OK, besides the wrong address I can't find any other issues.
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPLv2+ [+] MUST: The License field in the package spec file must match the actual license. [+] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * aedf4633caf5e7e2ccee24e9421085b5 eeyek.zip aedf4633caf5e7e2ccee24e9421085b5 eeyek.zip.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [.] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts.
----------------
PACKAGE APPROVED
----------------
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #8 from Parag pnemade@redhat.com 2011-04-29 05:06:42 EDT --- Thanks for the review!
New Package SCM Request ======================= Package Name: tabish-eeyek-fonts Short Description: Font for Meetei Mayek script Owners: pnemade Branches: f15 InitialCC: i18n-team fonts-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #9 from Jason Tibbitts tibbs@math.uh.edu 2011-04-30 14:12:34 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-05-03 00:39:01 EDT --- tabish-eeyek-fonts-1.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/tabish-eeyek-fonts-1.0-1.fc15
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-05-05 00:41:42 EDT --- tabish-eeyek-fonts-1.0-1.fc15 has been pushed to the Fedora 15 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-06-03 22:56:27 EDT --- tabish-eeyek-fonts-1.0-1.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=699586
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |tabish-eeyek-fonts-1.0-1.fc | |15 Resolution| |ERRATA Last Closed| |2011-06-03 22:56:32
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla