[Bug 525453] New: Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: yum-rhn-plugin - RHN support for yum
Alias: yum-rhn-plugin

https://bugzilla.redhat.com/show_bug.cgi?id=525453

Summary: Review Request: yum-rhn-plugin - RHN support for yum
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
            Blocks: 452450
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

SPEC: 
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin.spec
SRPM:
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin-0.7.2-1.src.rp...

Description:
This yum plugin provides support for yum to access a Red Hat Network server for
software updates.

rpmlint is silent

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1703680

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

Thomas Janssen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Thomas Janssen   2009-09-26 13:44:16 EDT ---
Hi,

Source Url is missing.  If no upstream URL can be specified for this package,
please see the http://fedoraproject.org/wiki/Packaging/SourceURL  for how to
deal with this.

rpmlint must be run on every package. The output should be posted in the
review.
Not sure if "rpmlint is silent" counts here :)

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #2 from Dennis Gilmore   2009-09-27 11:40:45 EDT ---
Obsoletes: up2date < 5.0.0
Provides: up2date = %{version}
this  is wrong  sinve version is less that what is obsoleted

the Provides should be 5.0.0

%files section should be much cleaner

%clean should just be 
rm -rf $RPM_BUILD_ROOT

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #3 from Miroslav Suchý   2009-09-29 02:43:05 EDT ---
Updated.
SPEC: 
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin.spec
SRPM:
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin-0.7.3-1.src.rp...

I addressed comment #1 and #2, but "%files section should be much cleaner". Not
should what you exactly mean Dennis. Seem sane to me.

rpmlint is silent:
[msuchy@dri/~/rhn/spacewalk.pub/client/rhel/yum-rhn-plugin]$ rpmlint
/tmp/spacewalk-build/rpmbuild-yum-rhn-plugin-0.7.3-1/yum-rhn-plugin-0.7.3-1.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[msuchy@dri/~/rhn/spacewalk.pub/client/rhel/yum-rhn-plugin]$ rpmlint
/tmp/spacewalk-build/rpmbuild-yum-rhn-plugin-0.7.3-1/noarch/yum-rhn-plugin-0.7.3-1.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #4 from Thomas Janssen   2009-09-29 04:30:23 EDT ---
"%files section should be much cleaner" like:

%{_mandir}/man*/*
%{_datadir}/yum-plugins/*
%{_datadir}/rhn/*/*

I'm not sure if there's a new version out. If not, you're supposed to bump the
release, not the version. Well if you're the developer, i guess it's up to you
then.
I can only guess since there's no README, AUTHORS, COPYING in the source
tarball.

Would be nice if you do a koji --scratch run and post the Task-info link in
here.
koji build --scratch dist-f12 path/to/srpm

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #5 from Thomas Janssen   2009-09-29 04:33:39 EDT ---
Erm.. Sorry, the scratch build is already there. /me seems to need glasses.

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #6 from Miroslav Suchý   2009-09-29 04:51:39 EDT ---
Updated.
SPEC: 
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin.spec
SRPM:
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin-0.7.4-1.src.rp...

I bumped version (and not release), because I'm one of the Spacewalk developers
and I made the change in upstream and released new version of this package.

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #7 from Thomas Janssen   2009-09-29 05:43:54 EDT ---
Heh, took me a while to find the reason for the version bump. You make it
because you include the spec file in the tarball. Interesting.
The spec is anyways in the SRPM but i think you have your reason to keep a copy
in the tarball.

So, if it's fine to have a package without a license copy, then i cant find
anything further.

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #8 from Miroslav Suchý   2009-09-30 03:30:03 EDT ---
Yeah, it is "feature" of our release system. But otherwise it is really easy to
work with.

Inclusion of license copy is "only" SHOULD item. But if you give me big plus in
flag I'll give you LICENSE file :)

SPEC: 
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin.spec
SRPM:
http://miroslav.suchy.cz/fedora/yum-rhn-plugin/yum-rhn-plugin-0.7.5-1.src.rp...

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

Thomas Janssen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review+

--- Comment #9 from Thomas Janssen   2009-09-30 06:24:45 EDT ---
Approved

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #10 from Miroslav Suchý   2009-09-30 07:45:43 EDT ---
New Package CVS Request
=======================
Package Name: yum-rhn-plugin
Short Description: RHN support for yum
Owners: msuchy
Branches: F-11, F-12
InitialCC:

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #11 from Kevin Fenzi   2009-09-30 19:08:23 EDT ---
cvs done.

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

--- Comment #12 from Thomas Janssen   2009-10-01 01:48:26 EDT ---
Found one last thing. You have a single comment in your source code
"Distributed under GPL" (in packages.py). Could you change that to what you
reference in the spec file "GPLv2".
Thanks.

[Bug 525453] Review Request: yum-rhn-plugin - RHN support for yum

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=525453

Miroslav Suchý  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #13 from Miroslav Suchý   2009-10-01 03:30:34 EDT ---
Good catch. Changed.