https://bugzilla.redhat.com/show_bug.cgi?id=1816457
Bug ID: 1816457 Summary: Review Request: ocaml-mlmpfr - OCaml bindings for MPFR Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: loganjerry@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://jjames.fedorapeople.org/ocaml-mlmpfr/ocaml-mlmpfr.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-mlmpfr/ocaml-mlmpfr-4.0.2-1.fc33.src.r... Fedora Account System Username: jjames Description: This library provides OCaml bindings for MPFR.
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |vascom2@gmail.com Assignee|nobody@fedoraproject.org |vascom2@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
--- Comment #1 from Vasiliy Glazov vascom2@gmail.com --- It is normal that unversioned .so file not in devel subpackage?
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
--- Comment #2 from Vasiliy Glazov vascom2@gmail.com --- Review is ready if you answer the question.
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
--- Comment #3 from Jerry James loganjerry@gmail.com --- Do you mean the .so in the stublibs directory? Yes, that is normal. That shared object is to support the bytecode version of this library. You can see similar .so files in packages such as ocaml-runtime and ocaml-lablgtk.
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
Vasiliy Glazov vascom2@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Vasiliy Glazov vascom2@gmail.com --- Approved.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v3 or later)", "Unknown or generated", "*No copyright* GNU Lesser General Public License (v3 or later)". 16 files have unknown license. Detailed output of licensecheck in /home/vascom/1816457-ocaml-mlmpfr/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Ocaml: [x]: This should never happen
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: ocaml-mlmpfr-4.0.2-1.fc33.x86_64.rpm ocaml-mlmpfr-devel-4.0.2-1.fc33.x86_64.rpm ocaml-mlmpfr-doc-4.0.2-1.fc33.noarch.rpm ocaml-mlmpfr-debuginfo-4.0.2-1.fc33.x86_64.rpm ocaml-mlmpfr-debugsource-4.0.2-1.fc33.x86_64.rpm ocaml-mlmpfr-4.0.2-1.fc33.src.rpm ocaml-mlmpfr-devel.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (debuginfo) ------------------- Checking: ocaml-mlmpfr-debuginfo-4.0.2-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). ocaml-mlmpfr-devel.x86_64: W: invalid-url URL: https://github.com/thvnx/mlmpfr <urlopen error [Errno -2] Name or service not known> ocaml-mlmpfr-devel.x86_64: W: no-documentation ocaml-mlmpfr-debugsource.x86_64: W: invalid-url URL: https://github.com/thvnx/mlmpfr <urlopen error [Errno -2] Name or service not known> ocaml-mlmpfr.x86_64: W: invalid-url URL: https://github.com/thvnx/mlmpfr <urlopen error [Errno -2] Name or service not known> ocaml-mlmpfr-doc.noarch: W: invalid-url URL: https://github.com/thvnx/mlmpfr <urlopen error [Errno -2] Name or service not known> ocaml-mlmpfr-debuginfo.x86_64: W: invalid-url URL: https://github.com/thvnx/mlmpfr <urlopen error [Errno -2] Name or service not known> 5 packages and 0 specfiles checked; 0 errors, 6 warnings.
Unversioned so-files -------------------- ocaml-mlmpfr: /usr/lib64/ocaml/stublibs/dllmlmpfr_stubs.so
Source checksums ---------------- https://github.com/thvnx/mlmpfr/archive/mlmpfr.4.0.2-dune.tar.gz : CHECKSUM(SHA256) this package : 89a2f29136a925264723a4a568e4d0769ceaf75027d57106e63de3c273b3f1b6 CHECKSUM(SHA256) upstream package : 89a2f29136a925264723a4a568e4d0769ceaf75027d57106e63de3c273b3f1b6
Requires -------- ocaml-mlmpfr (rpmlib, GLIBC filtered): libc.so.6()(64bit) libmpfr.so.6()(64bit) ocaml(CamlinternalFormatBasics) ocaml(Stdlib) ocaml(Stdlib__buffer) ocaml(Stdlib__callback) ocaml(Stdlib__char) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__string) ocaml(Stdlib__uchar) ocaml(runtime) rtld(GNU_HASH)
ocaml-mlmpfr-devel (rpmlib, GLIBC filtered): ocaml-mlmpfr(x86-64)
ocaml-mlmpfr-doc (rpmlib, GLIBC filtered):
ocaml-mlmpfr-debuginfo (rpmlib, GLIBC filtered):
ocaml-mlmpfr-debugsource (rpmlib, GLIBC filtered):
Provides -------- ocaml-mlmpfr: ocaml(Mpfr) ocaml-mlmpfr ocaml-mlmpfr(x86-64)
ocaml-mlmpfr-devel: ocaml-mlmpfr-devel ocaml-mlmpfr-devel(x86-64)
ocaml-mlmpfr-doc: ocaml-mlmpfr-doc
ocaml-mlmpfr-debuginfo: debuginfo(build-id) ocaml-mlmpfr-debuginfo ocaml-mlmpfr-debuginfo(x86-64)
ocaml-mlmpfr-debugsource: ocaml-mlmpfr-debugsource ocaml-mlmpfr-debugsource(x86-64)
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1816457 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Ocaml, Shell-api Disabled plugins: Haskell, Perl, fonts, PHP, SugarActivity, Java, Python, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
--- Comment #5 from Jerry James loganjerry@gmail.com --- Thank you for the review, Vasiliy! I appreciate it.
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-mlmpfr
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f58331b1ac has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-f58331b1ac
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f58331b1ac has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-f58331b1ac *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f58331b1ac
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1816457
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-04-02 00:31:39
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-f58331b1ac has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com