https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Bug ID: 1366277 Summary: python-py-gfm - Github-Flavored Markdown for Python-Markdown Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: germano.massullo@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
spec file: https://germano.fedorapeople.org/package_reviews/python-py-gfm/python-py-gfm... srpm file: https://germano.fedorapeople.org/package_reviews/python-py-gfm/python-py-gfm... FAS name: germano
message to the package reviewer: I have a dubt about the BSD license, because the license is BSD style. More details in the spec file comments
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Germano Massullo germano.massullo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |Dependency of | |https://github.com/digitalo | |cean/netbox
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- I'd suggest: %global _description \ This is an implementation of GitHub-Flavored Markdown written as an extension \ ...
%description %_description %description -n python2-%{pypi_name} %_description ...
I'm not sure about the name: python-py-* suggests that this has something to do with py.test and python-py. Maybe the name should just be python-gfm? This matches the module name too.
? package name is OK + license is acceptable (BSD 3-clause) + license is specified correctly + latest version is packaged + modern python packaging template is used + %python_provide macro is used + P/R/BR look correct + no scriptlets necessary + %check is present + builds and installs OK + fedora-review and rpmlint are happy
rpmlint: python-py-gfm.src: E: description-line-too-long C to the Python Markdown library. It aims for maximal compatibility with GitHub's rendering.
OK, looks good, only thing is the name, maybe.
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #2 from Germano Massullo germano.massullo@gmail.com --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
I'm not sure about the name: python-py-* suggests that this has something to do with py.test and python-py. Maybe the name should just be python-gfm? This matches the module name too.
even netbox names it with "py" prefix https://github.com/digitalocean/netbox/blob/develop/requirements.txt#L15 Perhaps we should ask to py-gfm upstream developers?
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Germano Massullo from comment #2)
even netbox names it with "py" prefix https://github.com/digitalocean/netbox/blob/develop/requirements.txt#L15
I don't think that matters. The names in requirements.txt is completely independent of the Fedora package name. We add python- prefix anyway.
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Germano Massullo germano.massullo@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|python-py-gfm - |python-gfm - |Github-Flavored Markdown |Github-Flavored Markdown |for Python-Markdown |for Python-Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #4 from Germano Massullo germano.massullo@gmail.com --- https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm.spec
https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm-0.1.3...
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #5 from Germano Massullo germano.massullo@gmail.com --- I have also edited the paths. You may want to check them again. rpmbuild -ba worked fine
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- # to do: check if py-gfm BSD style license is compliant to BSD license → it is, you can remove this comment
Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #7 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- rpmlint: python2-gfm.noarch: E: description-line-too-long C to the Python Markdown library. It aims for maximal compatibility with GitHub's rendering.
Please wrap to 80 columns ;)
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #8 from Germano Massullo germano.massullo@gmail.com --- Files updated as requested
https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm.spec
https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm-0.1.3...
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-gfm
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-336acf2def
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d68bd1607d
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-84dce5e362
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6afe4007a6
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6afe4007a6
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-84dce5e362
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-336acf2def
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d68bd1607d
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-08-27 06:19:15
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1366277
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- python-gfm-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org