Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226414
Summary: Merge Review: sg3_utils Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: pknirsch@redhat.com
Fedora Merge Review: sg3_utils
http://cvs.fedora.redhat.com/viewcvs/devel/sg3_utils/ Initial Owner: pknirsch@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sg3_utils
https://bugzilla.redhat.com/show_bug.cgi?id=226414
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
denis@poolshark.org changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |denis@poolshark.org
------- Additional Comments From denis@poolshark.org 2008-03-10 07:39 EST ------- sg3_utils needs some love. Spec is not fedora compliant (static libs, .la libs). It also could use an update to 1.25 which uses automake and will make the spec file simpler. 1.25 also introduces the very useful 'sg_raw' utility.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sg3_utils
https://bugzilla.redhat.com/show_bug.cgi?id=226414
------- Additional Comments From pknirsch@redhat.com 2008-03-20 15:01 EST ------- Will take care of it next week.
Read ya, Phil
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sg3_utils
https://bugzilla.redhat.com/show_bug.cgi?id=226414
pknirsch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?(denis@poolshark.or | |g)
------- Additional Comments From pknirsch@redhat.com 2008-03-27 10:30 EST ------- Ok, did some final cleanups to the specfile and removed the static libraries. The remaining rpmlint warnings are either not fixable or plainly wrong for this package (libs package doesn't contain any documentation and sg3_utils-devel only needs the sg3_utils-libs package to work properly).
Building sg3_utils-1.25-3 in rawhide as i write this, so should land in the next couple of days in the tree.
Let me know if there is anything else you see that should be changed.
Thanks,
Read ya, Phil
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sg3_utils
https://bugzilla.redhat.com/show_bug.cgi?id=226414
denis@poolshark.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(denis@poolshark.or|fedora-review+ |g) |
------- Additional Comments From denis@poolshark.org 2008-03-28 06:21 EST ------- Looking good. couple of minor non-blocking nitpicks
- is the "Provides: sg_utils' still useful ?
- instead of removing the *.a files, simply configure with '--disable-static' (you still need to keep the removal of *.la files though).
This review is APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sg3_utils
https://bugzilla.redhat.com/show_bug.cgi?id=226414
denis@poolshark.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: sg3_utils
https://bugzilla.redhat.com/show_bug.cgi?id=226414
------- Additional Comments From pknirsch@redhat.com 2008-03-28 10:07 EST ------- I just figured i'd keep the Provides in, but i checked today once more and we never actually shipped sg_utils in Fedora or Red Hat, so i'll just drop it.
And good point about the 2nd thing, will add that in the new build as well.
Thanks Denis!
Read ya, Phil
package-review@lists.fedoraproject.org