https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Bug ID: 2283586 Summary: Review Request: rust-cmd_lib - Common rust commandline macros and utils for shell script like tasks Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: davide@cavalca.name QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib-1.9.4-1.f...
Description: Common rust commandline macros and utils, to write shell script like tasks easily.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2283585 Doc Type|--- |If docs needed, set a value
--- Comment #1 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [package] summary = "Common rust commandline macros and utils for shell script like tasks"
[requires] test = ["procps-ng"]
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283585 [Bug 2283585] Review Request: rust-cmd_lib_macros - Common rust commandline macros and utils for shell script like tasks
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Davide Cavalca davide@cavalca.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2283588
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2283588 [Bug 2283588] Review Request: rust-sealed_test - Procmacro attribute to run your test in an isolated environment
https://bugzilla.redhat.com/show_bug.cgi?id=2283586 Bug 2283586 depends on bug 2283585, which changed state.
Bug 2283585 Summary: Review Request: rust-cmd_lib_macros - Common rust commandline macros and utils for shell script like tasks https://bugzilla.redhat.com/show_bug.cgi?id=2283585
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- The package contains two files that are under a different license (WTFPL): examples/tetris.{sh,rs}. The easiest solution would probably be to drop these two from the -devel file.
Note that the dependencies of this crate are also pretty old. For example, structopt depends on clap v2, and has been obsolete since clap v3.
Maybe this crate can be ported to newer dependencies upstream? env_logger 0.10 -> 0.12, byte-unit 4 -> 5, structopt -> clap 4
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
--- Comment #3 from Davide Cavalca davide@cavalca.name --- Spec URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-cmd_lib/rust-cmd_lib-1.9.4-1.f...
Changelog: - drop examples under WTFPL
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
--- Comment #4 from Davide Cavalca davide@cavalca.name --- $ cat rust2rpm.toml [package] summary = "Common rust commandline macros and utils for shell script like tasks"
[requires] test = ["procps-ng"]
[scripts] # Remove examples under a different license prep.pre = ["rm examples/tetris.{sh,rs}"]
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks good to me now!
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cmd_lib
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-b0efeadecb (rust-cmd_lib-1.9.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b0efeadecb
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-07-06 00:11:27
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-b0efeadecb (rust-cmd_lib-1.9.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-41097de1cd (rust-cmd_lib-1.9.4-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-41097de1cd
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-150f5cd528 (rust-cmd_lib-1.9.4-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-150f5cd528
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-150f5cd528 (rust-cmd_lib-1.9.4-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2283586
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-41097de1cd (rust-cmd_lib-1.9.4-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org