[Bug 958006] New: Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Bug ID: 958006
           Summary: Review Request: zanata-common - zanata common modules
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail],
                    [e-mail]
          Category: ---

Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec
SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-1.fc17.src.rpm
Description: 
Zanata common modules including various l10n file readers and writers
Fedora Account System Username: pahuang

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #1 from Patrick Huang  ---
f19 build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5316649

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #2 from Patrick Huang  ---
Tested under f18. Need to make a change.
Koji build:http://koji.fedoraproject.org/koji/taskinfo?taskID=5319907

Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec
SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-2.fc17.src.rpm

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Ding-Yi Chen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #3 from Ding-Yi Chen  ---
Following error occurred when building with rawhide (f20):

Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.Qoqk6d
+ umask 022
+ cd /builddir/build/BUILD
+ cd zanata-common-common-2.2.1
+ mvn-build
Exception in thread "main" java.lang.NoClassDefFoundError:
org/sonatype/aether/transfer/AbstractTransferListener
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:791)
    at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
    at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
    at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClassFromSelf(ClassRealm.java:386)
    at
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:42)
    at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244)
    at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230)
    at java.lang.Class.getDeclaredMethods0(Native Method)
    at java.lang.Class.privateGetDeclaredMethods(Class.java:2451)
    at java.lang.Class.getMethod0(Class.java:2694)
    at java.lang.Class.getMethod(Class.java:1622)
    at
org.codehaus.plexus.classworlds.launcher.Launcher.getEnhancedMainMethod(Launcher.java:173)
    at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:269)
    at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
    at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:414)
    at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:357)
Caused by: java.lang.ClassNotFoundException:
org.sonatype.aether.transfer.AbstractTransferListener
    at
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
    at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:244)
    at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:230)
    ... 22 more
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.Qoqk6d (%build)
    Bad exit status from /var/tmp/rpm-tmp.Qoqk6d (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/zanata-common.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/mockbuild/trace_decorator.py", line
70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.6/site-packages/mockbuild/util.py", line 359, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n #
%s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps
builddir/build/SPECS/zanata-common.spec']
LEAVE do --> EXCEPTION RAISED

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #4 from Patrick Huang  ---
works for me locally and in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=5323356

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #5 from Ding-Yi Chen  ---
Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

javadoc sub package cannot be installed. Please remove %{?_isa} from
  Requires:       %{name}%{?_isa} = %{version}-%{release}

Because %{?_isa} is for indicating dependency should be arch-specific,
  which is not for noarch packages.

- Packages have proper BuildRequires/Requires on jpackage-utils
  See: https://fedoraproject.org/wiki/Packaging:Java

BuildRequires: java-devel is missing

- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No /usr/share/javadoc/zanata-common found
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation

All the javadoc should be placed under directory of
/usr/share/javadoc/zanata-common

- Package consistently uses macro is (instead of hard-coded directory names).
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

Choose either %{buildroot} or $RPM_BUILD_ROOT, they are the same thing.

- : License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in /home/dchen/958006-zanata-

Change license to LGPLv2+

Output of rpmlint
----------------------
1. zanata-common-javadoc.noarch: E: description-line-too-long C
zanata-common-util, zanatzanata-common-javadoc.noarch:

Use linebreak to split the description.

2. zanata-common.src:90: W: macro-in-comment %setup
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

zanata-common.src:90: W: macro-in-comment %{name}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

zanata-common.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab:
line 21)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

Regards,

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #6 from Patrick Huang  ---
Re point 2:
# BR java-devel only if you need specific version
# otherwise, java-devel will be pulled in automatically by maven-local
[BuildRequires: java-devel >= java version]

Fixed other issues
Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec
SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-3.fc17.src.rpm

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #7 from Ding-Yi Chen  ---
Two minor issues from rpmlint:

1. zanata-common.src:92: W: macro-in-comment %setup
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

Remove the comment if it is no longer needed.

2. zanata-common.src:21: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab:
line 21)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

Replace tabs in line 21 of zanata-common.spec with spaces.

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #8 from Patrick Huang  ---
Fixed.

Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec
SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-4.fc17.src.rpm

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #9 from Ding-Yi Chen  ---
There is still 
zanata-common.src:28: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab:
line 28)

Please either :
rpmlint -i zanata-common.spec

or editor that show tabs to locate and remove the rest of tabs.

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #10 from Patrick Huang  ---
Fixed
Spec URL: http://fedorapeople.org/~pahuang/zanata-common.spec
SRPM URL: http://fedorapeople.org/~pahuang/zanata-common-2.2.1-5.fc17.src.rpm

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Ding-Yi Chen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]            |[e-mail]
              Flags|                            |fedora-review+

--- Comment #11 from Ding-Yi Chen  ---

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Packages have proper BuildRequires/Requires on jpackage-utils
  See: https://fedoraproject.org/wiki/Packaging:Java
- Spec file lacks Packager, Vendor, PreReq tags.
  Note: Found : Packager: Ding-Yi Chen  Found : Vendor: Red
  Hat, Inc.
  See: (this test has no URL)

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zanata-
     common-javadoc
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "LGPL (v2.1 or later)", "Unknown or generated". 2 files have unknown
     license. Detailed output of licensecheck in /home/dchen/958006-zanata-
     common/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 51200 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: Pom files have correct add_maven_depmap call
     Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

Java:
[x]: Package has BuildArch: noarch (if possible)
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: zanata-common-2.2.1-5.fc17.noarch.rpm
          zanata-common-javadoc-2.2.1-5.fc17.noarch.rpm
zanata-common-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java
docs, Java-docs, Avocados
zanata-common-javadoc.noarch: W: spelling-error %description -l en_US
submodules -> sub modules, sub-modules, modules
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint zanata-common zanata-common-javadoc
zanata-common-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -> Java
docs, Java-docs, Avocados
zanata-common-javadoc.noarch: W: spelling-error %description -l en_US
submodules -> sub modules, sub-modules, modules
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

Requires
--------
zanata-common (rpmlib, GLIBC filtered):
    apache-commons-codec
    apache-commons-io
    apache-commons-lang
    guava
    jackson
    java
    jgettext
    jpackage-utils
    opencsv
    openprops
    slf4j
    zanata-api

zanata-common-javadoc (rpmlib, GLIBC filtered):
    jpackage-utils
    zanata-common

Provides
--------
zanata-common:
    mvn(org.zanata:common)
    mvn(org.zanata:zanata-adapter-glossary)
    mvn(org.zanata:zanata-adapter-po)
    mvn(org.zanata:zanata-adapter-properties)
    mvn(org.zanata:zanata-adapter-xliff)
    mvn(org.zanata:zanata-common-util)
    zanata-common

zanata-common-javadoc:
    zanata-common-javadoc

APPROVED

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Patrick Huang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #12 from Patrick Huang  ---
New Package SCM Request
=======================
Package Name: zanata-common
Short Description: Zanata common modules including various i18n file readers
and writers
Owners: pahuang seanf
Branches: f17 f18 f19 
InitialCC:

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |
              Flags|                            |fedora-cvs+

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #14 from Fedora Update System  ---
zanata-common-2.2.1-5.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/zanata-common-2.2.1-5.fc18

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #15 from Fedora Update System  ---
zanata-common-2.2.1-5.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/zanata-common-2.2.1-5.fc19

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #16 from Fedora Update System  ---
zanata-common-2.2.1-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/zanata-common-2.2.1-5.fc17

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #17 from Fedora Update System  ---
zanata-common-2.2.1-5.fc19 has been pushed to the Fedora 19 testing repository.

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |zanata-common-2.2.1-5.fc18
         Resolution|---                         |ERRATA
        Last Closed|                            |2013-05-15 13:28:40

--- Comment #18 from Fedora Update System  ---
zanata-common-2.2.1-5.fc18 has been pushed to the Fedora 18 testing repository.

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #19 from Fedora Update System  ---
zanata-common-2.2.1-5.fc18 has been pushed to the Fedora 18 stable repository.

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=958006

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|zanata-common-2.2.1-5.fc18  |zanata-common-2.2.1-5.fc17

--- Comment #20 from Fedora Update System  ---
zanata-common-2.2.1-5.fc17 has been pushed to the Fedora 17 stable repository.

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=958006

Ding-Yi Chen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs+                 |fedora-cvs-

--- Comment #21 from Ding-Yi Chen  ---
Package Change Request
======================
Package Name: zanata-common
New Branches: epel7
Owners: pahuang dchen

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=958006

Ding-Yi Chen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs-                 |fedora-cvs?

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=958006

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 958006] Review Request: zanata-common - zanata common modules

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=958006

--- Comment #22 from Jon Ciesla  ---
Git done (by process-git-requests).