Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226464
Summary: Merge Review: system-config-network Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: harald@redhat.com
Fedora Merge Review: system-config-network
http://cvs.fedora.redhat.com/viewcvs/devel/system-config-network/ Initial Owner: harald@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2007-09-28 11:37 EST ------- Need some SPEC cleanups as rpmlint gave me system-config-network.src:11: W: unversioned-explicit-obsoletes isdn-config system-config-network.src:11: W: unversioned-explicit-obsoletes internet-config system-config-network.src:11: W: unversioned-explicit-obsoletes rp3 system-config-network.src:11: W: unversioned-explicit-obsoletes redhat-config-network system-config-network.src:25: W: unversioned-explicit-obsoletes netcfg system-config-network.src:25: W: unversioned-explicit-obsoletes redhat-config-network-tui system-config-network.src:25: W: unversioned-explicit-obsoletes netconfig ==> The specfile contains an unversioned Obsoletes: token, which will match all older, equal and newer versions of the obsoleted thing. This may cause update problems, restrict future package/provides naming, and may match something it was originally not inteded to match -- make the Obsoletes versioned if possible.
system-config-network.src:26: W: unversioned-explicit-provides redhat-config-network-tui
==>The specfile contains an unversioned Provides: token, which will match all older, equal, and newer versions of the provided thing. This may cause update problems and will make versioned dependencies, obsoletions and conflicts on the provided thing useless -- make the Provides versioned if possible.
system-config-network.src: W: invalid-license GPL system-config-network.noarch: W: no-documentation system-config-network.noarch: W: no-dependency-on usermode system-config-network.noarch: E: explicit-lib-dependency libglade2 ==> You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags.
system-config-network.noarch: W: invalid-license GPL system-config-network.noarch: W: obsolete-not-provided isdn-config system-config-network.noarch: W: obsolete-not-provided internet-config system-config-network.noarch: W: obsolete-not-provided rp3 system-config-network-tui.noarch: W: no-documentation system-config-network-tui.noarch: E: non-executable-script /usr/share/system-config-network/netconfpkg/exception.py 0644 system-config-network-tui.noarch: W: invalid-license GPL ==> Update Licenst tag
system-config-network-tui.noarch: W: obsolete-not-provided netcfg system-config-network-tui.noarch: W: obsolete-not-provided netconfig ==> If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides.
Also, Good to use %defattr(-,root,root,-)
Update package. Better to provide new SPEC and SRPM links for this package before actually committing in CVS.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2007-10-16 01:21 EST ------- ping? any updates?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From harald@redhat.com 2007-10-16 07:49 EST ------- New specfile and src.rpm http://people.redhat.com/harald/downloads/system-config-network/system-confi...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2007-10-16 08:04 EST ------- Thanks for updates. With updated SRPM I got following rpmlint messages system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8 system-config-network.noarch: W: obsolete-not-provided rp3 system-config-network.src: W: strange-permission system-config-network.spec 0600
otherwise package looks ok.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From harald@redhat.com 2007-10-16 08:20 EST ------- system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8 - minor lazyness, b/c this is upstream and releases are normally not incremented
system-config-network.noarch: W: obsolete-not-provided rp3 - The rp3 interface is not provided, but rp3 is obsoleted nevertheless
system-config-network.src: W: strange-permission system-config-network.spec 0600 - will go away, if I build the package in the Fedora infrastructure (this was, make dist && rpm -ta <tarfile>)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-10-17 00:39 EST ------- Review: + package builds in mock (development i386). - rpmlint is Not silent for SRPM but Not for RPM. system-config-network.noarch: W: incoherent-version-in-changelog 1.4.4 1.4.4-1.fc8 => I hope you will take care this message while building package next time. system-config-network.noarch: W: obsolete-not-provided rp3 =>This messages can be ignored for this package. system-config-network.src: W: strange-permission system-config-network.spec 0600 => I hope you will take care this message while building package next time. + source files match upstream. 9566acdbecea85601ecc39c71a3e24fa system-config-network-1.4.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop files are handled correctly. + package system-config-network-1.4.4-1.fc8 -> Provides: internet-config = 0.40-2.1 isdn-config = 0.18-10.70.1 redhat-config-network = 1.4.4 Requires: /usr/bin/python gnome-python2 gnome-python2-canvas pygtk2 pygtk2-libglade system-config-network-tui = 1.4.4-1.fc8 usermode + package system-config-network-tui-1.4.4-1.fc8 -> Provides: config(system-config-network-tui) = 1.4.4-1.fc8 netcfg = 2.36-3p.1 netconf = 0.1-1.1 redhat-config-network-tui = 1.4.4 Requires: /bin/sh /usr/bin/python config(system-config-network-tui) = 1.4.4-1.fc8 initscripts >= 0:5.99 kudzu newt-python pciutils python rhpl >= 0:0.193 rpm-python usermode + GUI app.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2007-10-29 04:39 EST ------- ping? is the srpm given in comment #3 is built?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From harald@redhat.com 2007-10-29 06:46 EST ------- no, not yet, because F8 was closed
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2007-11-12 05:48 EST ------- Can we now import new SRPM in rawhide?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From harald@redhat.com 2007-11-12 07:11 EST ------- https://admin.fedoraproject.org/updates/F8/pending/system-config-network-1.4...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2007-11-12 07:28 EST ------- you can build for devel also and then we can CLOSE this review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2007-11-29 07:29 EST ------- I don't see approved package built for f8 or f9.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(harald@redhat.com)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
harald@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(harald@redhat.com)|
------- Additional Comments From harald@redhat.com 2007-12-06 07:49 EST ------- http://download.fedora.redhat.com/pub/fedora/linux/development/source/SRPMS/...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From panemade@gmail.com 2007-12-06 09:36 EST ------- thanks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
harald@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Keywords| |Reopened Resolution|RAWHIDE | Flag|fedora-review+ |fedora-cvs+
------- Additional Comments From harald@redhat.com 2008-03-26 21:08 EST ------- Package Change Request ====================== Package Name: system-config-network New Branches: F-10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
harald@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |notting@redhat.com, fedora- | |package-review@redhat.com AssignedTo|panemade@gmail.com |nobody@fedoraproject.org Status|ASSIGNED |CLOSED QAContact|fedora-package- |extras-qa@fedoraproject.org |review@redhat.com | Resolution| |RAWHIDE Flag|fedora-cvs+ |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE |
------- Additional Comments From panemade@gmail.com 2008-03-26 21:40 EST ------- I will prefer this review done by me to be in assigned state to me :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From harald@redhat.com 2008-03-26 21:42 EST ------- You already closed it :)
Parag AN(पराग) 2007-12-06 09:36 EST Status ASSIGNED CLOSED Resolution RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-03-26 21:47 EST ------- Yes I closed it because this package already completed its review and was in rawhide at time of closing this.
Please don't remove fedora-review+ flags.Therefore setting it again.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From panemade@gmail.com 2008-03-26 21:53 EST ------- (In reply to comment #16)
I will prefer this review done by me to be in assigned state to me :)
yup. I mean to say let the reviews be assigned to reviewer at time of closing reviews. You reset Assigned to nobody@fedoraproject.org
Harald Hoyer 2008-03-26 21:11 EST CC notting@redhat.com, fedora-package-review@redhat.com AssignedTo panemade@gmail.com nobody@fedoraproject.org Status ASSIGNED CLOSED QAContact fedora-package-review@redhat.com extras-qa@fedoraproject.org Resolution RAWHIDE Flag fedora-cvs+ fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
------- Additional Comments From harald@redhat.com 2008-03-26 22:03 EST ------- sry, accidently reopened it, while I just should have set the fedora-cvs flag to "?"
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-26 22:39 EST ------- cvs done.
Note that your new F-9 branch is a clone from current devel. You will want to do your F-10/unstable work in the devel branch now.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: system-config-network
https://bugzilla.redhat.com/show_bug.cgi?id=226464
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
------- Additional Comments From panemade@gmail.com 2008-04-04 10:18 EST ------- No need to open this review now as cvs is done :)
package-review@lists.fedoraproject.org