[Bug 1701329] New: Review Request: python-pycotap - emit TAP output using python and unittest.py

https://bugzilla.redhat.com/show_bug.cgi?id=1701329

Bug ID: 1701329
           Summary: Review Request: python-pycotap - emit TAP output using
                    python and unittest.py
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://www.shlomifish.org/Files/files/code/python-pycotap.spec
SRPM URL:
https://www.shlomifish.org/Files/files/arcs/python-pycotap-1.1.0-1.fc31.src....
Description: Needed by the freecell-solver's test suite
Fedora Account System Username: shlomif

[Bug 1701329] Review Request: python-pycotap - emit TAP output using python and unittest.py

https://bugzilla.redhat.com/show_bug.cgi?id=1701329

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

--- Comment #1 from Robert-André Mauchin  ---
Source0:       
https://files.pythonhosted.org/packages/source/p/%%7Bpypi_name%7D/%%7Bpypi_n...

→

Source0:        %{pypi_source}

- Remove the shebang in %prep:

python3-pycotap.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/pycotap/__init__.py /usr/bin/env python
python3-pycotap.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/pycotap/__init__.py 644 /usr/bin/env python

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License". 4 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/python-pycotap/review-python-
     pycotap/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Spec file according to URL is the same as in SRPM.
     Note: Spec file as given by url is not the same as in SRPM (see
     attached diff).
     See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Rpmlint
-------
Checking: python3-pycotap-1.1.0-1.fc31.noarch.rpm
          python-pycotap-1.1.0-1.fc31.src.rpm
python3-pycotap.noarch: W: no-documentation
python3-pycotap.noarch: E: wrong-script-interpreter
/usr/lib/python3.7/site-packages/pycotap/__init__.py /usr/bin/env python
python3-pycotap.noarch: E: non-executable-script
/usr/lib/python3.7/site-packages/pycotap/__init__.py 644 /usr/bin/env python
2 packages and 0 specfiles checked; 2 errors, 1 warnings.

[Bug 1701329] Review Request: python-pycotap - emit TAP output using python and unittest.py

https://bugzilla.redhat.com/show_bug.cgi?id=1701329

--- Comment #2 from Shlomi Fish  ---
(In reply to Robert-André Mauchin from comment #1)
> Source0:       
> https://files.pythonhosted.org/packages/source/p/%%7Bpypi_name%7D/%%7Bpypi_n...
> %{version}.tar.gz

Thanks, Robert-Andre! The spec and srpm are fixed in the same URLs.

[Bug 1701329] Review Request: python-pycotap - emit TAP output using python and unittest.py

https://bugzilla.redhat.com/show_bug.cgi?id=1701329

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #3 from Robert-André Mauchin  ---
I would have preferred that you remove the shebang in %prep rather than
%install.

Package approved anyway.

[Bug 1701329] Review Request: python-pycotap - emit TAP output using python and unittest.py

https://bugzilla.redhat.com/show_bug.cgi?id=1701329

--- Comment #4 from Igor Gnatenko  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-pycotap

[Bug 1701329] Review Request: python-pycotap - emit TAP output using python and unittest.py

https://bugzilla.redhat.com/show_bug.cgi?id=1701329

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
                 CC|                            |[e-mail]
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2020-05-19 10:14:26