[Bug 2295811] New: Review Request: rust-byteorder_slice - Provides convenience methods for reading numbers and slices from a slice
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Bug ID: 2295811 Summary: Review Request: rust-byteorder_slice - Provides convenience methods for reading numbers and slices from a slice Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pvalerio@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/retis-org/copr-playground/blob/main/rust-byteorder_slice.... SRPM URL: https://download.copr.fedorainfracloud.org/results/%40retis/playground/fedor... Description: Byteorder like crate for &[u8] Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671848/
Fedora Account System Username: atenart, pvaler, amorenoz
I’m starting this review request on behalf of Antoine, Adrián and me. We want to maintain it as a group. It’s our first package and we’ll need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Paolo Valerio pvalerio@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2295815
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2295815 [Bug 2295815] Review Request: rust-pcap-file - A crate to parse, read and write Pcap and PcapNg
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/by | |teorder_slice Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7708289 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Please provide URLs to raw files, not HTML pages. Otherwise tooling will not be able to parse this ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Antoine Tenart atenart@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-byteor... SRPM URL: https://download.copr.fedorainfracloud.org/results/%40retis/playground/fedor... Description: Byteorder like crate for &[u8] Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671848/
Fedora Account System Username: atenart, pvaler, amorenoz
I’m starting this review request on behalf of Antoine, Adrián and me. We want to maintain it as a group. It’s our first package and we’ll need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7773634 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Status|NEW |ASSIGNED
--- Comment #5 from Fabio Valentini decathorpe@gmail.com ---
# FIXME: no license files detected
It looks like you used "rust2rpm --ignore-missing-license-files" *and* didn't actually fix the FIXME? The MIT license requires that redistributed sources contain a copy of the license text.
Looks like the upstream project does not contain a license text at all: https://github.com/courvoif/byteorder_slice
Please file an issue there about adding the MIT license text, and including it in published crates.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Paolo Valerio pvalerio@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-byteor... SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-... Description: Byteorder like crate for &[u8] Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/07884762/
Fedora Account System Username: atenart, pvaler, amorenoz
I’m starting this review request on behalf of Antoine, Adrián and me. We want to maintain it as a group. It’s our first package and we’ll need a sponsor.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #6 from Paolo Valerio pvalerio@redhat.com --- Thank you for the feedback.
There's an open pull request introducing a LICENSE file, but at the moment it's received no feedback: https://github.com/courvoif/byteorder_slice/pull/4
I added our request under the PR.
The spec file now contains a comment with the link to the pull request.
I'll continue monitoring the upstream status and ping if needed.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #7 from Fabio Valentini decathorpe@gmail.com --- Thank you for filing that ticket. I think with 2 months passed, it's safe to say that you *tried*.
In this case, please include the file you're proposing to add as a separate source (or patch), and replace this:
# FIXME: no license files detected # https://github.com/courvoif/byteorder_slice/pull/4
(Similar to what was done for derive-into-owned.)
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #8 from Paolo Valerio pvalerio@redhat.com --- Thanks Fabio,
I added the LICENSE as a patch and set it as a %license.
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-byteor... SRPM URL: https://download.copr.fedorainfracloud.org/results/@retis/playground/fedora-...
Description: Byteorder like crate for &[u8] Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/07953227/
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2045037 --> https://bugzilla.redhat.com/attachment.cgi?id=2045037&action=edit The .spec file difference from Copr build 7773634 to 7953366
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7953366 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #11 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks pretty good now - can you add the link to the PR to the spec file please? Something like this:
# Add license text as this is missing upstream: # https://github.com/courvoif/byteorder_slice/pull/4 Patch: byteorder_slice-add-mit-license-file.diff
Otherwise people would need to dig into where this patch comes from.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
--- Comment #12 from Antoine Tenart atenart@redhat.com --- (In reply to Fabio Valentini from comment #11)
Thanks, looks pretty good now - can you add the link to the PR to the spec file please? Something like this:
# Add license text as this is missing upstream: # https://github.com/courvoif/byteorder_slice/pull/4 Patch: byteorder_slice-add-mit-license-file.diff
Otherwise people would need to dig into where this patch comes from.
Makes sense, I just added it.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #13 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks good to me now. However, it looks like you updated the SPEC behind the URL but not the uploaded SRPM. When importing the package, please ensure that you take the most recent version that includes the last improvement.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files: A PR submitted to upstream to include a license file two months ago, but was not addressed yet. A patch that corresponds to the PR that adds the missing license file is temporarily included in the package. ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
Your sponsor should be able to help you with these tasks and with importing the package if you have any questions.
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RELEASE_PENDING
--- Comment #14 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-byteorder_slice
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c3c9b3bbe3 (rust-byteorder_slice-3.0.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-c3c9b3bbe3
https://bugzilla.redhat.com/show_bug.cgi?id=2295811
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2024-11-04 14:47:38
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-c3c9b3bbe3 (rust-byteorder_slice-3.0.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com