https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Bug ID: 2260798 Summary: Review Request: plasma-workspace-x11 - Xorg support for Plasma Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: kevin@tigcc.ticalc.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://repo.calcforge.org/review/plasma-workspace-x11.spec SRPM URL: https://repo.calcforge.org/review/plasma-workspace-x11-5.92.0-1.fc40.src.rpm Description: Xorg support for Plasma. Fedora Account System Username: kkofler
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2260793 Assignee|nobody@fedoraproject.org |sergio@serjux.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Kevin Kofler kevin@tigcc.ticalc.org --- This is part two of "unbreak KDE". Hopefully the last one. (At least, kwin and plasma-workspace are the only packages that are rebuilt in the ngompa/kde6-x11-unsupported Copr.)
Successful Rawhide scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=112522760
Has a runtime-only dependency on kwin-x11 (see review bug #2260793).
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2260793 [Bug 2260793] Review Request: kwin-x11 - KDE Window manager with X11 support
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://invent.kde.org/plas | |ma/plasma-workspace
--- Comment #2 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/6969142 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #3 from Kevin Kofler kevin@tigcc.ticalc.org --- The BuildRequires are copied from plasma-workspace. The Qt/KDE -devel files drag in gcc-c++ transitively, but I suppose I could add it explicitly.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Note:
This package has the same issue as kwin-x11 as noted here: https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c9
Introducing it the way it is right now would break part of the the implementation of the Plasma 6 Change.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #5 from Kevin Kofler kevin@tigcc.ticalc.org --- I do not think it actually would, see: https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c10
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #6 from Kevin Kofler kevin@tigcc.ticalc.org ---
Introducing it the way it is right now would break part of the the implementation of the Plasma 6 Change.
No, it would not. I can prove it: https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c13
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Stephen Gallagher sgallagh@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sgallagh@redhat.com
--- Comment #7 from Stephen Gallagher sgallagh@redhat.com --- At today's meeting, FESCo agreed to a preliminary injunction while we consider this issue. Until otherwise notified, these packages (kwin-X11 and plasma-workspace-x11) may not be re-admitted to Fedora. This decision is NOT final, but FESCo needs time to consider what to do here.
https://pagure.io/fesco/issue/3165
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #8 from Kevin Kofler kevin@tigcc.ticalc.org --- As per https://bugzilla.redhat.com/show_bug.cgi?id=2260793#c24, a suggested longer %description:
%description Support for the legacy X11 window system in KDE Plasma instead of the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. (It also contains a dependency on kwin-x11, the legacy X11 version of the KDE Window Manager (KWin).) This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.)
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #9 from Kevin Kofler kevin@tigcc.ticalc.org --- Though maybe it should say "in addition to" instead of "instead of", since this does NOT conflict with plasma-workspace-wayland and you will probably not be able to remove plasma-workspace-wayland due to dependencies.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Petr Menšík pemensik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |pemensik@redhat.com
--- Comment #10 from Petr Menšík pemensik@redhat.com --- If it does not conflict with plasma-workspace-wayland, then yes, this package would add just additional session type. I would omit (It also contains a dependency on kwin-x11, the legacy X11 version of the KDE Window Manager (KWin).). This is would be visible from dnf or rpm -q. I would add brief description from upstream README.
%description Plasma Workspace is used as the base for Plasma Desktop, Mobile, and Bigscreen. It contains shared KCMs, applets as well as multiple libraries.
Support for the legacy X11 window system in KDE Plasma instead of the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG.
(See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.)
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Alessandro Astone ales.astone@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ales.astone@gmail.com
--- Comment #11 from Alessandro Astone ales.astone@gmail.com --- Can we coordinate this with https://src.fedoraproject.org/rpms/plasma-workspace/pull-request/29 and https://src.fedoraproject.org/rpms/kwin/pull-request/12 to avoid bumping the epoch here?
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #12 from Kevin Kofler kevin@tigcc.ticalc.org --- Yes, we can do that.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #13 from Sergio Basto sergio@serjux.com --- (In reply to Alessandro Astone from comment #11)
Can we coordinate this with https://src.fedoraproject.org/rpms/plasma-workspace/pull-request/29 and https://src.fedoraproject.org/rpms/kwin/pull-request/12 to avoid bumping the epoch here?
I would be grateful if this was done, it seems to me that it is the most rational but I think you need rebase the PR(s)
best regards,
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #14 from Alessandro Astone ales.astone@gmail.com --- Done.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #15 from Sergio Basto sergio@serjux.com --- from https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev... and reviewing the spec
no issues found , BTW we may also need add SDDM-X11 if is not in this package ...
please remove EPOCH before import the package
PACKAGE APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #16 from Kevin Kofler kevin@tigcc.ticalc.org --- Spec URL: https://repo.calcforge.org/review/plasma-workspace-x11.spec SRPM URL: https://repo.calcforge.org/review/plasma-workspace-x11-5.92.0-7.fc40.src.rpm Description: Support for the legacy X11 window system in KDE Plasma, as opposed to the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. (Other requirements such as kwin-x11 are found in the package dependencies.) The session type can be switched between "Plasma (X11)" and the default "Plasma (Wayland)" in the display manager (e.g., SDDM).
This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.)
Fedora Account System Username: kkofler
* Fri Feb 16 2024 Kevin Kofler <…> - 5.92.0-7 - Drop Epoch again, the Obsoletes in -wayland was tightened - Explicitly BuildRequires: cmake and gcc-c++ - Improve %%description
This addresses the comments that have come up during review.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #17 from Kevin Kofler kevin@tigcc.ticalc.org ---
BTW we may also need add SDDM-X11 if is not in this package ...
SDDM still ships sddm-x11 for now. If they drop it, I will have to package that, too.
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
--- Comment #18 from Sergio Basto sergio@serjux.com --- (In reply to Kevin Kofler from comment #16)
Spec URL: https://repo.calcforge.org/review/plasma-workspace-x11.spec SRPM URL: https://repo.calcforge.org/review/plasma-workspace-x11-5.92.0-7.fc40.src.rpm Description: Support for the legacy X11 window system in KDE Plasma, as opposed to the default Wayland. This package provides the legacy "Plasma (X11)" session type and the startplasma-x11 executable required by that session type. (Other requirements such as kwin-x11 are found in the package dependencies.) The session type can be switched between "Plasma (X11)" and the default "Plasma (Wayland)" in the display manager (e.g., SDDM).
This version is maintained by individual Fedora packagers and NOT supported by the Fedora KDE SIG. (See plasma-workspace-wayland for the default version, using Wayland, maintained by the KDE SIG.)
Fedora Account System Username: kkofler
- Fri Feb 16 2024 Kevin Kofler <…> - 5.92.0-7
- Drop Epoch again, the Obsoletes in -wayland was tightened
- Explicitly BuildRequires: cmake and gcc-c++
- Improve %%description
This addresses the comments that have come up during review.
perfect please do: fedpkg request-repo https://docs.fedoraproject.org/en-US/package-maintainers/New_Package_Process...
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST
--- Comment #19 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-workspace-x11
https://bugzilla.redhat.com/show_bug.cgi?id=2260798
Sergio Basto sergio@serjux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA Last Closed| |2024-03-04 11:28:08
https://bugzilla.redhat.com/show_bug.cgi?id=2260798 Bug 2260798 depends on bug 2260793, which changed state.
Bug 2260793 Summary: Review Request: kwin-x11 - KDE Window manager with X11 support https://bugzilla.redhat.com/show_bug.cgi?id=2260793
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com