[Bug 2294727] New: Review Request: rust-rocket_http - Types, traits, and parsers for HTTP requests, responses, and headers
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Bug ID: 2294727 Summary: Review Request: rust-rocket_http - Types, traits, and parsers for HTTP requests, responses, and headers Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: lukasz.wojnilowicz@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://wojnilowicz.fedorapeople.org/rust-rocket_http.spec SRPM URL: https://wojnilowicz.fedorapeople.org/rust-rocket_http-0.5.1-1.fc39.src.rpm
Description: Types, traits, and parsers for HTTP requests, responses, and headers.
Fedora Account System Username: wojnilowicz
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://crates.io/crates/ro | |cket_http Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/7689407 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Assignee|nobody@fedoraproject.org |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Looks OK to me. Just please clarify some things:
- The subpackage for the "mtls" and "x509-parser" features are missing from the package. Are these optional features with additional dependencies that you don't want to package / don't need?
- Looks like some doctests can only be run inside the upstream git repository. The doctests you are skipping result in 0 (zero) doctests remaining that are compiled or run. In this case, it would be much, much easier to use `%cargo_test -- --lib` instead of manually listing all source files.
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
wojnilowicz lukasz.wojnilowicz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
--- Comment #3 from wojnilowicz lukasz.wojnilowicz@gmail.com --- (In reply to Fabio Valentini from comment #2)
Looks OK to me. Just please clarify some things:
- The subpackage for the "mtls" and "x509-parser" features are missing from
the package. Are these optional features with additional dependencies that you don't want to package / don't need?
Yes. mtls depends on x509-parser, and it isn't available in Fedora.
The dependencies that I need are like this (from the top to the bottom): https://github.com/ActivityWatch/aw-server-rust/blob/82345cfc5371c673a9bc2b5... https://github.com/ActivityWatch/aw-server-rust/blob/82345cfc5371c673a9bc2b5... https://github.com/lawliet89/rocket_cors/blob/master/Cargo.toml#L23 https://github.com/rwf2/Rocket/blob/v0.5/core/lib/Cargo.toml#L23 https://github.com/rwf2/Rocket/blob/v0.5/core/lib/Cargo.toml#L28
so nothing such fancy as mtls is needed.
- Looks like some doctests can only be run inside the upstream git
repository. The doctests you are skipping result in 0 (zero) doctests remaining that are compiled or run. In this case, it would be much, much easier to use `%cargo_test -- --lib` instead of manually listing all source files.
Done. I just wasn't aware of that. Thanks for the tip.
The spec file is updated in the first post, so rebuilding. [fedora-review-service-build]
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #4 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks good to me!
You might want to replace the comment above "%cargo_test -- --lib" with something more expressive, maybe "doctests can only be run within the upstream workspace" or something like it.
===
Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rocket_http
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2bb31e79d3 (rust-rocket_http-0.5.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2bb31e79d3
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-07-07 07:53:29
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-2bb31e79d3 (rust-rocket_http-0.5.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2294727
--- Comment #8 from wojnilowicz lukasz.wojnilowicz@gmail.com --- Thanks you for the review! Everything's done.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com