[Bug 226503] New: Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

Summary: Merge Review: tree
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail]

Fedora Merge Review: tree

http://cvs.fedora.redhat.com/viewcvs/devel/tree/
Initial Owner: [e-mail]

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
                 CC|                            |[e-mail]
               Flag|fedora-review?              |fedora-review-

------- Additional Comments From [e-mail]  2007-02-04 11:25 EST -------
Hi there,

Review for release 5:
* RPM name is OK
* Source tree-1.5.0.tgz is the same as upstream
* Builds fine in mock
* File list looks OK

Needs work:
* BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
  (wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
  (wiki: PackagingGuidelines#parallelmake)
* Package is marked as relocatable, please check.
  (wiki: PackagingGuidelines#RelocatablePackages)
* Spec file: some paths are not replaced with RPM macros
  (wiki: QAChecklist item 7)
* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)
  Just add LICENSE from the source to %doc
* Preserve timestamps when you install files

Rpmlint is not silent:

Source RPM:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.
W: tree hardcoded-prefix-tag /usr
W: tree hardcoded-path-in-buildroot-tag /var/tmp/tree-root

rpmlint of tree:
W: tree summary-ended-with-dot A utility which displays a tree view of the contents of directories.

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]           |[e-mail]
               Flag|fedora-review-              |fedora-review?

------- Additional Comments From [e-mail]  2007-02-06 12:09 EST -------
Thanks!  Should be all fixed in 1.5.0-6.fc7.

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]      |[e-mail]
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2007-02-06 14:54 EST -------
Thanks Tim, this looks good.
One question though, why do you rm -rf tree in %build? I think rpmbuild does this by default.

I don't see any blockers, so this package is approved. Please leave the ticket assigned to yourself.

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

------- Additional Comments From [e-mail]  2007-02-07 04:57 EST -------
A previous tarball shipped the tree binary(!) along with the source.  Current
version doesn't do that so I'll remove the rm.

Thanks!

Can I set the resolution to 'RAWHIDE' or something?

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

------- Additional Comments From [e-mail]  2007-02-07 07:27 EST -------
If you want, you can set it to closed rawhide.
We're only planning on looking at the fedora-review flag. If that's a +, the
package is approved.

Thanks,

Ruben

[Bug 226503] Merge Review: tree

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: tree

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226503

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE