https://bugzilla.redhat.com/show_bug.cgi?id=1264337
Bug ID: 1264337 Summary: Review Request: semweb4j - Java RDF Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: puntogil@libero.it QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://gil.fedorapeople.org/semweb4j.spec SRPM URL: https://gil.fedorapeople.org/semweb4j-5.0.1-1.fc22.src.rpm Description: The Semweb4j project gives you simple libraries to do complicated things with Java and RDF. Very little semantic web knowledge is required. Fedora Account System Username: gil
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1241447, 1235950
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1235950 [Bug 1235950] Review Request: openrdf-sesame - Java framework for processing and handling RDF data https://bugzilla.redhat.com/show_bug.cgi?id=1241447 [Bug 1241447] Review Request: jsonld-java - A JSON-based format to serialize Linked Data for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1267890
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1267890 [Bug 1267890] Review Request: jsonld-java-tools - JSON-LD Java tools
https://bugzilla.redhat.com/show_bug.cgi?id=1264337 Bug 1264337 depends on bug 1241447, which changed state.
Bug 1241447 Summary: Review Request: jsonld-java - A JSON-based format to serialize Linked Data for Java https://bugzilla.redhat.com/show_bug.cgi?id=1241447
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
--- Comment #1 from gil cattaneo puntogil@libero.it --- Spec URL: https://gil.fedorapeople.org/semweb4j.spec SRPM URL: https://gil.fedorapeople.org/semweb4j-5.0.1-1.fc23.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
--- Comment #2 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- gil's scratch build of semweb4j-5.0.1-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12035216
https://bugzilla.redhat.com/show_bug.cgi?id=1264337 Bug 1264337 depends on bug 1235950, which changed state.
Bug 1235950 Summary: Review Request: openrdf-sesame - Java framework for processing and handling RDF data https://bugzilla.redhat.com/show_bug.cgi?id=1235950
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1264337 Bug 1264337 depends on bug 1267890, which changed state.
Bug 1267890 Summary: Review Request: jsonld-java-tools - JSON-LD Java tools https://bugzilla.redhat.com/show_bug.cgi?id=1267890
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
Marcus Karlsson mk@acc.umu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mk@acc.umu.se Assignee|nobody@fedoraproject.org |mk@acc.umu.se Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
Marcus Karlsson mk@acc.umu.se changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+
--- Comment #3 from Marcus Karlsson mk@acc.umu.se --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: ======= - License check detected this one file licensed under AFL-3.0. Perhaps add it to the license field before importing the package.
AFL-3.0. -------- semweb4j-rootbuilder-5.0.1/org.semweb4j.rdf2go.impl.sesame/src/main/java/org/openrdf/rdf2go/osgi/Activator.java
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "AFL-3.0.", "Unknown or generated". 322 files have unknown license. Detailed output of licensecheck in /home/mk/fedora/review-semweb4j/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in semweb4j-bom , semweb4j-dist , semweb4j-parent , semweb4j-rdf2go-dist , semweb4j-rdf2go-impl-sesame , semweb4j-rdfreactor-dist , semweb4j- rdfreactor-generator , semweb4j-rdfreactor-runtime , semweb4j- rdfreactor-maven-plugin , semweb4j-root , semweb4j-javadoc [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: semweb4j-5.0.1-1.fc24.noarch.rpm semweb4j-bom-5.0.1-1.fc24.noarch.rpm semweb4j-dist-5.0.1-1.fc24.noarch.rpm semweb4j-parent-5.0.1-1.fc24.noarch.rpm semweb4j-rdf2go-dist-5.0.1-1.fc24.noarch.rpm semweb4j-rdf2go-impl-sesame-5.0.1-1.fc24.noarch.rpm semweb4j-rdfreactor-dist-5.0.1-1.fc24.noarch.rpm semweb4j-rdfreactor-generator-5.0.1-1.fc24.noarch.rpm semweb4j-rdfreactor-runtime-5.0.1-1.fc24.noarch.rpm semweb4j-rdfreactor-maven-plugin-5.0.1-1.fc24.noarch.rpm semweb4j-root-5.0.1-1.fc24.noarch.rpm semweb4j-javadoc-5.0.1-1.fc24.noarch.rpm semweb4j-5.0.1-1.fc24.src.rpm semweb4j-bom.noarch: W: no-documentation semweb4j-dist.noarch: W: no-documentation semweb4j-parent.noarch: W: no-documentation semweb4j-rdf2go-dist.noarch: W: no-documentation semweb4j-rdfreactor-dist.noarch: W: no-documentation semweb4j-rdfreactor-generator.noarch: W: no-documentation semweb4j-rdfreactor-runtime.noarch: W: no-documentation semweb4j-rdfreactor-maven-plugin.noarch: W: no-documentation semweb4j-root.noarch: W: no-documentation 13 packages and 0 specfiles checked; 0 errors, 9 warnings.
Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory semweb4j-root.noarch: W: no-documentation semweb4j-rdfreactor-runtime.noarch: W: no-documentation semweb4j-rdfreactor-maven-plugin.noarch: W: no-documentation semweb4j-bom.noarch: W: no-documentation semweb4j-dist.noarch: W: no-documentation semweb4j-rdf2go-dist.noarch: W: no-documentation semweb4j-rdfreactor-generator.noarch: W: no-documentation semweb4j-rdfreactor-dist.noarch: W: no-documentation semweb4j-parent.noarch: W: no-documentation 12 packages and 0 specfiles checked; 0 errors, 9 warnings.
Requires -------- semweb4j-javadoc (rpmlib, GLIBC filtered): jpackage-utils
semweb4j-root (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.semweb4j:parent:pom:) mvn(org.slf4j:slf4j-api)
semweb4j-rdfreactor-runtime (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.semweb4j:rdf2go.api) mvn(org.slf4j:slf4j-api)
semweb4j-rdfreactor-maven-plugin (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(log4j:log4j:1.2.17) mvn(org.apache.maven:maven-plugin-api) mvn(org.apache.maven:maven-project) mvn(org.semweb4j:rdfreactor.generator) mvn(org.slf4j:slf4j-api) mvn(org.slf4j:slf4j-log4j12)
semweb4j-bom (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.semweb4j:parent:pom:) mvn(org.slf4j:slf4j-api)
semweb4j-dist (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.semweb4j:parent:pom:) mvn(org.semweb4j:rdf2go.dist:pom:) mvn(org.semweb4j:rdfreactor.dist:pom:) mvn(org.slf4j:slf4j-api)
semweb4j-rdf2go-dist (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.apache.maven.plugins:maven-jar-plugin) mvn(org.semweb4j:parent:pom:) mvn(org.semweb4j:rdf2go.api) mvn(org.semweb4j:rdf2go.impl.sesame) mvn(org.slf4j:slf4j-api)
semweb4j-rdfreactor-generator (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(log4j:log4j:1.2.17) mvn(org.semweb4j:rdf2go.impl.sesame) mvn(org.semweb4j:rdfreactor.runtime) mvn(org.slf4j:slf4j-api) mvn(org.slf4j:slf4j-log4j12) mvn(velocity:velocity)
semweb4j (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.slf4j:slf4j-api)
semweb4j-rdfreactor-dist (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.semweb4j:parent:pom:) mvn(org.semweb4j:rdfreactor-maven-plugin) mvn(org.semweb4j:rdfreactor.generator) mvn(org.semweb4j:rdfreactor.runtime) mvn(org.slf4j:slf4j-api)
semweb4j-rdf2go-impl-sesame (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(com.github.jsonld-java:jsonld-java-tools) mvn(org.openrdf.sesame:sesame-repository-http) mvn(org.openrdf.sesame:sesame-repository-sail) mvn(org.openrdf.sesame:sesame-rio-rdfjson) mvn(org.openrdf.sesame:sesame-rio-rdfxml) mvn(org.openrdf.sesame:sesame-rio-trig) mvn(org.openrdf.sesame:sesame-runtime-osgi) mvn(org.openrdf.sesame:sesame-sail-memory) mvn(org.semweb4j:rdf2go.api) mvn(org.slf4j:slf4j-api)
semweb4j-parent (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.apache.maven.plugins:maven-compiler-plugin) mvn(org.apache.maven.plugins:maven-jar-plugin) mvn(org.slf4j:slf4j-api) mvn(org.sonatype.oss:oss-parent:pom:)
Provides -------- semweb4j-javadoc: semweb4j-javadoc
semweb4j-root: mvn(org.semweb4j:rootbuilder:pom:) semweb4j-root
semweb4j-rdfreactor-runtime: mvn(org.semweb4j:rdfreactor.runtime) mvn(org.semweb4j:rdfreactor.runtime:pom:) semweb4j-rdfreactor-runtime
semweb4j-rdfreactor-maven-plugin: mvn(org.semweb4j:rdfreactor-maven-plugin) mvn(org.semweb4j:rdfreactor-maven-plugin:pom:) semweb4j-rdfreactor-maven-plugin
semweb4j-bom: mvn(org.semweb4j:bom:pom:) semweb4j-bom
semweb4j-dist: mvn(org.semweb4j:dist:pom:) semweb4j-dist
semweb4j-rdf2go-dist: mvn(org.semweb4j:rdf2go.dist:pom:) semweb4j-rdf2go-dist
semweb4j-rdfreactor-generator: mvn(org.semweb4j:rdfreactor.generator) mvn(org.semweb4j:rdfreactor.generator:pom:) semweb4j-rdfreactor-generator
semweb4j: mvn(org.semweb4j:rdf2go.api) mvn(org.semweb4j:rdf2go.api:pom:) osgi(org.semweb4j.rdf2go.api) semweb4j
semweb4j-rdfreactor-dist: mvn(org.semweb4j:rdfreactor.dist:pom:) semweb4j-rdfreactor-dist
semweb4j-rdf2go-impl-sesame: mvn(org.semweb4j:rdf2go.impl.sesame) mvn(org.semweb4j:rdf2go.impl.sesame:pom:) osgi(org.semweb4j.rdf2go.impl.sesame23) semweb4j-rdf2go-impl-sesame
semweb4j-parent: mvn(org.semweb4j:parent:pom:) semweb4j-parent
Source checksums ---------------- https://github.com/semweb4j/semweb4j/archive/rootbuilder-5.0.1.tar.gz : CHECKSUM(SHA256) this package : 3158fadea029af675323f9a354e37084d44b569e39b08f0439d1a8e02149938b CHECKSUM(SHA256) upstream package : 3158fadea029af675323f9a354e37084d44b569e39b08f0439d1a8e02149938b
Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=1264337 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
--- Comment #4 from gil cattaneo puntogil@libero.it --- (In reply to Marcus Karlsson from comment #3)
Package Review
Issues:
- License check detected this one file licensed under AFL-3.0. Perhaps add it to the license field before importing the package.
AFL-3.0.
semweb4j-rootbuilder-5.0.1/org.semweb4j.rdf2go.impl.sesame/src/main/java/org/ openrdf/rdf2go/osgi/Activator.java
===== MUST items =====
Generic:
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "AFL-3.0.", "Unknown or generated". 322 files have unknown license. Detailed output of licensecheck in /home/mk/fedora/review-semweb4j/licensecheck.txt
Done
Spec URL: https://gil.fedorapeople.org/semweb4j.spec SRPM URL: https://gil.fedorapeople.org/semweb4j-5.0.1-1.fc23.src.rpm
Thanks for the review
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/semweb4j
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- semweb4j-5.0.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7c13e3f651
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- semweb4j-5.0.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7c13e3f651
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- semweb4j-5.0.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1264337
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-02-26 02:24:22
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla