https://bugzilla.redhat.com/show_bug.cgi?id=1170374
Bug ID: 1170374 Summary: Review Request: yum-plugin-needs-restarting - YUM plugin for listing processes using old files after upgrade Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: any0n3@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://fpaste.org/156381/ SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8950/8288950/yum-plugin-needs... Description: yum-plugin-needs-restarting is a YUM plugin for listing processes using old files after upgrading your system. It is based on the code of needs-restarting which is part of the yum-utils package. Fedora Account System Username: any0n3
This is my first package and I am looking for a mentor, I've already asked cwickert.
The developer is a friend of mine and I like to maintain this package.
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
Miroslav Suchý msuchy@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |msuchy@redhat.com
--- Comment #1 from Miroslav Suchý msuchy@redhat.com --- 1) I'm not sure if it is worth the work to continue adding something for yum. I would focus work on some plugin for DNF instead.
2) There is much better plugin (for DNF) called tracer. See bug 1158629
And if you want to learn something:
* %defattr(-, root, root) This is default and not needed since rpm 4.2
* %{__python} -c "import compileall; compileall.compile_dir('%{buildroot}/%pluginhome', 1)" rpm do that automatically, no need to do that.
* rm -rf %{buildroot} not needed: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
* you should preserve timestamps and use "cp -a"
* license should be marked using %license macro %license COPYING
* do not enumerate all extension and just use: %{pluginhome}/needs-restarting.py*
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
--- Comment #2 from Piotr Popieluch piotr1212@gmail.com --- DNF is not available in RHEL6 and 7 which are still supported up to 2028. This is a really useful plugin which I would definitely use as sysadmin. I do think it is worth the work.
Did you already found someone which is willing to sponsor you? Do you want to become a package maintainer or are you just interested in getting this single package in Fedora/EPEL? If you are just interested in this package it would probably be faster if I would take it over from you and make you co-maintainer.
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
--- Comment #3 from Michael Spahn any0n3@fedoraproject.org --- Thank you for you comments, I'm interested in becoming a package maintainer. And it seems like I haven't found a sponsor yet.
I'll fix the mentioned improvements asap.
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
--- Comment #4 from Michael Spahn any0n3@fedoraproject.org --- Created attachment 984741 --> https://bugzilla.redhat.com/attachment.cgi?id=984741&action=edit Updated spec file
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
--- Comment #5 from Michael Spahn any0n3@fedoraproject.org --- Created attachment 984743 --> https://bugzilla.redhat.com/attachment.cgi?id=984743&action=edit Updated SRPM
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
--- Comment #6 from Piotr Popieluch piotr1212@gmail.com --- I Can't sponsor you as I am not a sponsor... You will need to find one yourself. You will have to show them that you understand the package guidelines by doing unofficial reviews. Please also upload the spec/srpm to a website and not send them as attachments. Most reviewers use fedora-review -b <bugnumber> which doesn't work with attachments.
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
--- Comment #7 from Piotr Popieluch piotr1212@gmail.com --- Hi Michael,
Could you please upload the updated spec and srpm and post the url's like you did in the bug, like: Spec URL: SRPM URL: Most reviewers use automated tools which fetch sources from those tags, that doesn't work with attachments.
Could you post links to unofficial package reviews you did?
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
Till Maas opensource@till.name changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED CC| |opensource@till.name Blocks| |201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed| |2017-08-03 06:29:16
--- Comment #8 from Till Maas opensource@till.name --- Michael, since you did no respond to Piotr in 2 years I close this review request. Please open a new one if you still plan to package this.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
package-review@lists.fedoraproject.org