[Bug 443177] New: Review Request: html2ps - HTML to PostScript converter - package-review

List overview All Threads
Download

newer

[Bug 443177] New: Review Request: html2ps - HTML to PostScript converter

older

[Bug 526564] New: Review Request:...

[Bug 233585] New: Review Request:...

Red Hat Bugzilla

19 Apr 2008 19 Apr '08

4:23 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=443177

Summary: Review Request: html2ps - HTML to PostScript converter Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pertusus@free.fr QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/html2ps.spec SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/html2ps-1.0-0.1.b5.fc9.... Description: An HTML to PostScript converter written in Perl. * Many possibilities to control the appearance. * Support for processing multiple documents. * A table of contents can be generated. * Configurable page headers/footers. * Automatic hyphenation and text justification can be selected.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

19 Apr 19 Apr

5:55 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

dev@nigelj.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dev@nigelj.com

------- Additional Comments From dev@nigelj.com 2008-04-18 20:25 EST ------- Hi, I don't think I should do a formal review yet, but I'll take a look soon if no one else does. (I used to maintain this on Debian a few years ago)

Also, unless I'm mistaken there are still quite a few bugs in html2ps.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2:52 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From pertusus@free.fr 2008-04-19 05:22 EST ------- Indeed, there is no utf8 support and quite a number of bugs opened in debian. I will have a look at time permits, but I don't think it is blocking.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

21 Apr 21 Apr

5:25 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

dev@nigelj.com changed:

------- Additional Comments From dev@nigelj.com 2008-04-20 19:55 EST ------- (In reply to comment #0)

...

SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/html2ps-1.0-

0.1.b5.fc9.noarch.rpm That looks like the actual RPM not the SRPM :)

(In reply to comment #1)

...

Hi, I don't think I should do a formal review yet

Okay, turns out I'm not as rusty as I thought I was so I'll be happy to review!

(In reply to comment #2)

...

Indeed, there is no utf8 support and quite a number of bugs opened in debian. I will have a look at time permits, but I don't think it is blocking.

I agree 100% was just making sure you were aware of it.

Initial look at spec file seems not bad.

(On a side note, could you maybe consider reviewing Bug443301 in return?)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

22 Apr 22 Apr

2:21 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From pertusus@free.fr 2008-04-22 04:51 EST ------- Indeed, I did it wrong, the srpm is now at: http://www.environnement.ens.fr/perso/dumas/fc-srpms/html2ps-1.0-0.1.b5.fc9....

I think that the concordance review is under enough eyes, currently. Do you want that I have a look at another review?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

28 Apr 28 Apr

2:46 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

pertusus@free.fr changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3:04 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From dev@nigelj.com 2008-04-27 17:34 EST ------- Sorry for the delays, I'll formalize the review later today but....

At the moment it looks really good! http://koji.fedoraproject.org/koji/taskinfo?taskID=585137 so unless I find anything mysteriously wrong with it, it'll be an approved :)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

3 May 3 May

8:11 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

dev@nigelj.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From dev@nigelj.com 2008-05-02 22:41 EST ------- Sorry for the delays (again)

Package Review ==============

Key: - = N/A x = Check ! = Problem ? = Not evaluated

=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: F-8/noarch [x] Rpmlint output: source RPM: empty binary RPM: html2ps.noarch: E: explicit-lib-dependency libpaper [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPLv2+ [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [x] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/noarch (koji) [x] Package should compile and build into binary rpms on all supported architectures. Tested on:devel/noarch [x] Package functions as described. [x] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane

================ *** APPROVED *** ================

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:55 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From pertusus@free.fr 2008-05-03 07:25 EST ------- New Package CVS Request ======================= Package Name: html2ps Short Description: HTML to PostScript converter Owners: pertusus Branches: F-8 EL-5 InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:56 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

pertusus@free.fr changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From pertusus@free.fr 2008-05-03 07:26 EST ------- Thanks for the review!

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5:29 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From dev@nigelj.com 2008-05-03 07:59 EST ------- (In reply to comment #8)

...

Thanks for the review!

No problem!

(In reply to comment #7)

...

Branches: F-8 EL-5

Don't forget F-9 :)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6:12 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From pertusus@free.fr 2008-05-03 08:42 EST ------- OOps. Added F-9

New Package CVS Request ======================= Package Name: html2ps Short Description: HTML to PostScript converter Owners: pertusus Branches: F-8 F-9 EL-5 InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4 May 4 May

9:04 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-05-03 23:34 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12 May 12 May

3:55 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

pertusus@free.fr changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:36 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From updates@fedoraproject.org 2008-05-12 11:06 EST ------- html2ps-1.0-0.1.b5.fc8 has been submitted as an update for Fedora 8

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:37 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From updates@fedoraproject.org 2008-05-12 11:07 EST ------- html2ps-1.0-0.1.b5.fc9 has been submitted as an update for Fedora 9

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

29 May 29 May

8:07 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From updates@fedoraproject.org 2008-05-28 22:37 EST ------- html2ps-1.0-0.1.b5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

8:21 a.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: html2ps - HTML to PostScript converter

https://bugzilla.redhat.com/show_bug.cgi?id=443177

------- Additional Comments From updates@fedoraproject.org 2008-05-28 22:51 EST ------- html2ps-1.0-0.1.b5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5 Sep 5 Sep

4:15 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=443177

Petr Pisar ppisar@redhat.com changed:

--- Comment #16 from Petr Pisar ppisar@redhat.com 2010-09-05 06:45:20 EDT --- Package Change Request ====================== Package Name: html2ps New Branches: el6 Owners: tremble ppisar

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:03 p.m.

New subject: [Bug 443177] Review Request: html2ps - HTML to PostScript converter

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=443177

--- Comment #17 from Kevin Fenzi kevin@tummy.com 2010-09-05 13:33:25 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5434

Age (days ago)

6304

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla