https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Bug ID: 2334210 Summary: Review Request: python-einops - Deep learning operations reinvented Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: Tom.Rix@amd.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://trix.fedorapeople.org/python-einops.spec SRPM URL: https://trix.fedorapeople.org/python-einops-0.8.0-1.fc42.src.rpm
Flexible and powerful tensor operations for readable and reliable code. Supports numpy, pytorch, tensorflow, jax, and others.
This is a build requires for ComfyUI
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2333656 Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2333656 [Bug 2333656] Review Request: python-comfyui - The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/arogozhn | |ikov/einops Keywords| |AutomationTriaged
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8449783 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org CC| |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Tests are available in the GitHub repository. Would be better to package from that than from PyPi.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #3 from Tom.Rix@amd.com --- Spec URL: https://trix.fedorapeople.org/python-einops.spec SRPM URL: https://trix.fedorapeople.org/python-einops-0.8.0-1.fc42.src.rpm
Changed source to get the tests, but running them requires using --enable-network
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2064884 --> https://bugzilla.redhat.com/attachment.cgi?id=2064884&action=edit The .spec file difference from Copr build 8449783 to 8474966
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|AutomationTriaged |
--- Comment #5 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8474966 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #6 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 48 files have unknown license. Detailed output of licensecheck in /FedoraPackaging/reviews/python-einops/2334210-python- einops/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 12382 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-einops-0.8.0-1.fc42.noarch.rpm python-einops-0.8.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpf4sapv1l')] checks: 32, packages: 2
python-einops.src: E: spelling-error ('numpy', '%description -l en_US numpy -> bumpy, lumpy, dumpy') python-einops.src: E: spelling-error ('pytorch', '%description -l en_US pytorch -> PyTorch') python-einops.src: E: spelling-error ('tensorflow', '%description -l en_US tensorflow -> tensor flow, tensor-flow, TensorFlow') python-einops.src: E: spelling-error ('jax', '%description -l en_US jax -> ax, Ajax, sax') python3-einops.noarch: E: spelling-error ('numpy', '%description -l en_US numpy -> bumpy, lumpy, dumpy') python3-einops.noarch: E: spelling-error ('pytorch', '%description -l en_US pytorch -> PyTorch') python3-einops.noarch: E: spelling-error ('tensorflow', '%description -l en_US tensorflow -> tensor flow, tensor-flow, TensorFlow') python3-einops.noarch: E: spelling-error ('jax', '%description -l en_US jax -> ax, Ajax, sax') 2 packages and 0 specfiles checked; 8 errors, 0 warnings, 7 filtered, 8 badness; has taken 1.3 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python3-einops.noarch: E: spelling-error ('numpy', '%description -l en_US numpy -> bumpy, lumpy, dumpy') python3-einops.noarch: E: spelling-error ('pytorch', '%description -l en_US pytorch -> PyTorch') python3-einops.noarch: E: spelling-error ('tensorflow', '%description -l en_US tensorflow -> tensor flow, tensor-flow, TensorFlow') python3-einops.noarch: E: spelling-error ('jax', '%description -l en_US jax -> ax, Ajax, sax') 1 packages and 0 specfiles checked; 4 errors, 0 warnings, 3 filtered, 4 badness; has taken 0.5 s
Source checksums ---------------- https://github.com/arogozhnikov/einops/archive/v0.8.0.tar.gz#/einops-0.8.0.t... : CHECKSUM(SHA256) this package : 375c91d19ef91eb9456aef3bd536ffa0b3d3841081bf8f8011eaee00c2511bed CHECKSUM(SHA256) upstream package : 375c91d19ef91eb9456aef3bd536ffa0b3d3841081bf8f8011eaee00c2511bed
Requires -------- python3-einops (rpmlib, GLIBC filtered): python(abi)
Provides -------- python3-einops: python-einops python3-einops python3.13-einops python3.13dist(einops) python3dist(einops)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2334210 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Ocaml, PHP, C/C++, SugarActivity, fonts, R, Java, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) May want to package some of the documentation. Possibly as pdf https://github.com/mkdocs/catalog?tab=readme-ov-file#-site-conversion-pdfepu... or man pages: https://pypi.org/project/mkdocs-manpage/ Happy to help get one of the plugins into Fedora. This does not block the current review. b) A build with tests can be found at https://koji.fedoraproject.org/koji/taskinfo?taskID=127642836 will attach sample spec file. Array_api tests seem like they should pass, maybe a fix is needed upstream? Numpy 2.0 has this functionality enabled, but it is in the main namespace: https://numpy.org/doc/stable/reference/array_api.html Consider raising issues for unexplainable failing tests upstream so users do not get broken functionality. Document these in the spec file so cn check when upgrading to the next release. c) Please change BuildArch: noarch to BuildArch: noarch # Restriction due to pytorch dependency ExclusiveArch: x86_64 aarch64
You may consider defining an RPM macro pytorch_arches so that if more architectures become supported, changes will not be required in all the spec files that have pytorch as a dependency.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #7 from Benson Muite benson_muite@emailplus.org --- Created attachment 2065094 --> https://bugzilla.redhat.com/attachment.cgi?id=2065094&action=edit Suggestions for changes to spec file
Comments can be cleaned up, ideally links to upstream bug reports would also be added.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #8 from Tom.Rix@amd.com --- Spec URL: https://trix.fedorapeople.org/python-einops.spec SRPM URL: https://trix.fedorapeople.org/python-einops-0.8.0-1.fc42.src.rpm
a) docs : Passing on adding documents, imo generating documents is brittle and if not do them unless needed b) array_api : Fixed in the upsteam, handled with sed in %prep c) exclusive arch : Done.
I have considered doing a macro for pytorch for this, but atm it is the only item, though i would do it if the arches in pytorch changed. no one has expressed interest in anything but x86_64 and aarch64.
Thanks for pattern on how to disable tests. I added the failure line so they could be reevaluted at a later time.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #9 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2065603 --> https://bugzilla.redhat.com/attachment.cgi?id=2065603&action=edit The .spec file difference from Copr build 8474966 to 8506086
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
--- Comment #10 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8506086 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #11 from Benson Muite benson_muite@emailplus.org --- Thanks. Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #12 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-einops
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Sergio Pascual sergio.pasra@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1011110 (ML-SIG) CC| |trix@redhat.com
--- Comment #13 from Sergio Pascual sergio.pasra@gmail.com --- *** Bug 2255637 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1011110 [Bug 1011110] Machine Learning SIG - review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=2334210
Tom.Rix@amd.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|RELEASE_PENDING |CLOSED Last Closed| |2025-04-09 12:58:16
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com