[Bug 695022] New: Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pygtkhelpers - assists the building of PyGTK applications

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Summary: Review Request: pygtkhelpers - assists the building of
                    PyGTK applications
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL:
http://lzap.fedorapeople.org/fedora-packaging/pygtkhelpers/0.4.2-1/pygtkhelp...
SRPM URL:
http://lzap.fedorapeople.org/fedora-packaging/pygtkhelpers/0.4.2-1/pygtkhelp...
Description: PyGTKHelpers is a library to assist the building of PyGTK
applications. 
It is intentionally designed to be non-frameworky, and blend well with 
your particular style of PyGTK development.

$ rpmlint pygtkhelpers-0.4.2-1.f15.src.rpm 
pygtkhelpers.src: W: spelling-error %description -l en_US frameworky ->
framework, frameworks, framework y
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint pygtkhelpers-0.4.2-1.fc14.i686.rpm 
pygtkhelpers.i686: W: spelling-error %description -l en_US frameworky ->
framework, frameworks, framework y
pygtkhelpers.i686: E: no-binary
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

http://koji.fedoraproject.org/koji/taskinfo?taskID=2988564

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Vivek Shah  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |651853

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Vivek Shah  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Vivek Shah  2011-04-10 05:07:55 EDT ---
Hi,
    I tried updating to the latest version of pida, but it depends on
pygtkhelpers in order to run. Can you please get this package through soon, so
that I can push it in.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Thomas Spura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Thomas Spura  2011-04-10 16:40:21 EDT ---
(In reply to comment #1)
> Hi,
>     I tried updating to the latest version of pida, but it depends on
> pygtkhelpers in order to run. Can you please get this package through soon, so
> that I can push it in.

How about reviewing it then? ;)

The spec looks fine on a brief view, except the "Requires: python(abi) = 2.7".
That's added automatically and, when python gets an update to an other version
than 2.7, this won't work anymore.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Fabian Affolter  2011-04-11 03:09:37 EDT ---
Just some quick comments:

- The website and the LICENSE.txt claims that the license is LGPL and not GPL.
- There are examples in the source. Wouldn't it be a good idea to put those
examples in a subpackage?
- The '%{!?python_sitearch:...' line is not needed.
- I don't think that console.py needs 755. Removing the shebang can calm
rpmlint down.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #4 from Lukáš Zapletal  2011-04-14 16:11:10 EDT ---
All done. Please do formal review, thank you.

[lzap@lzapx i686]$ rpmlint pygtkhelpers-*.rpm
pygtkhelpers.i686: W: spelling-error %description -l en_US frameworky ->
framework, frameworks, framework y
pygtkhelpers.i686: E: no-binary
pygtkhelpers-debuginfo.i686: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 1 warnings.

[lzap@lzapx SRPMS]$ rpmlint pygtkhelpers-0.4.2-2.f15.src.rpm 
pygtkhelpers.src: W: spelling-error %description -l en_US frameworky ->
framework, frameworks, framework y
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

http://lzap.fedorapeople.org/fedora-packaging/pygtkhelpers/0.4.2-2/

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #5 from Thomas Spura  2011-04-14 16:41:46 EDT ---
(In reply to comment #4)
> [lzap@lzapx i686]$ rpmlint pygtkhelpers-*.rpm
> pygtkhelpers.i686: W: spelling-error %description -l en_US frameworky ->
> framework, frameworks, framework y
> pygtkhelpers.i686: E: no-binary
> pygtkhelpers-debuginfo.i686: E: empty-debuginfo-package
> 3 packages and 0 specfiles checked; 2 errors, 1 warnings.

This package only installs into %{python_sitelib} and not in
%{python_sitearch}, so this package can be noarch and no debuginfo package will
be generated.

I think the license is unclear...

The website links to LGPLv3 and there is a LGPLv3 LICENSE file in it, but the
header say LGPLv2+, it would be best to clarify that.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #6 from Lukáš Zapletal  2011-04-15 05:06:07 EDT ---
Upstream contacted for the clarification.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Jon Ciesla  2011-10-11 12:58:20 EDT ---
Any update?

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #8 from Jon Ciesla  2011-10-29 14:27:39 EDT ---
Ping?  python-logbook is in, this is the only blocker for latest pida now.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #9 from Jon Ciesla  2011-10-29 14:30:08 EDT ---
Though, thinking about it, if the headers say, LGPLv2+, and the website says
LPGLv3, I would think you could just call it LGPLv3, include the license file,
and be done with it. Block FE-LEGAL for review if you're not sure.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #10 from Jon Ciesla  2011-11-17 08:23:47 EST ---
Ping?

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #11 from Jon Ciesla  2011-12-13 08:09:41 EST ---
Ping?  I'd really like to fix PIDA. . .

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #12 from Thomas Spura  2011-12-13 08:41:17 EST ---
(In reply to comment #11)
> Ping?  I'd really like to fix PIDA. . .

This looks stalled. How about requesting a new review and closing this as a
duplicate of the new one, Jon?

(In reply to comment #0)
> Spec URL:
> http://lzap.fedorapeople.org/fedora-packaging/pygtkhelpers/0.4.2-1/pygtkhelp...

Looks ok without having a deeper look.

Some comments:
- R: on a hardcoded python version is bad.
  The R on the python(abi) is added automatically anyway, so leaving it out
would be the best...

- There is no BuildRoot defined, but %clean and rm -rf in %install.
  All is needed for builting in el5 and nothing is needed in Fedora, so you can
choose what to do here.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

--- Comment #13 from Jon Ciesla  2011-12-13 09:07:13 EST ---
Will do.  I have a -2, so I'll modify that to a -3 and post it.

[Bug 695022] Review Request: pygtkhelpers - assists the building of PyGTK applications

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=695022

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |DUPLICATE
        Last Closed|                            |2011-12-13 09:09:33

--- Comment #14 from Jon Ciesla  2011-12-13 09:09:33 EST ---

*** This bug has been marked as a duplicate of bug 767185 ***