[Bug 1384048] New: Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask - package-review

List overview All Threads
Download

newer

[Bug 1384048] New: Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

older

[Bug 1330833] New: Review Request:...

[Bug 1599312] New: Review...

Red Hat Bugzilla

12 Oct 2016 12 Oct '16

12:23 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

Bug ID: 1384048 Summary: Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: david.hannequin@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-A... SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-A...

Description: Flask-APScheduler is a Flask extension which adds support for the APScheduler. Fedora Account System Username: hvad

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

12 Nov 12 Nov

6:42 p.m.

New subject: [Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl

--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Please extend the %description...

Lowercase name, please [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuideline...].

The same comments about repeated %description and Summary apply. .egginfo doesn't need to be deleted.

%license LICENSE is missing.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

23 Nov 23 Nov

3:02 p.m.

New subject: [Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #2 from David Hannequin david.hannequin@gmail.com --- Hi,

I fix rpm here :

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-A...

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask-A...

LICENSE file doesn't exist.

Thanks

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:55 p.m.

New subject: [Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #3 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)

...

Lowercase name, please [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging: NamingGuidelines#General_Naming].

...

Please extend the %description...

What is APSscheduler? The description should say two or three sentences about the package, not just repeat the Summary in different word order.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

18 Jun 18 Jun

8:25 p.m.

New subject: [Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #4 from David Hannequin david.hannequin@gmail.com --- Hi,

I fix naming :

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-a...

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-a...

Could you approve this package ?

Best regard

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

1 Oct 1 Oct

3:03 p.m.

New subject: [Bug 1384048] Review Request: python-Flask-APScheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

Robert-André Mauchin zebob.m@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com

--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- (In reply to David Hannequin from comment #2)

...

Hi,

I fix rpm here :

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask- APScheduler.spec

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-Flask- APScheduler-1.5.0-1.fc25.src.rpm

LICENSE file doesn't exist.

Thanks

LICENSE file does exist in the repo. Add it as a Source:

https://raw.githubusercontent.com/viniciuschiele/flask-apscheduler/master/LI...

Please update the description as asked by Zbigniew and I'll finish the review.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

15 Oct 15 Oct

5:15 p.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

David Hannequin david.hannequin@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

19 Oct 19 Oct

8:47 p.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #6 from David Hannequin david.hannequin@gmail.com --- Hi,

I add license and update description :

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-a...

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-a...

Best regard

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

9:34 p.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #7 from Robert-André Mauchin zebob.m@gmail.com --- Not working like this. First grab the file directly from the repo:

#https://github.com/viniciuschiele/flask-apscheduler/issues/57 Source1: https://raw.githubusercontent.com/viniciuschiele/flask-apscheduler/master/LI...

In %prep add:

cp %{SOURCE1} .

Then

%files -n python2-flask-apscheduler %doc README.rst %license LICENSE /usr/share/licenses/python2-flask-apscheduler/LICENSE %{python2_sitelib}/flask_apscheduler %{python2_sitelib}/Flask_APScheduler-%{version}-py*egg-info

%files -n python3-flask-apscheduler %doc README.rst %license LICENSE %{python3_sitelib}/flask_apscheduler %{python3_sitelib}/Flask_APScheduler-%{version}-py*egg-info

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

22 Oct 22 Oct

9:55 a.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #8 from David Hannequin david.hannequin@gmail.com --- Hi,

I add licence with your advise. Thank you.

Spec URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-a...

SRPM URL: https://hvad.fedorapeople.org/fedora/python-Flask-APScheduler/python-flask-a...

Best regard

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

12:04 p.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

--- Comment #9 from Robert-André Mauchin zebob.m@gmail.com --- I've proceeded with the review but I encountered problems with the tests. They need BR to run:

BuildRequires: python2-setuptools BuildRequires: python2-devel BuildRequires: python2-flask BuildRequires: python2-APScheduler BuildRequires: python2-dateutil

BuildRequires: python3-setuptools BuildRequires: python3-devel BuildRequires: python3-flask BuildRequires: python3-APScheduler BuildRequires: python3-dateutil

Moreover the tests need apscheduler>=3.2.0:

+ /usr/bin/python2 setup.py test running test Searching for apscheduler>=3.2.0 Reading https://pypi.python.org/simple/apscheduler/

However the latest version available on Rawhide is 3.0.5. You need to ask the maintainer (Paul Belanger pabelanger) to update to a more recent version.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

10 Mar 10 Mar

3:26 p.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048

Itamar Reis Peixoto itamar@ispbrasil.com.br changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1505086 [Bug 1505086] python-APScheduler-3.5.1 is available

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

bugzilla＠redhat.com

20 Aug 20 Aug

1:40 p.m.

New subject: [Bug 1384048] Review Request: python-flask-apscheduler - Adds APScheduler support to Flask

https://bugzilla.redhat.com/show_bug.cgi?id=1384048 Bug 1384048 depends on bug 1505086, which changed state.

Bug 1505086 Summary: python-APScheduler-3.5.3 is available https://bugzilla.redhat.com/show_bug.cgi?id=1505086

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

2139

Age (days ago)

2816

Last active (days ago)

package-review@lists.fedoraproject.org

12 comments

2 participants

tags (0)

participants (2)

bugzilla＠redhat.com
Red Hat Bugzilla