[Bug 467644] New: Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sugar-memorize - Memorize for Sugar

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Summary: Review Request: sugar-memorize - Memorize for Sugar
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize.spec
SRPM URL:
http://fab.fedorapeople.org/packages/XO/sugar-memorize-28-1.fc10.src.rpm

Description:
The game memorize is about finding matching pairs. A pair can consist of any
multimedia object. At the moment these are images, sounds and text but this
could be extended to animations or movie snippets as well. Which pairs do 
match is up to the creator of the game. Memorize is actually more than just
a predefined game you can play, it allows you to create new games yourself
as well.

Koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=888662

[fab@localhost noarch]$ rpmlint -i sugar-memorize-28-1.fc10.noarch.rpm 
sugar-memorize.noarch: W: non-standard-group Sugar/Activities
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[fab@localhost SRPMS]$ rpmlint -i sugar-memorize-28-1.fc10.src.rpm 
sugar-memorize.src: W: non-standard-group Sugar/Activities
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
"Applications/Communications", "Applications/Databases",
"Applications/Editors", "Applications/Emulators", "Applications/Engineering",
"Applications/File", "Applications/Internet", "Applications/Multimedia",
"Applications/Productivity", "Applications/Publishing", "Applications/System",
"Applications/Text", "Development/Debug", "Development/Debuggers",
"Development/Languages", "Development/Libraries", "Development/System",
"Development/Tools", "Documentation", "System Environment/Base", "System
Environment/Daemons", "System Environment/Kernel", "System
Environment/Libraries", "System Environment/Shells", "User
Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Simon Schampijer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Simon Schampijer   2008-10-20 03:45:44 EDT ---
To play sounds memorize is dependent on csound. The fedora csound package does
not contain the opcode to play ogg vorbis AFAIK
http://koji.fedoraproject.org/koji/buildinfo?buildID=33799. OLPC is using a
specialized csound package
http://koji.fedoraproject.org/koji/packageinfo?packageID=6247 which contains
this opcode. Not sure yet how best to go forward, have to examine in more
detail.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Peter Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Blocks|                            |462625

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #2 from Fabian Affolter   2008-11-13 07:08:03 EDT ---
One way would probably be to integrate sugar-memorize with no sound in Fedora
for now.  And fix this in the near future.

There was a patch added to csound (named csound-5.03.0-add-oggplay.patch),
maybe this solve the problem but I didn't investigate this further.
http://koji.fedoraproject.org/koji/rpminfo?rpmID=205447

The current version of csound is 5.09.  At the moment available for Fedora
5.07.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #3 from Simon Schampijer   2008-11-13 13:31:49 EDT ---
Uploaded a new tarball - and fixed all the permission bits etc. so you can
remove all of those :)
http://dev.laptop.org/pub/sugar/sources/Memorize/Memorize-29.tar.bz2

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Simon Schampijer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #4 from Simon Schampijer   2008-11-13 13:48:56 EDT ---
re: csound: I am ok with leaving the sound support out for now - but we should
make sure we keep on working on that - would be nice to have - also we have to
inspect sound support anyhow since we don't run pulseaudio on the XO.

The patch you showed should work - i wrote that one - but it was added to the
olpc-2 build only and we could make sure as well to update to the latest csound
sources - as they contain the patch AFAIK.

r+ anyway - when removing the hacks i fixed in the sources.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #5 from Fabian Affolter   2008-11-18 19:12:00 EDT ---
Update

Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize.spec
SRPM URL:
http://fab.fedorapeople.org/packages/XO/sugar-memorize-29-1.fc10.src.rpm
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=938635

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #6 from Fabian Affolter   2008-11-18 19:50:15 EDT ---
Simon, did you do a full review? I'm just asking because the flag is set to '+'
but the bug is not assigned to you.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Simon Schampijer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail]    |[e-mail]

--- Comment #7 from Simon Schampijer   2008-11-19 03:45:22 EDT ---
Yup I did a full review. In the spec you posted above - the comment says that
this is removed but it is still present :)

{{{
#delete hidden files
find %{buildroot} -name '.*' -exec rm -f {} ';'
#wrong end-line-encoding
#sed -i 's/\r//'
%{buildroot}%{sugaractivitydir}Memorize.activity/images/stock-buddy.svg
#fix rpmlint non-executable-script error
#find %{buildroot}%{sugaractivitydir}Memorize.activity/*.py -type f | xargs
chmod a+x
#find %{buildroot}%{sugaractivitydir}Memorize.activity/csound/csoundserver.py
-type f | xargs chmod a+x
#remove exec bit
#find %{buildroot}%{sugaractivitydir}Memorize.activity/images/*.svg -type f
-name * -exec chmod 644 {} ;
}}}

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #8 from Fabian Affolter   2008-11-20 03:30:13 EDT ---
Like in the other review, I have to repost the spec file and the SRPM.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #9 from Fabian Affolter   2008-11-20 16:49:19 EDT ---
again,

Spec URL: http://fab.fedorapeople.org/packages/XO/sugar-memorize.spec
SRPM URL:
http://fab.fedorapeople.org/packages/XO/sugar-memorize-29-1.fc10.src.rpm

Thanks for your patience

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #10 from Simon Schampijer   2008-11-20 16:53:53 EDT ---
You have uncommented the lines now - shouldn't we just remove them?

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #11 from Simon Schampijer   2008-11-20 17:03:13 EDT ---
Oh, maybe you wanted to keep it for the git checkout - i have fixed all the
upstream sources - so we are save now. I guess it is time to request CVS
branches now http://fedoraproject.org/wiki/CVSAdminProcedure :)

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #12 from Fabian Affolter   2008-11-20 18:29:08 EDT ---
Thanks Simon. I will remove the lines before cvs check-in.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #13 from Fabian Affolter   2008-11-20 18:30:12 EDT ---
New Package CVS Request
=======================
Package Name:   sugar-memorize
Short Description:  Memorize for Sugar
Owners:  fab
Branches: F-10
InitialCC:

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #14 from Kevin Fenzi   2008-11-22 23:28:52 EDT ---
cvs done.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Marco Pesenti Gritti  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Marco Pesenti Gritti   2008-11-29 12:00:30 EDT ---
Awesome, this is something we would like to have for Soas:

http://dev.sugarlabs.org/ticket/65

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #16 from Fedora Update System   2008-11-30 08:44:18 EDT ---
sugar-memorize-29-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/sugar-memorize-29-1.fc10

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #17 from Fedora Update System   2008-12-02 20:20:42 EDT ---
sugar-memorize-29-1.fc10 has been pushed to the Fedora 10 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sugar-memorize'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2008-10608

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

--- Comment #18 from Fedora Update System   2008-12-09 06:32:18 EDT ---
sugar-memorize-29-1.fc10 has been pushed to the Fedora 10 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 467644] Review Request: sugar-memorize - Memorize for Sugar

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=467644

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|                            |NEXTRELEASE