[Bug 868940] New: Review Request: s3ql - Full-Featured File System for Online Data Storage
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Bug ID: 868940 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: s3ql - Full-Featured File System for Online Data Storage Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: maci@satgnu.net Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-1.fc17.src.rpm Description: S3QL is a file system that stores all its data online using storage services like Google Storage, Amazon S3 or OpenStack. S3QL effectively provides a hard disk of dynamic, infinite capacity that can be accessed from any computer with Internet access.
S3QL is a standard conforming, full featured UNIX file system that is conceptually indistinguishable from any local file system. Furthermore, S3QL has additional features like compression, encryption, data de-duplication, immutable trees and snapshotting which make it especially suitable for on-line backup and archival.
S3QL is designed to favor simplicity and elegance over performance and feature- creep. Care has been taken to make the source code as readable and serviceable as possible. Solid error detection and error handling have been included from the very first line, and S3QL comes with extensive automated test cases for all its components. Fedora Account System Username: maci Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4615586
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Marcel Wysocki maci@satgnu.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |868936, 868939
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #1 from Marcel Wysocki maci@satgnu.net --- Update:
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-2.fc17.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m
--- Comment #2 from Mario Blättermann mario.blaettermann@gmail.com --- The source tarball contains a bundled egg-info. Please remove it before building your package (in the %prep section):
rm -rf src/llfuse.egg-info
Maybe you have to add python-setuptools to BR.
See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more information.
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #3 from Mario Blättermann mario.blaettermann@gmail.com --- Sorry for the blurb, this is the wrong bug...
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #4 from Marcel Wysocki maci@satgnu.net --- Update:
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-3.fc17.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4643936
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #5 from Marcel Wysocki maci@satgnu.net --- Update:
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-4.fc17.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4646462 http://koji.fedoraproject.org/koji/taskinfo?taskID=4646480
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #6 from Mario Blättermann mario.blaettermann@gmail.com --- $ rpmlint -i -v * s3ql.src: I: checking s3ql.src: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.src: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.src: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
s3ql.src: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 (timeout 10 seconds) s3ql.src: W: invalid-url Source0: http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
s3ql.i686: I: checking s3ql.i686: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.i686: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.i686: W: private-shared-object-provides /usr/lib/python2.7/site-packages/s3ql/_deltadump.so _deltadump.so A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator.
s3ql.i686: W: no-manual-page-for-binary s3ql_backup Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-fsck_db Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-expire_backups Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-benchmark Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-pcp Each executable in standard binary directories should have a man page.
s3ql.x86_64: I: checking s3ql.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.x86_64: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/s3ql/_deltadump.so _deltadump.so()(64bit) A shared object soname provides is provided by a file in a path from which other packages should not directly load shared objects from. Such shared objects should thus not be depended on and they should not result in provides in the containing package. Get rid of the provides if appropriate, for example by filtering it out during build. Note that in some cases this may require disabling rpmbuild's internal dependency generator.
s3ql.x86_64: W: no-manual-page-for-binary s3ql_backup Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-fsck_db Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-expire_backups Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-benchmark Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-pcp Each executable in standard binary directories should have a man page.
s3ql-debuginfo.i686: I: checking s3ql-debuginfo.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql-debuginfo.x86_64: I: checking s3ql-debuginfo.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 24) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
s3ql.spec: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 (timeout 10 seconds) s3ql.spec: W: invalid-url Source0: http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
5 packages and 1 specfiles checked; 0 errors, 22 warnings.
As known from python-apsw and python-llfuse: Please filter out the mentioned private libraries.
Don't mix spaces and tabs. I recommend to use spaces, because the spec file looks the same in all editors, independent from the configured tab width.
The source tarball contains a bundled egg-info. Please remove it before building your package (in the %prep section):
rm -rf src/%{name}.egg-info
See https://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs for more information.
Regarding the explicit runtime requirements, the following rule of thumb should be useful: If package foo-devel is in BuildRequires, then adding foo to Requires is not needed. Try to remove all the runtime deps and build your package again. All what's not picked up automatically, add again.
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #7 from Marcel Wysocki maci@satgnu.net --- i tried cleaning up deps and builddeps as much as possible also added filtering and removed the eggs
Update:
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-5.fc17.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4649042
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mario.blaettermann@gmail.co | |m Flags| |fedora-review?
--- Comment #8 from Mario Blättermann mario.blaettermann@gmail.com --- $ rpmlint -i -v * s3ql.i686: I: checking s3ql.i686: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.i686: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.i686: W: no-manual-page-for-binary s3ql_backup Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-fsck_db Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-expire_backups Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-benchmark Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-pcp Each executable in standard binary directories should have a man page.
s3ql.src: I: checking s3ql.src: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.src: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.src: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.src: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 (timeout 10 seconds) s3ql.src: W: invalid-url Source0: http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
s3ql.x86_64: I: checking s3ql.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.x86_64: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.x86_64: W: no-manual-page-for-binary s3ql_backup Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-fsck_db Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-expire_backups Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-benchmark Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-pcp Each executable in standard binary directories should have a man page.
s3ql-debuginfo.i686: I: checking s3ql-debuginfo.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql-debuginfo.x86_64: I: checking s3ql-debuginfo.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.spec: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 (timeout 10 seconds) s3ql.spec: W: invalid-url Source0: http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
5 packages and 1 specfiles checked; 0 errors, 18 warnings.
Ignorable warnings. Googlecode URL is valid, missing man pages (not up to you to add them), some false positive spelling errors.
Still one objection:
%{python_sitearch}/%{name}/*
This means, your package doesn't own the folder /usr/lib/python2.7/site-packages/s3ql/. To change this, use
%dir %{python_sitearch}/%{name} %{python_sitearch}/%{name}/*
or just
%{python_sitearch}/%{name}
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #9 from Marcel Wysocki maci@satgnu.net --- thank you really much for all your patience, soon all the packages are in updates-testing :)
fixed it by using %{python_sitearch}/%{name}* this way i dont need to specify the eggs directory as well
Update:
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-6.fc17.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4649831 http://koji.fedoraproject.org/koji/taskinfo?taskID=4649832
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #10 from Marcel Wysocki maci@satgnu.net --- - python-argparse is provided by python-libs, remove it from requires
Update:
Spec URL: http://maci.satgnu.net/rpmbuild/SPECS/s3ql.spec SRPM URL: http://maci.satgnu.net/rpmbuild/SRPMS/s3ql-1.12-7.fc17.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4649966 http://koji.fedoraproject.org/koji/taskinfo?taskID=4649965
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #11 from Marcel Wysocki maci@satgnu.net --- Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4649983 http://koji.fedoraproject.org/koji/taskinfo?taskID=4649984
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #12 from Mario Blättermann mario.blaettermann@gmail.com --- $ rpmlint -i -v * s3ql.src: I: checking s3ql.src: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.src: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.src: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.src: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 (timeout 10 seconds) s3ql.src: W: invalid-url Source0: http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
s3ql.i686: I: checking s3ql.i686: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.i686: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.i686: W: no-manual-page-for-binary s3ql_backup Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-fsck_db Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-expire_backups Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-benchmark Each executable in standard binary directories should have a man page.
s3ql.i686: W: no-manual-page-for-binary s3ql-pcp Each executable in standard binary directories should have a man page.
s3ql.x86_64: I: checking s3ql.x86_64: W: spelling-error %description -l en_US de -> DE, ed, d The value of this tag appears to be misspelled. Please double-check.
s3ql.x86_64: W: spelling-error %description -l en_US snapshotting -> snaps hotting, snaps-hotting, snapshot ting The value of this tag appears to be misspelled. Please double-check.
s3ql.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.x86_64: W: no-manual-page-for-binary s3ql_backup Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-fsck_db Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-expire_backups Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-benchmark Each executable in standard binary directories should have a man page.
s3ql.x86_64: W: no-manual-page-for-binary s3ql-pcp Each executable in standard binary directories should have a man page.
s3ql-debuginfo.i686: I: checking s3ql-debuginfo.i686: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql-debuginfo.x86_64: I: checking s3ql-debuginfo.x86_64: I: checking-url http://code.google.com/p/s3ql/ (timeout 10 seconds) s3ql.spec: I: checking-url http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 (timeout 10 seconds) s3ql.spec: W: invalid-url Source0: http://s3ql.googlecode.com/files/s3ql-1.12.tar.bz2 HTTP Error 404: Not Found The value should be a valid, public HTTP, HTTPS, or FTP URL.
5 packages and 1 specfiles checked; 0 errors, 18 warnings.
Nothing of interest.
--------------------------------- key:
[+] OK [.] OK, not applicable [X] needs work ---------------------------------
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review. [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [+] MUST: The License field in the package spec file must match the actual license. GPLv3 [+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this. $ sha256sum * e9cb22b91bbe372536d064862d893f3ac7c2c448a8760eec998dea7ba39ca451 s3ql-1.12.tar.bz2 e9cb22b91bbe372536d064862d893f3ac7c2c448a8760eec998dea7ba39ca451 s3ql-1.12.tar.bz2.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. [.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. [.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. [.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [+] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations) [+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity). [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present. [.] MUST: Static libraries must be in a -static package. [.] MUST: Development files must be in a -devel package. [.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release} [.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. [+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time. [+] MUST: All filenames in rpm packages must be valid UTF-8.
[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses Mock anyway). [+] SHOULD: The package should compile and build into binary rpms on all supported architectures. [.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example. [+] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. [+] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.
----------------
PACKAGE APPROVED
----------------
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Marcel Wysocki maci@satgnu.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #13 from Marcel Wysocki maci@satgnu.net --- New Package SCM Request ======================= Package Name: s3ql Short Description: Full-Featured File System for Online Data Storage Owners: maci Branches: f17 f18 f19 el6 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #14 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- s3ql-1.12-7.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/s3ql-1.12-7.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- s3ql-1.12-7.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/s3ql-1.12-7.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=868940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- s3ql-1.12-7.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868940
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-11-14 21:28:14
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868940
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- s3ql-1.12-7.fc17 has been pushed to the Fedora 17 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868940
Bug 868940 depends on bug 868939, which changed state.
Bug 868939 Summary: Review Request: python-llfuse - Python Bindings for the low-level FUSE API https://bugzilla.redhat.com/show_bug.cgi?id=868939
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=868940
Bug 868940 depends on bug 868936, which changed state.
Bug 868936 Summary: Review Request: python-apsw - Another Python SQLite Wrapper https://bugzilla.redhat.com/show_bug.cgi?id=868936
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla