https://bugzilla.redhat.com/show_bug.cgi?id=2268579
Bug ID: 2268579 Summary: Review Request: python-jsonformatter - Formatter to output json logs Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: manisandro@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://smani.fedorapeople.org/review/python-jsonformatter.spec SRPM URL: https://smani.fedorapeople.org/review/python-jsonformatter-0.3.2-1.fc41.src.... Description: Formatter to output json logs Fedora Account System Username: smani
https://bugzilla.redhat.com/show_bug.cgi?id=2268579
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |gui1ty@penguinpee.nl Status|NEW |ASSIGNED CC| |gui1ty@penguinpee.nl Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Sandro gui1ty@penguinpee.nl --- I'm taking this.
https://bugzilla.redhat.com/show_bug.cgi?id=2268579
--- Comment #2 from Sandro gui1ty@penguinpee.nl --- Notes =====
=> You have unused global variables, `uap_core_version` and `run_unittests` defined in the spec file. What are these for? Or did you forget to clean them up? Adding a comment might help.
Not blocking the review, since this doesn't impact the build.
[x]: License field in the package spec file matches the actual license.
=> You could make use of the new `-l` flag to `%pyproject_save_files`. That makes sure a license is present in the installed package and saves you from having to add `%license` in `%files`. The license file is now duplicated (see rpm -q --licensefile).
This is not a blocker, just a note.
[ ]: Package consistently uses macros
=> You are dropping the ball towards the end. Why not use `%{pkg_name}` in `%pyproject_save_files`?
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages.
Rpmlint ------- Checking: python3-jsonformatter-0.3.2-1.fc38.noarch.rpm python-jsonformatter-0.3.2-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpih3pioz8')] checks: 32, packages: 2
python3-jsonformatter.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.11/site-packages/jsonformatter/__init__.py python3-jsonformatter.noarch: E: wrong-script-end-of-line-encoding /usr/lib/python3.11/site-packages/jsonformatter/jsonformatter.py python3-jsonformatter.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/jsonformatter/__init__.py 644 /usr/bin/env python python3-jsonformatter.noarch: E: non-executable-script /usr/lib/python3.11/site-packages/jsonformatter/jsonformatter.py 644 /usr/bin/env python 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 7 filtered, 4 badness; has taken 0.2 s
Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-jsonformatter". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s
Source checksums ---------------- https://github.com/MyColorfulDays/jsonformatter/archive/v0.3.2/jsonformatter... : CHECKSUM(SHA256) this package : 1f4805cb1868de985efcdd8914861b229c95964283ed28cbfb7f63d6edf532d9 CHECKSUM(SHA256) upstream package : 1f4805cb1868de985efcdd8914861b229c95964283ed28cbfb7f63d6edf532d9
Requires -------- python3-jsonformatter (rpmlib, GLIBC filtered): python(abi)
Provides -------- python3-jsonformatter: python-jsonformatter python3-jsonformatter python3.11-jsonformatter python3.11dist(jsonformatter) python3dist(jsonformatter)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name python-jsonformatter --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-38-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, Ocaml, C/C++, Haskell, PHP, R, Perl, Java, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
https://bugzilla.redhat.com/show_bug.cgi?id=2268579
--- Comment #3 from Sandro Mani manisandro@gmail.com --- Thanks for your comments!
Spec URL: https://smani.fedorapeople.org/review/python-jsonformatter.spec SRPM URL: https://smani.fedorapeople.org/review/python-jsonformatter-0.3.2-1.fc41.src....
%changelog * Sat Mar 09 2024 Sandro Mani manisandro@gmail.com - 0.3.2-2 - Cleanup leftovers, use %%pyproject_save_files -l %%{pkg_name}
https://bugzilla.redhat.com/show_bug.cgi?id=2268579
Sandro gui1ty@penguinpee.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Sandro gui1ty@penguinpee.nl --- Looks good! Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=2268579
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST
--- Comment #5 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jsonformatter
https://bugzilla.redhat.com/show_bug.cgi?id=2268579
Sandro Mani manisandro@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2024-03-09 22:45:07
--- Comment #6 from Sandro Mani manisandro@gmail.com --- Thanks for the review!
package-review@lists.fedoraproject.org