[Bug 478300] New: Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-wifi - Python binding for the wireless extensions

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Summary: Review Request: python-wifi - Python binding for the
                    wireless extensions
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-wifi.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-wifi-0.3.1-1.fc9.src.rpm

Project URL: https://developer.berlios.de/projects/pythonwifi/

Description:
Python-Wifi is a Python library that provides access to information about a
W-LAN card's capabilities, like the wireless extensions written in C.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1023011

rpmlint output:
[fab@laptop024 noarch]$ rpmlint python-wifi-0.3.1-1.fc9.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop024 SRPMS]$ rpmlint python-wifi-0.3.1-1.fc9.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |478432

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Debarshi Ray  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #1 from Debarshi Ray   2009-02-11 00:01:47 EDT ---
MUST Items:

OK - rpmlint is clean
OK - follows Naming Guidelines and Python Naming Guidelines
OK - spec file is named as %{name}.spec

xx - package does not meet Packaging Guidelines and Python Packaging Guidelines
    + Is 'Requires: wireless-tools' really needed? I could not locate its use
      in the sources, and it seems to work without it too:
      [rishi@freebook python-wifi-0.3.1]$ sudo rpm --nodeps -e wireless-tools
      [sudo] password for rishi: 
      [rishi@freebook python-wifi-0.3.1]$ python
      Python 2.5.1 (r251:54863, Jun 15 2008, 18:24:56) 
      [GCC 4.3.0 20080428 (Red Hat 4.3.0-8)] on linux2
      Type "help", "copyright", "credits" or "license" for more information.
      >>> from pythonwifi.iwlibs import Wireless
      >>> wifi = Wireless('wlan0')
      >>> wifi.getEssid()
      'prasannakanan'
      >>>
      Am I missing something?

OK - license meets Licensing Guidelines

xx - License field meets actual license
    + Going by the license notices in the source code:
      (i)   examples/pyiwlist.py is under GPLv2+.
      (ii)  examples/pyiwconfig.py, pythonwifi/iwlibs.py, pythonwifi/flags.py
            is under LGPLv2+.
      (iii) the others do not have a license notice.
      Although it looks like the value of the License tag should be LGPLv2+
      it would be good to point out the mix-up to the upstream maintainer.

OK - upstream license file included in %doc
OK - spec file uses American English
OK - spec file is legible

xx - sources match upstream sources
    + The Source0 URL should be

http://pypi.python.org/packages/source/p/%%7Bname%7D/%%7Bname%7D-%%7Bversion...

OK - package builds successfully
OK - ExcludeArch not needed
OK - build dependencies correctly listed
OK - no locales
OK - no shared libraries
OK - package is not relocatable
OK - file and directory ownership
OK - no duplicates in %file
OK - file permissions set properly
OK - %clean present
OK - macros used consistently
OK - contains code and permissable content
OK - -doc is not needed

xx - contents of %doc does not affect the runtime
    + python_wifi.egg-info/SOURCES.txt contains docs/*, examples/* and tests/*.
      I do not know enough about Python Eggs to say whether that is a problem
      or not. Got to find out.

OK - no header files
OK - no static libraries
OK - no pkgconfig files
OK - no library files
OK - -devel not needed
OK - no libtool archives
OK - %{name}.desktop file not needed
OK - does not own files or directories owned by other packages
OK - buildroot correctly prepped
OK - all file names valid UTF-8

SHOULD Items:

OK - upstream provides license text
xx - no translations for description and summary
OK - package builds in mock successfully
OK - package builds on all supported architectures
OK - package functions as expected
OK - scriptlets not needed
OK - subpackages are not needed
OK - no pkgconfig files
OK - no file dependencies

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #2 from Debarshi Ray   2009-02-11 06:34:08 EDT ---
(In reply to comment #1)
> xx - contents of %doc does not affect the runtime
>     + python_wifi.egg-info/SOURCES.txt contains docs/*, examples/* and tests/*.
>       I do not know enough about Python Eggs to say whether that is a problem
>       or not. Got to find out.

According to
http://peak.telecommunity.com/DevCenter/EggFormats#sources-txt-source-files-...:

"In other words, SOURCES.txt has little or no runtime value for being included
in distributed eggs..."

So I would say that this not a problem for us.

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #3 from Fabian Affolter   2009-02-18 17:57:56 EDT ---
Thanks for the review

(In reply to comment #1)
> xx - package does not meet Packaging Guidelines and Python Packaging Guidelines
>     + Is 'Requires: wireless-tools' really needed? I could not locate its use
>       in the sources, and it seems to work without it too:

removed.
> xx - License field meets actual license
>     + Going by the license notices in the source code:
>       (i)   examples/pyiwlist.py is under GPLv2+.
>       (ii)  examples/pyiwconfig.py, pythonwifi/iwlibs.py, pythonwifi/flags.py
>             is under LGPLv2+.
>       (iii) the others do not have a license notice.
>       Although it looks like the value of the License tag should be LGPLv2+
>       it would be good to point out the mix-up to the upstream maintainer.

changed to LGPLv2+
> xx - sources match upstream sources
>     + The Source0 URL should be
>
> http://pypi.python.org/packages/source/p/%%7Bname%7D/%%7Bname%7D-%%7Bversion...

fixed

Updated files:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-wifi.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-wifi-0.3.1-2.fc10.src.rpm

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Debarshi Ray  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Debarshi Ray   2009-02-21 15:26:25 EDT ---
+---------------------------------+
| This package is APPROVED by me. |
+---------------------------------+

Just remember to inform upstream about the licensing mix-up to avoid any future
misunderstanding.

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Fabian Affolter   2009-02-21 18:14:13 EDT ---
https://developer.berlios.de/bugs/?func=detailbug&bug_id=15290&group...

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #6 from Fabian Affolter   2009-02-21 18:15:01 EDT ---
New Package CVS Request
=======================
Package Name: python-wifi
Short Description: Python binding for the wireless extensions
Owners: fab
Branches: F-9 F-10
InitialCC:

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #7 from Debarshi Ray   2009-02-22 05:02:05 EDT ---
(In reply to comment #5)
> https://developer.berlios.de/bugs/?func=detailbug&bug_id=15290&group...

Nice. :-)

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #8 from Kevin Fenzi   2009-02-22 14:39:46 EDT ---
cvs done.

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #9 from Fedora Update System   2009-02-23 17:07:30 EDT ---
python-wifi-0.3.1-2.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/python-wifi-0.3.1-2.fc10

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #10 from Fedora Update System   2009-02-23 17:07:35 EDT ---
python-wifi-0.3.1-2.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/python-wifi-0.3.1-2.fc9

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #11 from Fedora Update System   2009-02-24 15:42:44 EDT ---
python-wifi-0.3.1-2.fc9 has been pushed to the Fedora 9 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing-newkey update python-wifi'.  You can
provide feedback for this update here:
http://admin.fedoraproject.org/updates/F9/FEDORA-2009-1939

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #12 from Fedora Update System   2009-02-24 15:53:26 EDT ---
python-wifi-0.3.1-2.fc10 has been pushed to the Fedora 10 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-wifi'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2002

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #13 from Fedora Update System   2009-03-09 18:52:24 EDT ---
python-wifi-0.3.1-2.fc10 has been pushed to the Fedora 10 stable repository. 
If problems still persist, please make note of it in this bug report.

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |0.3.1-2.fc10
         Resolution|                            |NEXTRELEASE

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

--- Comment #14 from Fedora Update System   2009-03-09 19:06:51 EDT ---
python-wifi-0.3.1-2.fc9 has been pushed to the Fedora 9 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 478300] Review Request: python-wifi - Python binding for the wireless extensions

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478300

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|0.3.1-2.fc10                |0.3.1-2.fc9