[Bug 189048] New: Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Summary: Review Request: perl-CPANPLUS
           Product: Fedora Extras
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: normal
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]

Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-CPANPLUS/perl-CPANPLUS.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-CPANPLUS-0.061-1.src.rpm
Description:
The CPANPLUS library is an API to the CPAN mirrors and a collection of
interactive shells, commandline programs, daemons, etc, that use this API.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |188505, 188519, 188523,
                   |                            |188527, 189040, 189041,
                   |                            |189042, 189043, 189044,
                   |                            |189047

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|[e-mail] |[e-mail]
OtherBugsDependingO|163776                      |163778
              nThis|                            |

------- Additional Comments From [e-mail]  2006-04-15 13:36 EST -------
I think we just need to work out perl-Object-Accessor and perl-File-Fetch and
then I can review this.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 188505, which changed state.

Bug 188505 Summary: Review Request: perl-Locale-Maketext-Simple
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188505

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 188519, which changed state.

Bug 188519 Summary: Review Request: perl-Module-Load
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188519

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

Bug 189048 depends on bug 188523, which changed state.

Bug 188523 Summary: Review Request: perl-Params-Check
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188523

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 188527, which changed state.

Bug 188527 Summary: Review Request: perl-Module-Load-Conditional
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188527

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 188527, which changed state.

Bug 188527 Summary: Review Request: perl-Module-Load-Conditional
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188527

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 189041, which changed state.

Bug 189041 Summary: Review Request: perl-IPC-Cmd
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189041

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 189042, which changed state.

Bug 189042 Summary: Review Request: perl-Archive-Extract
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189042

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 189043, which changed state.

Bug 189043 Summary: Review Request: perl-File-Fetch
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189043

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 189040, which changed state.

Bug 189040 Summary: Review Request: perl-Object-Accessor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189040

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

------- Additional Comments From [e-mail]  2006-04-21 19:36 EST -------
I think we're ready to go on this, when you have time...

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

------- Additional Comments From [e-mail]  2006-04-21 22:39 EST -------
Funny, I was in the middle of the review when you commented....

Issues:
The Requires: filter is:

@@PERL_REQ@@ "$@" | sed -e '/^perl(Your::Module::Here)$/d'

I'm not sure what you wanted to filter there.

rpmlint is unhappy:
E: perl-CPANPLUS useless-explicit-provides perl(CPANPLUS::Config)
W: perl-CPANPLUS hidden-file-or-dir
/usr/lib/perl5/vendor_perl/5.8.8/CPANPLUS/inc/.inc
E: perl-CPANPLUS zero-length /usr/lib/perl5/vendor_perl/5.8.8/CPANPLUS/inc/.inc

I don't quite understand the first error; there is no such explicit Provide: in
the .spec so RPM must be generating it.
I'm not sure wiere the .inc file is coming from or what it's supposed to do.

Review:
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   c9e9831d24d69b1f690d8b4967436899  CPANPLUS-0.061.tar.gz
   c9e9831d24d69b1f690d8b4967436899  CPANPLUS-0.061.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock.
X rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
O %check is present but necessarily disabled.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

------- Additional Comments From [e-mail]  2006-04-22 03:19 EST -------
(In reply to comment #3)
> E: perl-CPANPLUS useless-explicit-provides perl(CPANPLUS::Config)
>
> I don't quite understand the first error; there is no such explicit Provide:
> in the .spec so RPM must be generating it.

I haven't had a look into this particular case, but this rpmlint error is often
seen in cases where a package provides both versioned and unversioned something
(through autoprov or not, doesn't matter).  The unversioned one satisfies all
versioned dependencies people might add in dependent packages, so if there's a
versioned one available, it could make sense to get rid of the unversioned one,
for example by filtering it out.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

------- Additional Comments From [e-mail]  2006-04-22 11:13 EST -------
In this case the issue is:

perl(CPANPLUS::Config)
perl(CPANPLUS::Config) = 0.050

I thought perhaps that's what the non-functioning filter was for, but that's for
requires and this is an errant provide.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 189044, which changed state.

Bug 189044 Summary: Review Request: perl-Log-Message
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189044

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

Bug 189048 depends on bug 189047, which changed state.

Bug 189047 Summary: Review Request: perl-Term-UI
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189047

What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |NEXTRELEASE
             Status|ASSIGNED                    |CLOSED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

------- Additional Comments From [e-mail]  2006-05-06 13:33 EST -------
(In reply to comment #3)
> The Requires: filter is:
>
> @@PERL_REQ@@ "$@" | sed -e '/^perl(Your::Module::Here)$/d'
>
> I'm not sure what you wanted to filter there.

I literally had to filter perl(Your::Module::Here).

CPANPLUS-0.061$ find . -type f -exec grep -Hn Your::Module::Here {} ;
 ./lib/CPANPLUS/Internals/Constants/Report.pm:268:use Your::Module::Here; ok(1);
> rpmlint is unhappy:
> E: perl-CPANPLUS useless-explicit-provides perl(CPANPLUS::Config)

That's auto-generated during rpmbuild, so I think we can ignore that.
> W: perl-CPANPLUS hidden-file-or-dir
> /usr/lib/perl5/vendor_perl/5.8.8/CPANPLUS/inc/.inc
> E: perl-CPANPLUS zero-length /usr/lib/perl5/vendor_perl/5.8.8/CPANPLUS/inc/.inc

Fixed in -2.

http://ftp.kspei.com/pub/steve/rpms/perl-CPANPLUS-0.061-2.src.rpm

Sorry about the rpmlint warnings.  I thought I had checked that before
submitting all of these packages.  I guess I missed one...

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |

------- Additional Comments From [e-mail]  2006-05-06 16:48 EST -------
> I literally had to filter perl(Your::Module::Here).

Hilarious.  Sorry I missed that.
> That's auto-generated during rpmbuild, so I think we can ignore that.

Yes, you don't include it.  I see no point in filtering it as it seems to be an
RPM buglet.
> Fixed in -2.

Thanks.

APPROVED

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

------- Additional Comments From [e-mail]  2006-05-07 06:07 EST -------
(In reply to comment #6)
> Sorry about the rpmlint warnings.  I thought I had checked that before
> submitting all of these packages.  I guess I missed one...

Possibly not; I've had that happen too. I think it's because new versions of
rpmlint find new things to complain about.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189048

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2006-05-07 17:02 EST -------
Imported into CVS, branches created, and builds requested.

[Bug 189048] Review Request: perl-CPANPLUS

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: perl-CPANPLUS

https://bugzilla.redhat.com/show_bug.cgi?id=189048

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |medium
           Priority|normal                      |medium
            Product|Fedora Extras               |Fedora
            Version|devel                       |rawhide