[Bug 633240] New: Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mod_auth_token - token based URI access for apache

https://bugzilla.redhat.com/show_bug.cgi?id=633240

           Summary: Review Request: mod_auth_token - token based URI
                    access for apache
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: janfrode(a)tanso.net
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
   Estimated Hours: 0.0
    Classification: Fedora


Spec URL: http://blag.tanso.net/code/mod_auth_token.spec
SRPM URL: http://blag.tanso.net/code/mod_auth_token-1.0.6-beta.tar.gz
Description: 
mod_auth_token allow you to generate URIS for a determined time window,
you can also limit them by IP. This is very useful to handle file
downloads, generated URIS can't be hot-linked (after it expires), also
it allows you to protect very large files that can't be piped trough a
script languages due to memory limitation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 633240] Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633240

Andreas Thienemann <andreas(a)bawue.net&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |andreas(a)bawue.net
         AssignedTo|nobody(a)fedoraproject.org    |andreas(a)bawue.net

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 633240] Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633240

--- Comment #1 from Andreas Thienemann <andreas(a)bawue.net&gt; 2010-11-25 11:43:01 EST
---
I noticed that you do wrote on your wikipage, that you do not have access to
fedora yet. Is that still correct? Do you need sponsoring for this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 633240] Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633240

--- Comment #2 from Jan-Frode Myklebust <janfrode(a)tanso.net&gt; 2010-11-27 03:24:42 EST
---
I'm not familiar with the sponsoring system, but yes, I don't have access to
any fedora infrastructure, and would probably need some sponsoring.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 633240] Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633240

Lukáš Zapletal <lzap(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lzap(a)redhat.com
             Blocks|                            |177841(FE-NEEDSPONSOR)

--- Comment #3 from Lukáš Zapletal <lzap(a)redhat.com&gt; 2012-04-02 11:14:24 EDT ---
@Jan - you did not set FE-NEEDSPONSOR depedency. It is likely sponsors will be
missing your requests.

http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

@Andreas - Are you still working on this review?

NOTE TO SPONSOR: This package is still valid, 1.0.6-beta is the latest version
and I can do review if interested.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 633240] Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633240

--- Comment #4 from Lukáš Zapletal <lzap(a)redhat.com&gt; 2012-04-02 11:42:41 EDT ---
@Jan - I set the dependency for you.

SRPM URL is not valid, you are linking tarball (which is broken btw). The valid
url is: 

http://mod-auth-token.googlecode.com/files/mod_auth_token-1.0.6-beta.tar.gz

My first look:

%setup -q -n %{name}-%{version}-%{release}

this is no longer valid for the current tarball, change to

%setup -q -n %{name}

Apparently, the upstream touched the tarball, this is not good. Also there is
permissions issue with the upstream tarball, permissions are not right and
unfortunately root user is needed to fix this or we cannot use the prep macro.

I have contacted upstream:
http://code.google.com/p/mod-auth-token/issues/detail?id=31

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 633240] Review Request: mod_auth_token - token based URI access for apache

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633240

Lukáš Zapletal <lzap(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(janfrode(a)tanso.ne
                   |                            |t)

--- Comment #5 from Lukáš Zapletal <lzap(a)redhat.com&gt; 2012-04-02 12:34:55 EDT ---
Whole autotools seem to be broken in trunk, I'd suggest to compile the module
with:

apxs -a -c mod_auth_token.c

and then copying over to the correct place.

@Jan - can you do the changes and publish new spec file?

- use 1.0.5 version that has correct permissions or correct permissions for the
1.0.6b version
- compile it with apxs directly

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.