[Bug 1294852] New: Review Request: kf5-libksane - SANE Library interface for KDE - package-review

List overview All Threads
Download

newer

[Bug 1294852] New: Review Request: kf5-libksane - SANE Library interface for KDE

older

[Bug 1321300] New: Review Request:...

[Bug 1251136] New: Review Request:...

Red Hat Bugzilla

30 Dec 2015 30 Dec '15

11:14 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Bug ID: 1294852 Summary: Review Request: kf5-libksane - SANE Library interface for KDE Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rdieter@math.unl.edu QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-libksane.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kf5/kf5-libksane-15.12.0-1.fc23.src.rp... Description: SANE Library interface for KDE Fedora Account System Username: rdieter

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

30 Dec 30 Dec

11:14 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Rex Dieter rdieter@math.unl.edu changed:

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1294838 [Bug 1294838] digikam-5.0 tracker

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:27 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #1 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- rdieter's scratch build of kf5-libksane-15.12.0-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12349465

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Jan 16 Jan

2:11 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Pier Luigi Fiorini pierluigi.fiorini@gmail.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:47 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Pier Luigi Fiorini pierluigi.fiorini@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Feb 7 Feb

1:57 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #2 from Rex Dieter rdieter@math.unl.edu --- ping, do you plan on continuing reviewing this package?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8 Feb 8 Feb

3:29 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Pier Luigi Fiorini pierluigi.fiorini@gmail.com changed:

--- Comment #3 from Pier Luigi Fiorini pierluigi.fiorini@gmail.com --- Yes I will do it tonight. Sorry for the delay.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:45 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #4 from Pier Luigi Fiorini pierluigi.fiorini@gmail.com --- name: ok

source: ok SHA1 0c69697a66d6d0908d3822ecebedb08c2c424942 libksane-15.12.0.tar.xz

license: ok

post/postun ldconfig: ok

filelist: ok

APPROVE

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9 Feb 9 Feb

1:52 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Mattia Verga mattia.verga@tiscali.it changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mattia.verga@tiscali.it

--- Comment #5 from Mattia Verga mattia.verga@tiscali.it --- Pier Luigi, I don't think this way of conducting reviews are acceptable. You do them in a too simplified way.

You should follow the entire checklist on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/Revie... or you can use fedora-review tool to automate that.

For example, in this review the .src.rpm file refers to libksane-15.12.0 while the .spec file is for libksane-15.12.1 and using fedora-review the check fails.

I know Rex is a "trusted" packager, but for the future please make reviews with better quality.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Feb 15 Feb

5:30 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #6 from Pier Luigi Fiorini pierluigi.fiorini@gmail.com ---

...

Pier Luigi, I don't think this way of conducting reviews are acceptable. You do > them in a too simplified way.

You should follow the entire checklist on https://fedoraproject.org/wiki/Packaging:ReviewGuidelines?rd=Packaging/Revie... or you can use fedora-review tool to automate that.

For simplicity I didn't put all the review check list items in the report here. Thanks for suggesting fedora-review.

...

For example, in this review the .src.rpm file refers to libksane-15.12.0 while > the .spec file is for libksane-15.12.1 and using fedora-review the check fails.

That was changed after I picked up the review but didn't come to my mind to download the files again. Next time I'll be more accurate.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

21 Feb 21 Feb

5:57 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #7 from Rex Dieter rdieter@math.unl.edu --- Pier, you said approve in comment #4, but did not set the fedora-review flag to + , can you do so please?

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:30 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Pier Luigi Fiorini pierluigi.fiorini@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Mar 29 Mar

9:02 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Rex Dieter rdieter@math.unl.edu changed:

--- Comment #8 from Rex Dieter rdieter@math.unl.edu --- imported, thanks

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:26 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #9 from Fedora Update System updates@fedoraproject.org --- kf5-libksane-15.12.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0ceed9b2b

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:27 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- kf5-libksane-15.12.3-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2f57ba56a

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Mar 30 Mar

5:27 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Fedora Update System updates@fedoraproject.org changed:

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- kf5-libksane-15.12.3-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d0ceed9b2b

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:55 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- kf5-libksane-15.12.3-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a2f57ba56a

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Apr 3 Apr

12:57 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- kf5-libksane-15.12.3-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:57 p.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

Fedora Update System updates@fedoraproject.org changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Apr 7 Apr

10:52 a.m.

New subject: [Bug 1294852] Review Request: kf5-libksane - SANE Library interface for KDE

https://bugzilla.redhat.com/show_bug.cgi?id=1294852

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- kf5-libksane-15.12.3-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3394

Age (days ago)

3493

Last active (days ago)

package-review@lists.fedoraproject.org

19 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla