[Bug 2330453] New: Review Request: python-rich-toolkit - Rich toolkit for building command-line applications
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
Bug ID: 2330453 Summary: Review Request: python-rich-toolkit - Rich toolkit for building command-line applications Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: code@musicinmybrain.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Blocks: 2330376 Target Milestone: --- Classification: Fedora
Spec URL: https://music.fedorapeople.org/python-rich-toolkit.spec SRPM URL: https://music.fedorapeople.org/python-rich-toolkit-0.11.3-1.fc41.src.rpm
Description:
This is a very opinionated set of components for building CLI applications. It is based on Rich.
Fedora Account System Username: music
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2330376 [Bug 2330376] fastapi-cli-0.0.6 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8342042 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Found issues:
- python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packag...
Please know that there can be false-positives.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |benson_muite@emailplus.org Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #2 from Benson Muite benson_muite@emailplus.org --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "*No copyright* MIT License", "Unknown or generated". 24 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-rich- toolkit/2330453-python-rich-toolkit/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 12870 bytes in 9 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python3-rich-toolkit-0.11.3-1.fc42.noarch.rpm python-rich-toolkit-0.11.3-1.fc42.src.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpimsg08w3')] checks: 32, packages: 2
== 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 3.6 s ==
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 1.0 s
Source checksums ---------------- https://files.pythonhosted.org/packages/source/r/rich_toolkit/rich_toolkit-0... : CHECKSUM(SHA256) this package : 042cee58083e0bcbb56a69514b56a5def853ad064f977b6b95519087e4d9f239 CHECKSUM(SHA256) upstream package : 042cee58083e0bcbb56a69514b56a5def853ad064f977b6b95519087e4d9f239
Requires -------- python3-rich-toolkit (rpmlib, GLIBC filtered): python(abi) python3.13dist(click) python3.13dist(rich) python3.13dist(typing-extensions)
Provides -------- python3-rich-toolkit: python-rich-toolkit python3-rich-toolkit python3.13-rich-toolkit python3.13dist(rich-toolkit) python3dist(rich-toolkit)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2330453 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: Java, PHP, fonts, Ocaml, Perl, R, Haskell, SugarActivity, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Approved b) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2329630 would be appreciated if time allows.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #3 from Ben Beasley code@musicinmybrain.net ---
Comments: a) Approved
Thank you for the review!
b) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2329630 would be appreciated if time allows.
I will take a look at it. I need to clear out a handful of reviews I have in progress first.
https://release-monitoring.org/project/375740/
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rich-toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-6f8a5ecdf0 (python-rich-toolkit-0.12.0-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6f8a5ecdf0
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2024-12-05 12:57:22
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-6f8a5ecdf0 (python-rich-toolkit-0.12.0-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f398660f8f (fastapi-cli-0.0.6-1.fc41 and python-rich-toolkit-0.12.0-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f398660f8f
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f398660f8f has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f398660f8f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f398660f8f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f398660f8f has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f398660f8f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f398660f8f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f398660f8f has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f398660f8f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f398660f8f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f398660f8f has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f398660f8f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f398660f8f
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2330453
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2024-f398660f8f (fastapi-cli-0.0.7-1.fc41, python-fastapi-0.115.6-3.fc41, and 4 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com