[Bug 784857] New: Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

https://bugzilla.redhat.com/show_bug.cgi?id=784857

           Summary: Review Request: rubygem-openstack-compute - OpenStack
                    Compute Ruby API
           Product: Fedora
           Version: rawhide
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: unspecified
          Priority: unspecified
         Component: Package Review
        AssignedTo: nobody(a)fedoraproject.org
        ReportedBy: bkabrda(a)redhat.com
         QAContact: extras-qa(a)fedoraproject.org
                CC: notting(a)redhat.com,
                    package-review(a)lists.fedoraproject.org
    Classification: Fedora
      Story Points: ---
              Type: ---
        Regression: ---
        Mount Type: ---
     Documentation: ---


SPEC:
http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-...
SRPM:
http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-...
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3734637

Ruby Openstack Compute binding for the v1.0 OSAPI.
Currently supports both v1.0 and v2.0 (keystone) auth.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

Vít Ondruch <vondruch(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |vondruch(a)redhat.com
         AssignedTo|nobody(a)fedoraproject.org    |vondruch(a)redhat.com
               Flag|                            |fedora-review?

--- Comment #1 from Vít Ondruch <vondruch(a)redhat.com&gt; 2012-01-26 09:17:24 EST ---
I'll take it for a review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

--- Comment #2 from Vít Ondruch <vondruch(a)redhat.com&gt; 2012-01-26 10:47:22 EST ---
* Version in patch name is questionable
  - If the patch is not accepted by upstream for next release, you will need
    either to rename the patch or remove the %{version} macro anyway,
    so I would suggest to not use macro in this case

* The test suite should not be carried by resulting gem
  - Although I appreciate that you are executing test suite, I suggest its
    unpacking just in %check section, which prevents its inclusion in
    resulting package.

    %check
    tar xzvf %{SOURCE1} -C .%{geminstdir}

* MiniTest instead of TestUnit
  - Have you considered using Minitest, which is now default in Ruby, instead
of
    test-unit?

* rpmlint
  - Please fix following rpmlint error:

    rubygem-openstack-compute.noarch: E: non-executable-script \
      /usr/share/gems/gems/openstack-compute-1.1.5/lib/openstack/compute.rb \
      0664L /usr/bin/env

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

--- Comment #3 from Bohuslav Kabrda <bkabrda(a)redhat.com&gt; 2012-01-27 01:54:49 EST
---
(In reply to comment #2)
>  * Version in patch name is questionable
>    - If the patch is not accepted by upstream for next release, you will need
>      either to rename the patch or remove the %{version} macro anyway,
>      so I would suggest to not use macro in this case
>   
True, done.

>  * The test suite should not be carried by resulting gem
>    - Although I appreciate that you are executing test suite, I suggest its
>      unpacking just in %check section, which prevents its inclusion in
>      resulting package.
>  
>      %check
>      tar xzvf %{SOURCE1} -C .%{geminstdir}
>   
Done.

>  * MiniTest instead of TestUnit
>    - Have you considered using Minitest, which is now default in Ruby, instead
>  of
>      test-unit?
>   
Yes, tests work the same way with minitest, so I switched to it.

>  * rpmlint
>    - Please fix following rpmlint error:
>  
>      rubygem-openstack-compute.noarch: E: non-executable-script \
>        /usr/share/gems/gems/openstack-compute-1.1.5/lib/openstack/compute.rb \
>        0664L /usr/bin/env 
Fixed.

SPEC:
http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-...
SRPM:
http://bkabrda.fedorapeople.org/pkgs/openstack-compute/rubygem-openstack-...
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3738691

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

Vít Ondruch <vondruch(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Vít Ondruch <vondruch(a)redhat.com&gt; 2012-01-27 03:08:53 EST ---
I have no other objections => APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

Bohuslav Kabrda <bkabrda(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #5 from Bohuslav Kabrda <bkabrda(a)redhat.com&gt; 2012-01-27 06:46:21 EST
---
Thank you for your review!

New Package SCM Request
=======================
Package Name: rubygem-openstack-compute
Short Description: OpenStack Compute Ruby API
Owners: bkabrda
Branches: 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

--- Comment #6 from Jon Ciesla <limburgher(a)gmail.com&gt; 2012-01-27 08:11:56 EST ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug 784857] Review Request: rubygem-openstack-compute - OpenStack Compute Ruby API

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=784857

Bohuslav Kabrda <bkabrda(a)redhat.com&gt; changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE
        Last Closed|                            |2012-01-27 08:37:17

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.