Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: python-straight.plugin - Python plugin loader
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Summary: Review Request: python-straight.plugin - Python plugin loader Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pingou@pingoured.fr QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
Spec URL: http://pingou.fedorapeople.org/RPMs/python-straight.plugin.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/python-straight.plugin-1.1.1-1.57ef11c.f... Description: straight.plugin is a Python plugin loader inspired by twisted.plugin with two important distinctions:
- Fewer dependencies - Python 3 compatible
The system is used to allow multiple Python packages to provide plugins within a namespace package, where other packages will locate and utilize. The plugins themselves are modules in a namespace package where the namespace identifies the plugins in it for some particular purpose or intent.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Toshio Ernie Kuratomi a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |a.badger@gmail.com AssignedTo|nobody@fedoraproject.org |a.badger@gmail.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #1 from Toshio Ernie Kuratomi a.badger@gmail.com 2011-11-10 15:20:21 EST --- Talked on IRC and spec file has been updated. This review is based on the tarball from the srpm and the new spec file
rpmlint:
python-straight.plugin.noarch: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging [snip other spelling warnings]
These are all false positives -- the words are common in computing.
python-straight.plugin.src: W: invalid-url Source0: ironfroggy-straight.plugin-57ef11c.tar.gz
There is a comment above the Source0 explaining how to retrieve the tarball from github so this is fine.
Good: * License is BSD in source and spec * LICENSE file included * Spec file is legible * Sources match with upstream by following the github url to get the snapshot. * Package builds in koji for f16 * No localized files so no i18n concerns * Not a shared library package so no concerns there * No bundled libraries * Package owns the directories it creates and nothing more * Files listed once in the %files section * File permissions are correct * Macros used consistently * Code, not content * No large documentation files * Documentation is not used at runtime * Not a GUI app * No supbackages * All filenames are valid utf-8
Needswork: * Naming guidelines want "." replaced with "-" so this should be named python-straight-plugin. (and spec file renamed to match).
Cosmetic: * Could BuildRequire: python2-devel instead of python-devel * The description says python3 compatible but you aren't building a python3 subpackage. I'd either build the subpackage or remove that line from the description.
Fix the naming and I'll approve this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no Summary|Review Request: |Review Request: |python-straight.plugin - |python-straight-plugin - |Python plugin loader |Python plugin loader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #2 from Pierre-YvesChibon pingou@pingoured.fr 2011-11-10 16:22:00 EST --- Thanks for your comments (here and on irc) and the review.
I changed the name and added a python3 sub-package. I used 2to3 to generate the sub-package although it seems unnecessary but for the future, better safe than sorry.
Spec URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin-1.1.1-0.2.2011111...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #3 from Pierre-YvesChibon pingou@pingoured.fr 2011-11-10 16:40:39 EST --- There is the new version with the correct use of %{__python3} on the build and test
Spec URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin.spec SRPM URL: http://pingou.fedorapeople.org/RPMs/python-straight-plugin-1.1.1-0.3.2011111...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Toshio Ernie Kuratomi a.badger@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+
--- Comment #4 from Toshio Ernie Kuratomi a.badger@gmail.com 2011-11-10 16:41:57 EST --- All problems have been fixed.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Pierre-YvesChibon pingou@pingoured.fr 2011-11-10 16:45:25 EST --- New Package SCM Request ======================= Package Name: python-straight-plugin Short Description: Python plugin loader Owners: pingou sochotnicky Branches: f15 f16 el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #6 from Pierre-YvesChibon pingou@pingoured.fr 2011-11-11 02:09:53 EST --- Fix Stanislav's FAS username
New Package SCM Request ======================= Package Name: python-straight-plugin Short Description: Python plugin loader Owners: pingou sochotni Branches: f15 f16 el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #7 from Jon Ciesla limb@jcomserv.net 2011-11-11 08:25:50 EST --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2011-11-11 12:58:37 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-straight-plugin-1.1.1-0.7.201...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2011-11-11 12:58:44 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-straight-plugin-1.1.1-0.7.201...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2011-11-11 12:58:53 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-straight-plugin-1.1.1-0.7.201...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2011-11-11 14:55:29 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6 has been pushed to the Fedora EPEL 6 testing repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |python-straight-plugin-1.1. | |1-0.7.20111110.git57ef11c.f | |c15 Resolution| |ERRATA Last Closed| |2011-11-23 18:28:40
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-11-23 18:28:40 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc15 has been pushed to the Fedora 15 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-straight-plugin-1.1. |python-straight-plugin-1.1. |1-0.7.20111110.git57ef11c.f |1-0.7.20111110.git57ef11c.f |c15 |c16
--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-11-23 18:32:46 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.fc16 has been pushed to the Fedora 16 stable repository.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|python-straight-plugin-1.1. |python-straight-plugin-1.1. |1-0.7.20111110.git57ef11c.f |1-0.7.20111110.git57ef11c.e |c16 |l6
--- Comment #14 from Fedora Update System updates@fedoraproject.org 2011-11-29 14:03:28 EST --- python-straight-plugin-1.1.1-0.7.20111110.git57ef11c.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs+ |fedora-cvs?
--- Comment #15 from Pierre-YvesChibon pingou@pingoured.fr --- Package Change Request ====================== Package Name: python-straight-plugin New Branches: epel7 Owners: pingou
https://bugzilla.redhat.com/show_bug.cgi?id=752938
Pierre-YvesChibon pingou@pingoured.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
--- Comment #16 from Pierre-YvesChibon pingou@pingoured.fr --- Thanks @Till!
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla