[Bug 346161] New: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=346161

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video
                    driver
           Product: Fedora
           Version: devel
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL:
http://kwizart.free.fr/fedora/7/testing/xorg-x11-drv-ivtv/xorg-x11-drv-ivtv-...
SRPM URL:
http://kwizart.free.fr/fedora/7/testing/xorg-x11-drv-ivtv/xorg-x11-drv-ivtv-...
Description: Xorg X11 ivtv video driver

This xorg driver needs testing and ivtv-firmware to be submitted...
kernel module is part of the kernel but it seems there is some problem with vanilla 2.6.23 kernels and some userland apps (mythtv) - See the README included

Anyway, that Xorg part are supposed to be compatible with any ivtv drivers from >= 0.2.

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

------- Additional Comments From [e-mail]  2007-10-22 21:15 EST -------

Spec URL:
http://kwizart.free.fr/fedora/7/testing/xorg-x11-drv-ivtv/xorg-x11-drv-ivtv....
koji task:
http://koji.fedoraproject.org/koji/taskinfo?taskID=206411

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  BugsThisDependsOn|                            |346171

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

------- Additional Comments From [e-mail]  2007-10-23 01:36 EST -------
This is a basic xorg driver; nothing fancy.  rpmlint is silent and everything
looks good.  I have the firmware in a local repo so that this will install
properly for me, but I don't have the hardware to test this on.

You might want to flesh out the description just a little bit if possible. 
Specifically, it would be nice to know which boards are supported.  It looks
like it only works with the PVR350; I'm not sure that the other boards have a
framebuffer or even do any output.

* source files match upstream:
   e98a2ed67fea25ab7f94eecb5a53a2d3a3c42de93557d77d774fa18d311c807a  
   xf86-video-ivtv-1.0.0.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
? description is OK (might be nice to include a little more info)
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   ivtv_drv.so()(64bit)
   xorg-x11-drv-ivtv = 1.0.0-1.fc8
  =
   ivtv-firmware
   xorg-x11-server-Xorg >= 1.3.0.0-6

* %check is not present; I've no way to test this package.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2007-10-23 07:33 EST -------
New Package CVS Request
=======================
Package Name:      xorg-x11-drv-ivtv
Short Description: Xorg X11 ivtv video driver
Owners:            kwizart
Branches:          F-8 F-7
InitialCC:         <empty>
Commits by cvsextras: yes

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2007-10-23 13:14 EST -------
cvs done.

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|devel                       |rawhide

Bug 346161 depends on bug 346171, which changed state.

Bug 346171 Summary: Review Request: ivtv-firmware - Firmware for the PVR 250/350/150/500 model series
https://bugzilla.redhat.com/show_bug.cgi?id=346171

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |DUPLICATE

[Bug 346161] Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xorg-x11-drv-ivtv - Xorg X11 ivtv video driver

https://bugzilla.redhat.com/show_bug.cgi?id=346161

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-03-06 15:11 EST -------
Ok libpciaccess and another patch fixed upstream.
Closing to next release